From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Jarkko Sakkinen <jarkko.sakkinen@linux•intel.com>
Cc: linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
Christophe Ricard <christophe.ricard@gmail•com>
Subject: Re: linux-next: build failure after merge of the tpmdd tree
Date: Sun, 1 May 2016 23:12:22 +1000 [thread overview]
Message-ID: <20160501231222.42557edf@canb.auug.org.au> (raw)
In-Reply-To: <1461834144.3482.4.camel@linux.intel.com>
Hi Jarkko,
On Thu, 28 Apr 2016 12:02:24 +0300 Jarkko Sakkinen <jarkko.sakkinen@linux•intel.com> wrote:
>
> On Thu, 2016-04-28 at 15:32 +1000, Stephen Rothwell wrote:
> > Hi Jarkko,
> >
> > After merging the tpmdd tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> >
> > In file included from /home/sfr/next/next/include/linux/rcupdate.h:38:0,
> > from /home/sfr/next/next/include/linux/idr.h:18,
> > from /home/sfr/next/next/include/linux/kernfs.h:14,
> > from /home/sfr/next/next/include/linux/sysfs.h:15,
> > from /home/sfr/next/next/include/linux/kobject.h:21,
> > from /home/sfr/next/next/include/linux/device.h:17,
> > from /home/sfr/next/next/include/linux/dma-mapping.h:6,
> > from /home/sfr/next/next/drivers/char/tpm/tpm_ibmvtpm.c:18:
> > /home/sfr/next/next/drivers/char/tpm/tpm_ibmvtpm.c: In function 'tpm_ibmvtpm_probe':
> > /home/sfr/next/next/include/linux/spinlock.h:295:1: error: expected ';' before 'do'
> > do { \
> > ^
> > /home/sfr/next/next/drivers/char/tpm/tpm_ibmvtpm.c:632:2: note: in expansion of macro
> > 'spin_lock_init'
> > spin_lock_init(&ibmvtpm->rtce_lock);
> > ^
> >
> > Caused by commit
> >
> > 28157164b056 ("tpm: Remove useless priv field in struct tpm_vendor_specific")
> >
> > A ';' was missed.
> >
> > I added the following patch for today.
>
> Sorry about this and thank you.
>
> /Jarkko
>
> > From: Stephen Rothwell <sfr@canb•auug.org.au>
> > Date: Thu, 28 Apr 2016 15:27:17 +1000
> > Subject: [PATCH] tpm: fix for typo in tpm/tpm_ibmvtpm.c
> >
> > Fixes: 28157164b056 ("tpm: Remove useless priv field in struct tpm_vendor_specific")
> > Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
> > ---
> > drivers/char/tpm/tpm_ibmvtpm.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c
> > index 6b22826f0e11..946025a7413b 100644
> > --- a/drivers/char/tpm/tpm_ibmvtpm.c
> > +++ b/drivers/char/tpm/tpm_ibmvtpm.c
> > @@ -627,7 +627,7 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev,
> >
> > crq_q->index = 0;
> >
> > - dev_set_drvdata(&chip->dev, ibmvtpm)
> > + dev_set_drvdata(&chip->dev, ibmvtpm);
> >
> > spin_lock_init(&ibmvtpm->rtce_lock);
> >
> > --
> > 2.7.0
> >
Ping?
--
Cheers,
Stephen Rothwell
next prev parent reply other threads:[~2016-05-01 13:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-28 5:32 linux-next: build failure after merge of the tpmdd tree Stephen Rothwell
2016-04-28 9:02 ` Jarkko Sakkinen
2016-05-01 13:12 ` Stephen Rothwell [this message]
2016-05-02 11:10 ` Jarkko Sakkinen
2016-05-02 12:19 ` Stephen Rothwell
2016-05-02 16:26 ` Jarkko Sakkinen
-- strict thread matches above, loose matches on Subject: below --
2017-05-10 3:23 Stephen Rothwell
2017-05-10 12:51 ` Jarkko Sakkinen
2019-04-16 3:07 Stephen Rothwell
2019-04-16 15:36 ` Jarkko Sakkinen
2019-04-18 19:40 ` Matthew Garrett
2019-04-30 14:47 ` Jarkko Sakkinen
2019-06-05 2:09 Stephen Rothwell
2019-06-05 14:52 ` Jarkko Sakkinen
2023-03-21 0:54 Stephen Rothwell
2023-03-24 2:20 ` Stephen Rothwell
2023-03-29 22:05 ` Jarkko Sakkinen
2023-03-29 22:03 ` Jarkko Sakkinen
2023-04-27 12:55 broonie
2023-04-27 19:06 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160501231222.42557edf@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=christophe.ricard@gmail$(echo .)com \
--cc=jarkko.sakkinen@linux$(echo .)intel.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox