From: Jarkko Sakkinen <jarkko.sakkinen@linux•intel.com>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: Linux-Next Mailing List <linux-next@vger•kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Jason Gunthorpe <jgunthorpe@obsidianresearch•com>
Subject: Re: linux-next: build failure after merge of the tpmdd tree
Date: Wed, 10 May 2017 15:51:57 +0300 [thread overview]
Message-ID: <20170510125157.dfv7dg7fbrmtbkzq@intel.com> (raw)
In-Reply-To: <20170510132327.599ddc02@canb.auug.org.au>
Hi
On Wed, May 10, 2017 at 01:23:27PM +1000, Stephen Rothwell wrote:
> Hi Jarkko,
>
> After merging the tpmdd tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/char/tpm/tpm_tis.c: In function 'tpm_tis_init':
> drivers/char/tpm/tpm_tis.c:193:23: error: passing argument 1 of 'check_acpi_tpm2' from incompatible pointer type [-Werror=incompatible-pointer-types]
> rc = check_acpi_tpm2(dev);
> ^
> drivers/char/tpm/tpm_tis.c:129:12: note: expected 'struct acpi_device *' but argument is of type 'struct device *'
> static int check_acpi_tpm2(struct acpi_device *dev)
> ^
>
> Caused by commit
>
> e3b975d27b46 ("tpm_tis: Consolidate the platform and acpi probe flow")
>
> CONFIG_ACPI is not set for this build.
>
> I have added the following patch for today.
>
> From: Stephen Rothwell <sfr@canb•auug.org.au>
> Date: Wed, 10 May 2017 13:15:35 +1000
> Subject: [PATCH] tpm_tis: fixup for CONFIG_ACPI not set
>
> Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
> ---
> drivers/char/tpm/tpm_tis.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
> index 54d90e31a7b6..b14d4aa97af8 100644
> --- a/drivers/char/tpm/tpm_tis.c
> +++ b/drivers/char/tpm/tpm_tis.c
> @@ -126,7 +126,7 @@ static int check_acpi_tpm2(struct device *dev)
> return 0;
> }
> #else
> -static int check_acpi_tpm2(struct acpi_device *dev)
> +static int check_acpi_tpm2(struct device *dev)
> {
> return 0;
> }
> --
> 2.11.0
>
> --
> Cheers,
> Stephen Rothwell
Thank you! I'll squash this.
/Jarkko
next prev parent reply other threads:[~2017-05-10 12:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-10 3:23 linux-next: build failure after merge of the tpmdd tree Stephen Rothwell
2017-05-10 12:51 ` Jarkko Sakkinen [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-04-27 12:55 broonie
2023-04-27 19:06 ` Jarkko Sakkinen
2023-03-21 0:54 Stephen Rothwell
2023-03-24 2:20 ` Stephen Rothwell
2023-03-29 22:05 ` Jarkko Sakkinen
2023-03-29 22:03 ` Jarkko Sakkinen
2019-06-05 2:09 Stephen Rothwell
2019-06-05 14:52 ` Jarkko Sakkinen
2019-04-16 3:07 Stephen Rothwell
2019-04-16 15:36 ` Jarkko Sakkinen
2019-04-18 19:40 ` Matthew Garrett
2019-04-30 14:47 ` Jarkko Sakkinen
2016-04-28 5:32 Stephen Rothwell
2016-04-28 9:02 ` Jarkko Sakkinen
2016-05-01 13:12 ` Stephen Rothwell
2016-05-02 11:10 ` Jarkko Sakkinen
2016-05-02 12:19 ` Stephen Rothwell
2016-05-02 16:26 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170510125157.dfv7dg7fbrmtbkzq@intel.com \
--to=jarkko.sakkinen@linux$(echo .)intel.com \
--cc=jgunthorpe@obsidianresearch$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox