public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Kalle Valo <kvalo@codeaurora•org>,
	Wireless <linux-wireless@vger•kernel.org>,
	David Miller <davem@davemloft•net>,
	Networking <netdev@vger•kernel.org>
Cc: Linux-Next Mailing List <linux-next@vger•kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
	Igor Mitsyanko <igor.mitsyanko.os@quantenna•com>,
	Dmitrii Lebed <dlebed@quantenna•com>,
	Sergei Maksimenko <smaksimenko@quantenna•com>,
	Sergey Matyukevich <smatyukevich@quantenna•com>,
	Bindu Therthala <btherthala@quantenna•com>,
	Huizhao Wang <hwang@quantenna•com>,
	Kamlesh Rath <krath@quantenna•com>,
	Avinash Patil <avinashp@quantenna•com>
Subject: linux-next: build failure after merge of the wireless-drivers-next tree
Date: Thu, 8 Jun 2017 12:27:59 +1000	[thread overview]
Message-ID: <20170608122759.7ffda0c3@canb.auug.org.au> (raw)

Hi all,

After merging the wireless-drivers-next tree, today's linux-next build
(x86_64 allmodconfig) failed like this:

drivers/net/wireless/quantenna/qtnfmac/core.c: In function 'qtnf_core_net_attach':
drivers/net/wireless/quantenna/qtnfmac/core.c:319:5: error: 'struct net_device' has no member named 'destructor'
  dev->destructor = free_netdev;
     ^

Caused by commit

  98f44cb0655c ("qtnfmac: introduce new FullMAC driver for Quantenna chipsets")

interacting with commit

  cf124db566e6 ("net: Fix inconsistent teardown and release of private netdev state.")

from the net tree.

I applied this merge fix patch for today.

From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Thu, 8 Jun 2017 12:24:08 +1000
Subject: [PATCH] qtnfmac: fix up for "net: Fix inconsistent teardown and
 release of private netdev state."

Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
---
 drivers/net/wireless/quantenna/qtnfmac/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/quantenna/qtnfmac/core.c b/drivers/net/wireless/quantenna/qtnfmac/core.c
index c5ac252464f4..f053532c0e87 100644
--- a/drivers/net/wireless/quantenna/qtnfmac/core.c
+++ b/drivers/net/wireless/quantenna/qtnfmac/core.c
@@ -316,7 +316,7 @@ int qtnf_core_net_attach(struct qtnf_wmac *mac, struct qtnf_vif *vif,
 	vif->netdev = dev;
 
 	dev->netdev_ops = &qtnf_netdev_ops;
-	dev->destructor = free_netdev;
+	dev->needs_free_netdev = true;
 	dev_net_set(dev, wiphy_net(wiphy));
 	dev->ieee80211_ptr = &vif->wdev;
 	dev->ieee80211_ptr->iftype = iftype;
-- 
2.11.0

-- 
Cheers,
Stephen Rothwell

             reply	other threads:[~2017-06-08  2:28 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-08  2:27 Stephen Rothwell [this message]
2017-06-08  2:43 ` linux-next: build failure after merge of the wireless-drivers-next tree Igor Mitsyanko
2017-06-08  2:57   ` Stephen Rothwell
2017-06-08 12:07     ` Kalle Valo
2017-06-08 12:47       ` Stephen Rothwell
2017-06-13  2:00 ` Stephen Rothwell
2017-06-15 16:08   ` David Miller
2017-06-15 18:25     ` Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2020-12-08  8:49 Stephen Rothwell
2020-12-08  8:54 ` Kalle Valo
2018-08-03  8:29 Stephen Rothwell
2018-08-03  9:09 ` Kalle Valo
2018-08-03  9:11 ` Stanislaw Gruszka
2018-08-03  9:21   ` Stanislaw Gruszka
2016-07-19  6:08 Stephen Rothwell
2016-07-19  6:30 ` Kalle Valo
2016-07-19  6:51   ` Rafał Miłecki
2016-07-19  7:09     ` Kalle Valo
     [not found]       ` <871t2qw1cz.fsf-HodKDYzPHsUD5k0oWYwrnHL1okKdlPRT@public.gmane.org>
2016-07-19  7:11         ` Rafał Miłecki
2016-07-19 14:08           ` Kalle Valo
2016-07-19 18:39             ` Brian Norris
2016-07-19 23:36               ` Stephen Rothwell
2016-07-20 18:31               ` Kalle Valo
2016-02-18 23:10 Stephen Rothwell
2016-02-19  8:08 ` Kalle Valo
2015-08-07  3:16 Stephen Rothwell
2015-08-09  8:41 ` Kalle Valo
2015-07-22  0:32 Stephen Rothwell
2015-07-22  6:07 ` Kalle Valo
2015-07-27  5:41 ` Kalle Valo
2015-07-27  6:04   ` Stephen Rothwell
2015-05-27  2:03 Stephen Rothwell
2015-05-27  9:08 ` Arend van Spriel
2015-05-28  1:38   ` Stephen Rothwell
2015-01-27  8:03 Stephen Rothwell
2015-01-27  8:13 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170608122759.7ffda0c3@canb.auug.org.au \
    --to=sfr@canb$(echo .)auug.org.au \
    --cc=avinashp@quantenna$(echo .)com \
    --cc=btherthala@quantenna$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=dlebed@quantenna$(echo .)com \
    --cc=hwang@quantenna$(echo .)com \
    --cc=igor.mitsyanko.os@quantenna$(echo .)com \
    --cc=krath@quantenna$(echo .)com \
    --cc=kvalo@codeaurora$(echo .)org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=linux-wireless@vger$(echo .)kernel.org \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=smaksimenko@quantenna$(echo .)com \
    --cc=smatyukevich@quantenna$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox