From: Kalle Valo <kvalo@codeaurora•org>
To: "Rafał Miłecki" <zajec5@gmail•com>
Cc: Brian Norris <computersforpeace@gmail•com>,
"linux-mtd@lists•infradead.org" <linux-mtd@lists•infradead.org>,
Stephen Rothwell <sfr@canb•auug.org.au>,
"linux-wireless@vger•kernel.org" <linux-wireless@vger•kernel.org>,
linux-next <linux-next@vger•kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>
Subject: Re: linux-next: build failure after merge of the wireless-drivers-next tree
Date: Tue, 19 Jul 2016 17:08:59 +0300 [thread overview]
Message-ID: <87h9blvhxg.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CACna6ry6QgrbUoHuJacmr1EhHZyrwqsXfr51gENvY-0zM9L+3Q@mail.gmail.com> ("Rafał Miłecki"'s message of "Tue, 19 Jul 2016 09:11:11 +0200")
Rafał Miłecki <zajec5@gmail•com> writes:
> On 19 July 2016 at 09:09, Kalle Valo <kvalo@codeaurora•org> wrote:
>> Rafał Miłecki <zajec5@gmail•com> writes:
>>
>>> On 19 July 2016 at 08:30, Kalle Valo <kvalo@codeaurora•org> wrote:
>>>> Stephen Rothwell <sfr@canb•auug.org.au> writes:
>>>>
>>>>> After merging the wireless-drivers-next tree, today's linux-next build
>>>>> (powerpc allyesconfig) failed like this:
>>>>>
>>>>> drivers/mtd/devices/bcm47xxsflash.c: In function 'bcm47xxsflash_bcma_probe':
>>>>> drivers/mtd/devices/bcm47xxsflash.c:299:17: error: implicit declaration of function 'ioremap_cache' [-Werror=implicit-function-declaration]
>>>>> b47s->window = ioremap_cache(res->start, resource_size(res));
>>>>> ^
>>>>> drivers/mtd/devices/bcm47xxsflash.c:299:15: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
>>>>> b47s->window = ioremap_cache(res->start, resource_size(res));
>>>>> ^
>>>>>
>>>>> Caused by commit
>>>>>
>>>>> 57d8f7dd2132 ("bcma: allow enabling serial flash support on non-MIPS SoCs")
>>>>>
>>>>> I have reverted that commit for today.
>>>>
>>>> Thanks, kbuild bot also notified about this.
>>>>
>>>> Rafał, as the merge window is getting really close I would like to
>>>> revert this for now and we can reapply it once we the problem is fully
>>>> solved. And we can use my pending branch for build testing the patch
>>>> with kbuild bot. What do you think?
>>>
>>> The simplest fix sounds pretty much as simple as the revert.
>>
>> The problem is that I don't have much time, I need to send the pull
>> request to Dave within next few days. The fix might create other
>> problems so I'm not enthusiastic about iterating with this patch at the
>> moment. I think it can wait for 4.9.
>
> I sent a patch seconds ago, you may just take a look at it. If you
> still prefer to revert my commit, go ahead.
Ok, let's try your fix. We still have few days. I applied the patch[1]
to the pending branch this morning and if I don't see any errors I apply
it later tonight and hopefully it will be in tomorrow's linux-next
build. Thanks for the quick fix, very much appreciated.
[1] "mtd: add arch dependency for MTD_BCM47XXSFLASH symbol"
https://patchwork.kernel.org/patch/9236053/
--
Kalle Valo
next prev parent reply other threads:[~2016-07-19 14:08 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-19 6:08 linux-next: build failure after merge of the wireless-drivers-next tree Stephen Rothwell
2016-07-19 6:30 ` Kalle Valo
2016-07-19 6:51 ` Rafał Miłecki
2016-07-19 7:09 ` Kalle Valo
[not found] ` <871t2qw1cz.fsf-HodKDYzPHsUD5k0oWYwrnHL1okKdlPRT@public.gmane.org>
2016-07-19 7:11 ` Rafał Miłecki
2016-07-19 14:08 ` Kalle Valo [this message]
2016-07-19 18:39 ` Brian Norris
2016-07-19 23:36 ` Stephen Rothwell
2016-07-20 18:31 ` Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2020-12-08 8:49 Stephen Rothwell
2020-12-08 8:54 ` Kalle Valo
2018-08-03 8:29 Stephen Rothwell
2018-08-03 9:09 ` Kalle Valo
2018-08-03 9:11 ` Stanislaw Gruszka
2018-08-03 9:21 ` Stanislaw Gruszka
2017-06-08 2:27 Stephen Rothwell
2017-06-08 2:43 ` Igor Mitsyanko
2017-06-08 2:57 ` Stephen Rothwell
2017-06-08 12:07 ` Kalle Valo
2017-06-08 12:47 ` Stephen Rothwell
2017-06-13 2:00 ` Stephen Rothwell
2017-06-15 16:08 ` David Miller
2017-06-15 18:25 ` Stephen Rothwell
2016-02-18 23:10 Stephen Rothwell
2016-02-19 8:08 ` Kalle Valo
2015-08-07 3:16 Stephen Rothwell
2015-08-09 8:41 ` Kalle Valo
2015-07-22 0:32 Stephen Rothwell
2015-07-22 6:07 ` Kalle Valo
2015-07-27 5:41 ` Kalle Valo
2015-07-27 6:04 ` Stephen Rothwell
2015-05-27 2:03 Stephen Rothwell
2015-05-27 9:08 ` Arend van Spriel
2015-05-28 1:38 ` Stephen Rothwell
2015-01-27 8:03 Stephen Rothwell
2015-01-27 8:13 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h9blvhxg.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora$(echo .)org \
--cc=computersforpeace@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mtd@lists$(echo .)infradead.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=zajec5@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox