From: Michal Hocko <mhocko@kernel•org>
To: Randy Dunlap <rdunlap@infradead•org>
Cc: akpm@linux-foundation•org, mm-commits@vger•kernel.org,
linux-kernel@vger•kernel.org, linux-mm@kvack•org,
linux-fsdevel@vger•kernel.org, linux-next@vger•kernel.org,
sfr@canb•auug.org.au, broonie@kernel•org,
"Jérôme Glisse" <jglisse@redhat•com>
Subject: Re: mmotm 2017-08-25-15-50 uploaded
Date: Mon, 28 Aug 2017 09:59:31 +0200 [thread overview]
Message-ID: <20170828075931.GC17097@dhcp22.suse.cz> (raw)
In-Reply-To: <3c9df006-0cc5-3a32-b715-1fbb43cb9ea8@infradead.org>
On Fri 25-08-17 16:50:26, Randy Dunlap wrote:
> On 08/25/17 15:50, akpm@linux-foundation•org wrote:
> > The mm-of-the-moment snapshot 2017-08-25-15-50 has been uploaded to
> >
> > http://www.ozlabs.org/~akpm/mmotm/
> >
> > mmotm-readme.txt says
> >
> > README for mm-of-the-moment:
> >
> > http://www.ozlabs.org/~akpm/mmotm/
> >
> > This is a snapshot of my -mm patch queue. Uploaded at random hopefully
> > more than once a week.
>
> lots of this one (on x86_64, i386, or UML):
>
> ../kernel/fork.c:818:2: error: implicit declaration of function 'hmm_mm_init' [-Werror=implicit-function-declaration]
> ../kernel/fork.c:897:2: error: implicit declaration of function 'hmm_mm_destroy' [-Werror=implicit-function-declaration]
>
> from mm-hmm-heterogeneous-memory-management-hmm-for-short-v5.patch
>
> Cc: Jérôme Glisse <jglisse@redhat•com>
This one should address it
---
>From 31d551dbcb1b7987a4cd07767c1e2805849b7a26 Mon Sep 17 00:00:00 2001
From: Michal Hocko <mhocko@suse•com>
Date: Mon, 28 Aug 2017 09:41:39 +0200
Subject: [PATCH]
mm-hmm-struct-hmm-is-only-use-by-hmm-mirror-functionality-v2-fix
Compiler is complaining for allnoconfig
kernel/fork.c: In function 'mm_init':
kernel/fork.c:814:2: error: implicit declaration of function 'hmm_mm_init' [-Werror=implicit-function-declaration]
hmm_mm_init(mm);
^
kernel/fork.c: In function '__mmdrop':
kernel/fork.c:893:2: error: implicit declaration of function 'hmm_mm_destroy' [-Werror=implicit-function-declaration]
hmm_mm_destroy(mm);
Make sure that hmm_mm_init/hmm_mm_destroy empty stups are defined when
CONFIG_HMM is disabled.
Signed-off-by: Michal Hocko <mhocko@suse•com>
---
include/linux/hmm.h | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/include/linux/hmm.h b/include/linux/hmm.h
index 9583d9a15f9c..aeb94e682dda 100644
--- a/include/linux/hmm.h
+++ b/include/linux/hmm.h
@@ -508,11 +508,10 @@ static inline void hmm_mm_init(struct mm_struct *mm)
{
mm->hmm = NULL;
}
-#else /* IS_ENABLED(CONFIG_HMM_MIRROR) */
+#endif
+
+#else /* IS_ENABLED(CONFIG_HMM) */
static inline void hmm_mm_destroy(struct mm_struct *mm) {}
static inline void hmm_mm_init(struct mm_struct *mm) {}
-#endif /* IS_ENABLED(CONFIG_HMM_MIRROR) */
-
-
#endif /* IS_ENABLED(CONFIG_HMM) */
#endif /* LINUX_HMM_H */
--
2.13.2
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack•org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack•org"> email@kvack•org </a>
next prev parent reply other threads:[~2017-08-28 7:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-25 22:50 mmotm 2017-08-25-15-50 uploaded akpm
2017-08-25 23:50 ` Randy Dunlap
2017-08-28 7:59 ` Michal Hocko [this message]
2017-08-28 8:27 ` Stephen Rothwell
2017-08-28 8:31 ` Michal Hocko
2017-08-28 15:46 ` Jerome Glisse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170828075931.GC17097@dhcp22.suse.cz \
--to=mhocko@kernel$(echo .)org \
--cc=akpm@linux-foundation$(echo .)org \
--cc=broonie@kernel$(echo .)org \
--cc=jglisse@redhat$(echo .)com \
--cc=linux-fsdevel@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mm-commits@vger$(echo .)kernel.org \
--cc=rdunlap@infradead$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox