From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Michal Hocko <mhocko@kernel•org>
Cc: "Randy Dunlap" <rdunlap@infradead•org>,
akpm@linux-foundation•org, mm-commits@vger•kernel.org,
linux-kernel@vger•kernel.org, linux-mm@kvack•org,
linux-fsdevel@vger•kernel.org, linux-next@vger•kernel.org,
broonie@kernel•org, "Jérôme Glisse" <jglisse@redhat•com>
Subject: Re: mmotm 2017-08-25-15-50 uploaded
Date: Mon, 28 Aug 2017 18:27:05 +1000 [thread overview]
Message-ID: <20170828182705.150afe66@canb.auug.org.au> (raw)
In-Reply-To: <20170828075931.GC17097@dhcp22.suse.cz>
Hi Michal,
On Mon, 28 Aug 2017 09:59:31 +0200 Michal Hocko <mhocko@kernel•org> wrote:
>
> From 31d551dbcb1b7987a4cd07767c1e2805849b7a26 Mon Sep 17 00:00:00 2001
> From: Michal Hocko <mhocko@suse•com>
> Date: Mon, 28 Aug 2017 09:41:39 +0200
> Subject: [PATCH]
> mm-hmm-struct-hmm-is-only-use-by-hmm-mirror-functionality-v2-fix
>
> Compiler is complaining for allnoconfig
>
> kernel/fork.c: In function 'mm_init':
> kernel/fork.c:814:2: error: implicit declaration of function 'hmm_mm_init' [-Werror=implicit-function-declaration]
> hmm_mm_init(mm);
> ^
> kernel/fork.c: In function '__mmdrop':
> kernel/fork.c:893:2: error: implicit declaration of function 'hmm_mm_destroy' [-Werror=implicit-function-declaration]
> hmm_mm_destroy(mm);
>
> Make sure that hmm_mm_init/hmm_mm_destroy empty stups are defined when
> CONFIG_HMM is disabled.
>
> Signed-off-by: Michal Hocko <mhocko@suse•com>
> ---
> include/linux/hmm.h | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/include/linux/hmm.h b/include/linux/hmm.h
> index 9583d9a15f9c..aeb94e682dda 100644
> --- a/include/linux/hmm.h
> +++ b/include/linux/hmm.h
> @@ -508,11 +508,10 @@ static inline void hmm_mm_init(struct mm_struct *mm)
> {
> mm->hmm = NULL;
> }
> -#else /* IS_ENABLED(CONFIG_HMM_MIRROR) */
> +#endif
> +
> +#else /* IS_ENABLED(CONFIG_HMM) */
> static inline void hmm_mm_destroy(struct mm_struct *mm) {}
> static inline void hmm_mm_init(struct mm_struct *mm) {}
> -#endif /* IS_ENABLED(CONFIG_HMM_MIRROR) */
> -
> -
> #endif /* IS_ENABLED(CONFIG_HMM) */
> #endif /* LINUX_HMM_H */
What happens when CONFIG_HMM is defined but CONFIG_HMM_MIRROR is not?
Or is that not possible (in which case why would we have
CONFIG_HMM_MIRROR)?
--
Cheers,
Stephen Rothwell
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack•org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack•org"> email@kvack•org </a>
next prev parent reply other threads:[~2017-08-28 8:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-25 22:50 mmotm 2017-08-25-15-50 uploaded akpm
2017-08-25 23:50 ` Randy Dunlap
2017-08-28 7:59 ` Michal Hocko
2017-08-28 8:27 ` Stephen Rothwell [this message]
2017-08-28 8:31 ` Michal Hocko
2017-08-28 15:46 ` Jerome Glisse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170828182705.150afe66@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=akpm@linux-foundation$(echo .)org \
--cc=broonie@kernel$(echo .)org \
--cc=jglisse@redhat$(echo .)com \
--cc=linux-fsdevel@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mhocko@kernel$(echo .)org \
--cc=mm-commits@vger$(echo .)kernel.org \
--cc=rdunlap@infradead$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox