* linux-next: build failure after merge of the drm-intel-fixes tree
@ 2017-10-10 7:03 Mark Brown
2017-10-11 8:51 ` Mark Brown
0 siblings, 1 reply; 4+ messages in thread
From: Mark Brown @ 2017-10-10 7:03 UTC (permalink / raw)
To: Daniel Vetter, Intel Graphics, DRI, Chris Wilson, Joonas Lahtinen,
Rodrigo Vivi
Cc: Linux-Next Mailing List, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 780 bytes --]
Hi all,
After merging the drm-misc-fixes tree, today's linux-next build
(x86_allmodconfig) failed like this:
CC [M] drivers/gpu/drm/i915/i915_gem_evict.o
drivers/gpu/drm/i915/i915_gem_evict.c: In function ‘i915_gem_evict_for_node’:
drivers/gpu/drm/i915/i915_gem_evict.c:318:31: error: implicit declaration of function ‘i915_vma_has_userfault’; did you mean ‘i915_vma_pin_count’? [-Werror=implicit-function-declaration]
if (flags & PIN_NONFAULT && i915_vma_has_userfault(vma)) {
^~~~~~~~~~~~~~~~~~~~~~
i915_vma_pin_count
Caused by commit
72872c99b6dbc ("drm/i915: Check PIN_NONFAULT overlaps in evict_for_node")
in the drm-intel-fixes tree. I've used the tree from yesterday.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: linux-next: build failure after merge of the drm-intel-fixes tree
2017-10-10 7:03 linux-next: build failure after merge of the drm-intel-fixes tree Mark Brown
@ 2017-10-11 8:51 ` Mark Brown
2017-10-11 17:39 ` [Intel-gfx] " Rodrigo Vivi
0 siblings, 1 reply; 4+ messages in thread
From: Mark Brown @ 2017-10-11 8:51 UTC (permalink / raw)
To: Daniel Vetter, Intel Graphics, DRI, Chris Wilson, Joonas Lahtinen,
Rodrigo Vivi
Cc: Linux-Next Mailing List, Linux Kernel Mailing List
[-- Attachment #1.1: Type: text/plain, Size: 907 bytes --]
On Tue, Oct 10, 2017 at 08:03:00AM +0100, Mark Brown wrote:
> Hi all,
>
> After merging the drm-misc-fixes tree, today's linux-next build
> (x86_allmodconfig) failed like this:
>
> CC [M] drivers/gpu/drm/i915/i915_gem_evict.o
> drivers/gpu/drm/i915/i915_gem_evict.c: In function ‘i915_gem_evict_for_node’:
> drivers/gpu/drm/i915/i915_gem_evict.c:318:31: error: implicit declaration of function ‘i915_vma_has_userfault’; did you mean ‘i915_vma_pin_count’? [-Werror=implicit-function-declaration]
> if (flags & PIN_NONFAULT && i915_vma_has_userfault(vma)) {
> ^~~~~~~~~~~~~~~~~~~~~~
> i915_vma_pin_count
>
> Caused by commit
>
> 72872c99b6dbc ("drm/i915: Check PIN_NONFAULT overlaps in evict_for_node")
>
> in the drm-intel-fixes tree. I've used the tree from yesterday.
This is still present today.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists•freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Intel-gfx] linux-next: build failure after merge of the drm-intel-fixes tree
2017-10-11 8:51 ` Mark Brown
@ 2017-10-11 17:39 ` Rodrigo Vivi
0 siblings, 0 replies; 4+ messages in thread
From: Rodrigo Vivi @ 2017-10-11 17:39 UTC (permalink / raw)
To: Mark Brown
Cc: Daniel Vetter, Intel Graphics, DRI, Chris Wilson, Joonas Lahtinen,
Linux-Next Mailing List, Linux Kernel Mailing List
On Wed, Oct 11, 2017 at 08:51:06AM +0000, Mark Brown wrote:
> On Tue, Oct 10, 2017 at 08:03:00AM +0100, Mark Brown wrote:
> > Hi all,
> >
> > After merging the drm-misc-fixes tree, today's linux-next build
> > (x86_allmodconfig) failed like this:
> >
> > CC [M] drivers/gpu/drm/i915/i915_gem_evict.o
> > drivers/gpu/drm/i915/i915_gem_evict.c: In function ‘i915_gem_evict_for_node’:
> > drivers/gpu/drm/i915/i915_gem_evict.c:318:31: error: implicit declaration of function ‘i915_vma_has_userfault’; did you mean ‘i915_vma_pin_count’? [-Werror=implicit-function-declaration]
> > if (flags & PIN_NONFAULT && i915_vma_has_userfault(vma)) {
> > ^~~~~~~~~~~~~~~~~~~~~~
> > i915_vma_pin_count
> >
> > Caused by commit
> >
> > 72872c99b6dbc ("drm/i915: Check PIN_NONFAULT overlaps in evict_for_node")
> >
> > in the drm-intel-fixes tree. I've used the tree from yesterday.
>
> This is still present today.
It is fixed now. Sorry for the trouble.
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists•freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* linux-next: build failure after merge of the drm-intel-fixes tree
@ 2022-01-31 22:27 Stephen Rothwell
2022-02-01 9:08 ` [Intel-gfx] " Tvrtko Ursulin
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2022-01-31 22:27 UTC (permalink / raw)
To: Daniel Vetter, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi,
Intel Graphics, DRI
Cc: Dan Carpenter, Tvrtko Ursulin, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 619 bytes --]
Hi all,
After merging the drm-intel-fixes tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/gpu/drm/i915/i915_vma.c: In function 'i915_vma_bind':
drivers/gpu/drm/i915/i915_vma.c:451:25: error: 'ret' undeclared (first use in this function); did you mean 'net'?
451 | ret = i915_gem_object_wait_moving_fence(vma->obj, true);
| ^~~
| net
Caused by commit
2e872d87cbf2 ("drm/i915: delete shadow "ret" variable")
I have reverted that commit for today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Intel-gfx] linux-next: build failure after merge of the drm-intel-fixes tree
2022-01-31 22:27 Stephen Rothwell
@ 2022-02-01 9:08 ` Tvrtko Ursulin
0 siblings, 0 replies; 4+ messages in thread
From: Tvrtko Ursulin @ 2022-02-01 9:08 UTC (permalink / raw)
To: Stephen Rothwell, Daniel Vetter, Jani Nikula, Joonas Lahtinen,
Rodrigo Vivi, Intel Graphics, DRI
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Dan Carpenter
On 31/01/2022 22:27, Stephen Rothwell wrote:
> Hi all,
>
> After merging the drm-intel-fixes tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/gpu/drm/i915/i915_vma.c: In function 'i915_vma_bind':
> drivers/gpu/drm/i915/i915_vma.c:451:25: error: 'ret' undeclared (first use in this function); did you mean 'net'?
> 451 | ret = i915_gem_object_wait_moving_fence(vma->obj, true);
> | ^~~
> | net
>
> Caused by commit
>
> 2e872d87cbf2 ("drm/i915: delete shadow "ret" variable")
>
> I have reverted that commit for today.
Dropping was the right call - I have since removed it from
drm-intel-fixes as well.
Root cause was a bad Fixes: tag in that patch which caused it to be
wrongly cherry-picked and I did not build test before pushing.
We can't edit the wrong Fixes: tag now, so for future reference only,
2e872d87cbf2 ("drm/i915: delete shadow "ret" variable") should not be
backported to 5.17 by anyone.
Wrong tag:
Fixes: f6c466b84cfa ("drm/i915: Add support for moving fence waiting")
Correct tag should have been:
Fixes: 2f6b90da9192 ("drm/i915: Use vma resources for async unbinding")
Regards,
Tvrtko
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-02-01 9:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-10 7:03 linux-next: build failure after merge of the drm-intel-fixes tree Mark Brown
2017-10-11 8:51 ` Mark Brown
2017-10-11 17:39 ` [Intel-gfx] " Rodrigo Vivi
-- strict thread matches above, loose matches on Subject: below --
2022-01-31 22:27 Stephen Rothwell
2022-02-01 9:08 ` [Intel-gfx] " Tvrtko Ursulin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox