* [PATCH] Build: Scripts/Makefile: Remove Repeated Lines @ 2018-02-14 9:25 Progyan Bhattacharya 2018-02-14 11:49 ` Stephen Rothwell 0 siblings, 1 reply; 6+ messages in thread From: Progyan Bhattacharya @ 2018-02-14 9:25 UTC (permalink / raw) To: linux-kernel, linux-next Cc: narmstrong, akpm, Arnd Bergmann, Daniel Golle, Joe Perches, Stephen Rothwell Last two lines of code was repreated and was causing build error. Signed-off-by: Progyan Bhattacharya <progyanb@acm•org> Cc: Arnd Bergmann <arnd@arndb•de> Cc: Daniel Golle <daniel@makrotopia•org> Cc: Joe Perches <joe@perches•com> Cc: Neil Armstrong <narmstrong@baylibre•com> Cc: Andrew Morton <akpm@linux-foundation•org> Cc: Stephen Rothwell <sfr@canb•auug.org.au> --- scripts/Makefile.kasan | 4 ---- 1 file changed, 4 deletions(-) diff --git a/scripts/Makefile.kasan b/scripts/Makefile.kasan index b7b9ecef44cc..69552a39951d 100644 --- a/scripts/Makefile.kasan +++ b/scripts/Makefile.kasan @@ -45,7 +45,3 @@ endif CFLAGS_KASAN_NOSANITIZE := -fno-builtin endif - -CFLAGS_KASAN_NOSANITIZE := -fno-builtin - -endif -- 2.16.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Build: Scripts/Makefile: Remove Repeated Lines 2018-02-14 9:25 [PATCH] Build: Scripts/Makefile: Remove Repeated Lines Progyan Bhattacharya @ 2018-02-14 11:49 ` Stephen Rothwell [not found] ` <CAGyWO1-9scERtpPw5CCwQcUbCU0SpcqpNq2eiBWRtwpRC-kB-A@mail.gmail.com> 0 siblings, 1 reply; 6+ messages in thread From: Stephen Rothwell @ 2018-02-14 11:49 UTC (permalink / raw) To: Progyan Bhattacharya Cc: linux-kernel, linux-next, narmstrong, akpm, Arnd Bergmann, Daniel Golle, Joe Perches Hi Progyan, On Wed, 14 Feb 2018 14:55:58 +0530 Progyan Bhattacharya <bprogyan@gmail•com> wrote: > > Last two lines of code was repreated and was causing build error. > > Signed-off-by: Progyan Bhattacharya <progyanb@acm•org> > Cc: Arnd Bergmann <arnd@arndb•de> > Cc: Daniel Golle <daniel@makrotopia•org> > Cc: Joe Perches <joe@perches•com> > Cc: Neil Armstrong <narmstrong@baylibre•com> > Cc: Andrew Morton <akpm@linux-foundation•org> > Cc: Stephen Rothwell <sfr@canb•auug.org.au> > --- > scripts/Makefile.kasan | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/scripts/Makefile.kasan b/scripts/Makefile.kasan > index b7b9ecef44cc..69552a39951d 100644 > --- a/scripts/Makefile.kasan > +++ b/scripts/Makefile.kasan > @@ -45,7 +45,3 @@ endif > CFLAGS_KASAN_NOSANITIZE := -fno-builtin > > endif > - > -CFLAGS_KASAN_NOSANITIZE := -fno-builtin > - > -endif > -- > 2.16.1 > This file in linux-next and Linus' tree does not have the repeated lines. What tree did you see this in? -- Cheers, Stephen Rothwell ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <CAGyWO1-9scERtpPw5CCwQcUbCU0SpcqpNq2eiBWRtwpRC-kB-A@mail.gmail.com>]
* Re: [PATCH] Build: Scripts/Makefile: Remove Repeated Lines [not found] ` <CAGyWO1-9scERtpPw5CCwQcUbCU0SpcqpNq2eiBWRtwpRC-kB-A@mail.gmail.com> @ 2018-02-15 5:05 ` Stephen Rothwell 2018-02-15 5:24 ` Randy Dunlap [not found] ` <CAGyWO1-356ncU=122yrqCoL96pCVfaqJwdFvkmqfot3fzVF6pg@mail.gmail.com> 1 sibling, 1 reply; 6+ messages in thread From: Stephen Rothwell @ 2018-02-15 5:05 UTC (permalink / raw) To: Progyan Bhattacharya Cc: linux-kernel, linux-next, narmstrong, akpm, Arnd Bergmann, Daniel Golle, Joe Perches Hi Progyan, On Thu, 15 Feb 2018 09:50:03 +0530 Progyan Bhattacharya <bprogyan@gmail•com> wrote: > > The last commit I have in here: > > 8396647363e1 (origin/next, next) Add linux-next specific files for 20180206 I don't know where you got that from, as my copy of that commit has SHA1 417c85c22818aefd973fa957b62fb1fe081404dd (as does the copy on git.kernel.org). So you do not have a clean copy of the linux-next tree. > It was not building properly because of repeated lines in > scripts/Makefile.kasan That file is also correct in my next-20180206. > PS: I have another question, Is use of range expression within case > statements allowed in Kernel? If not, are we using If-Else ladder for that? I am not sure if we have a policy on ranges in case labels, but it is not standard C (well, C11 at least). If-else ladders are certainly common. -- Cheers, Stephen Rothwell ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Build: Scripts/Makefile: Remove Repeated Lines 2018-02-15 5:05 ` Stephen Rothwell @ 2018-02-15 5:24 ` Randy Dunlap [not found] ` <CAGyWO1_tmrSB8WwyARGWXhYCz=SL-xqqU4d3Y0A1vqGWQ_8Trg@mail.gmail.com> 0 siblings, 1 reply; 6+ messages in thread From: Randy Dunlap @ 2018-02-15 5:24 UTC (permalink / raw) To: Stephen Rothwell, Progyan Bhattacharya Cc: linux-kernel, linux-next, narmstrong, akpm, Arnd Bergmann, Daniel Golle, Joe Perches On 02/14/2018 09:05 PM, Stephen Rothwell wrote: > Hi Progyan, > > On Thu, 15 Feb 2018 09:50:03 +0530 Progyan Bhattacharya <bprogyan@gmail•com> wrote: >> > >> PS: I have another question, Is use of range expression within case >> statements allowed in Kernel? If not, are we using If-Else ladder for that? > > I am not sure if we have a policy on ranges in case labels, but it is > not standard C (well, C11 at least). If-else ladders are certainly > common. I found 964 case ranges in 4.16-rc1. or you use something like: switch (val) { case 5: case 10: case 15: // handle multiples of 5: break; default: } -- ~Randy ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <CAGyWO1_tmrSB8WwyARGWXhYCz=SL-xqqU4d3Y0A1vqGWQ_8Trg@mail.gmail.com>]
* Re: [PATCH] Build: Scripts/Makefile: Remove Repeated Lines [not found] ` <CAGyWO1_tmrSB8WwyARGWXhYCz=SL-xqqU4d3Y0A1vqGWQ_8Trg@mail.gmail.com> @ 2018-02-15 17:52 ` Randy Dunlap 0 siblings, 0 replies; 6+ messages in thread From: Randy Dunlap @ 2018-02-15 17:52 UTC (permalink / raw) To: Progyan Bhattacharya Cc: Stephen Rothwell, linux-kernel, linux-next, narmstrong, akpm, Arnd Bergmann, Daniel Golle, Joe Perches On 02/15/2018 01:38 AM, Progyan Bhattacharya wrote: > I think some merge error happened in my local workspace. > > Yes the file is correct in Linus's tree as well as current HEAD of linux-next. > Thanks. > I will update my tree accordingly. > > About the nonstandard range statements in case, should I rewrite them. I think If-Else will be easier to read and understand. I don't see a need for any such change. -- ~Randy ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <CAGyWO1-356ncU=122yrqCoL96pCVfaqJwdFvkmqfot3fzVF6pg@mail.gmail.com>]
* Re: [PATCH] Build: Scripts/Makefile: Remove Repeated Lines [not found] ` <CAGyWO1-356ncU=122yrqCoL96pCVfaqJwdFvkmqfot3fzVF6pg@mail.gmail.com> @ 2018-02-15 5:09 ` Stephen Rothwell 0 siblings, 0 replies; 6+ messages in thread From: Stephen Rothwell @ 2018-02-15 5:09 UTC (permalink / raw) To: Progyan Bhattacharya Cc: linux-kernel, linux-next, narmstrong, akpm, Arnd Bergmann, Daniel Golle, Joe Perches Hi Progyan, On Thu, 15 Feb 2018 10:04:18 +0530 Progyan Bhattacharya <bprogyan@gmail•com> wrote: > > I did some ground work and found this particular commit that causing the > error. > > Commit Hash: d96977a8c2266792397ed9814bb84b5129a278ad That hash does not appear in linux-next (or Linus' tree). > Commit Body: > > kasan: rework Kconfig settings > > We get a lot of very large stack frames using gcc-7.0.1 with the default > -fsanitize-address-use-after-scope --param asan-stack=1 options, which can > easily cause an overflow of the kernel stack, e.g.... > > Author(s): > > Signed-off-by: Arnd Bergmann <arnd@arndb•de> > Acked-by: Andrey Ryabinin <aryabinin@virtuozzo•com> > Cc: Mauro Carvalho Chehab <mchehab@kernel•org> > Cc: Andrey Ryabinin <aryabinin@virtuozzo•com> > Cc: Alexander Potapenko <glider@google•com> > Cc: Dmitry Vyukov <dvyukov@google•com> > Cc: Andrey Konovalov <andreyknvl@google•com> > Cc: <stable@vger•kernel.org> > Signed-off-by: Andrew Morton <akpm@linux-foundation•org> > Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au> That patch is in Linus' tree now (was in linux-next) but has SHA1 e7c52b84fb18 -- Cheers, Stephen Rothwell ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-02-15 17:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-14 9:25 [PATCH] Build: Scripts/Makefile: Remove Repeated Lines Progyan Bhattacharya
2018-02-14 11:49 ` Stephen Rothwell
[not found] ` <CAGyWO1-9scERtpPw5CCwQcUbCU0SpcqpNq2eiBWRtwpRC-kB-A@mail.gmail.com>
2018-02-15 5:05 ` Stephen Rothwell
2018-02-15 5:24 ` Randy Dunlap
[not found] ` <CAGyWO1_tmrSB8WwyARGWXhYCz=SL-xqqU4d3Y0A1vqGWQ_8Trg@mail.gmail.com>
2018-02-15 17:52 ` Randy Dunlap
[not found] ` <CAGyWO1-356ncU=122yrqCoL96pCVfaqJwdFvkmqfot3fzVF6pg@mail.gmail.com>
2018-02-15 5:09 ` Stephen Rothwell
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox