From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Alasdair G Kergon <agk@redhat•com>,
Mike Snitzer <snitzer@redhat•com>, Jens Axboe <axboe@kernel•dk>
Cc: Linux-Next Mailing List <linux-next@vger•kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Bart Van Assche <bart.vanassche@wdc•com>,
Denis Semakin <d.semakin@omprussia•ru>
Subject: linux-next: build failure after merge of the device-mapper tree
Date: Tue, 27 Mar 2018 13:39:23 +1100 [thread overview]
Message-ID: <20180327133923.53b8954d@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 1678 bytes --]
Hi all,
After merging the device-mapper tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:
/home/sfr/next/next/drivers/md/dm-table.c: In function 'dm_table_set_restrictions':
/home/sfr/next/next/drivers/md/dm-table.c:1899:3: error: implicit declaration of function 'queue_flag_set_unlocked'; did you mean 'lookup_one_len_unlocked'? [-Werror=implicit-function-declaration]
queue_flag_set_unlocked(QUEUE_FLAG_SECERASE, q);
^~~~~~~~~~~~~~~~~~~~~~~
Caused by commit
9723d9db1a84 ("dm: add support for secure erase forwarding")
interacting with commit
8a0ac14b8da9 ("block: Move the queue_flag_*() functions from a public into a private header file")
from the block tree.
I have added the following merge fix patch:
From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Tue, 27 Mar 2018 13:36:49 +1100
Subject: [PATCH] dm: merge fix for queue_flag_set_unlocked to
blk_queue_flag_set API change
Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
---
drivers/md/dm-table.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c
index d5db9df7ea4b..0589a4da12bb 100644
--- a/drivers/md/dm-table.c
+++ b/drivers/md/dm-table.c
@@ -1896,7 +1896,7 @@ void dm_table_set_restrictions(struct dm_table *t, struct request_queue *q,
blk_queue_flag_set(QUEUE_FLAG_DISCARD, q);
if (dm_table_supports_secure_erase(t))
- queue_flag_set_unlocked(QUEUE_FLAG_SECERASE, q);
+ blk_queue_flag_set(QUEUE_FLAG_SECERASE, q);
if (dm_table_supports_flush(t, (1UL << QUEUE_FLAG_WC))) {
wc = true;
--
2.16.1
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2018-03-27 2:39 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-27 2:39 Stephen Rothwell [this message]
2018-03-27 15:39 ` linux-next: build failure after merge of the device-mapper tree Bart Van Assche
-- strict thread matches above, loose matches on Subject: below --
2025-08-15 3:05 Stephen Rothwell
2025-08-15 8:05 ` Bagas Sanjaya
2025-08-15 15:21 ` Mikulas Patocka
2025-04-10 2:20 Stephen Rothwell
2024-02-07 3:40 Stephen Rothwell
2024-02-07 3:54 ` Matthew Sakai
2024-02-07 15:47 ` Mike Snitzer
2023-09-15 0:06 Stephen Rothwell
2023-06-23 4:30 Stephen Rothwell
2023-06-23 16:47 ` Demi Marie Obenour
2021-02-11 3:36 Stephen Rothwell
2021-02-11 14:37 ` Mike Snitzer
2020-04-22 2:54 Stephen Rothwell
2018-12-06 6:21 Stephen Rothwell
2018-12-06 13:41 ` Mike Snitzer
2018-12-06 20:23 ` Stephen Rothwell
2018-05-31 4:23 Stephen Rothwell
2018-05-31 4:35 ` Jens Axboe
2018-05-31 4:38 ` Stephen Rothwell
2018-05-31 12:10 ` Mike Snitzer
2018-05-31 14:20 ` Jens Axboe
2018-05-31 14:22 ` Jens Axboe
2018-05-31 15:02 ` Jens Axboe
2018-05-31 21:42 ` Stephen Rothwell
2017-06-19 2:27 Stephen Rothwell
2017-06-09 3:12 Stephen Rothwell
2017-06-09 4:28 ` Damien Le Moal
2017-06-09 11:59 ` Mike Snitzer
2016-03-04 2:59 Stephen Rothwell
2016-03-04 3:14 ` Mike Snitzer
2015-11-01 10:43 Stephen Rothwell
2015-11-01 13:44 ` Mike Snitzer
2015-07-05 23:27 Stephen Rothwell
2015-05-22 3:27 Stephen Rothwell
2015-05-22 12:49 ` Mike Snitzer
2015-05-22 13:26 ` Mike Snitzer
2015-05-22 14:58 ` Jens Axboe
2014-01-15 3:52 Stephen Rothwell
2014-01-15 4:30 ` Mike Snitzer
2013-11-05 2:51 Stephen Rothwell
2013-11-05 3:20 ` Mike Snitzer
2013-11-05 3:32 ` Stephen Rothwell
2013-11-05 12:54 ` Mike Snitzer
2013-11-05 16:22 ` Jens Axboe
2013-11-05 22:42 ` Stephen Rothwell
2013-11-05 22:44 ` Jens Axboe
2010-08-02 1:31 Stephen Rothwell
2010-08-02 6:44 ` Milan Broz
2010-08-02 11:34 ` Alasdair G Kergon
2010-06-30 2:57 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180327133923.53b8954d@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=agk@redhat$(echo .)com \
--cc=axboe@kernel$(echo .)dk \
--cc=bart.vanassche@wdc$(echo .)com \
--cc=d.semakin@omprussia$(echo .)ru \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=snitzer@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox