From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Alasdair G Kergon <agk@redhat•com>, Mike Snitzer <snitzer@redhat•com>
Cc: Linux Next Mailing List <linux-next@vger•kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Mikulas Patocka <mpatocka@redhat•com>
Subject: linux-next: build failure after merge of the device-mapper tree
Date: Thu, 6 Dec 2018 17:21:28 +1100 [thread overview]
Message-ID: <20181206172128.71293ced@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 14170 bytes --]
Hi all,
After merging the device-mapper tree, today's linux-next build (powerpc
ppc44x_defconfig) failed like this:
In file included from arch/powerpc/include/asm/local.h:144,
from include/linux/genhd.h:20,
from block/genhd.c:7:
block/genhd.c: In function 'part_inc_in_flight':
include/linux/percpu-defs.h:219:52: error: invalid operands to binary + (have 'struct disk_stats' and 'int')
const void __percpu *__vpp_verify = (typeof((ptr) + 0))NULL; \
~~~~~ ^
include/asm-generic/local.h:31:40: note: in definition of macro 'local_inc'
#define local_inc(l) atomic_long_inc(&(l)->a)
^
include/linux/percpu-defs.h:259:2: note: in expansion of macro '__verify_pcpu_ptr'
__verify_pcpu_ptr(__p); \
^~~~~~~~~~~~~~~~~
include/linux/percpu-defs.h:263:47: note: in expansion of macro 'VERIFY_PERCPU_PTR'
#define per_cpu_ptr(ptr, cpu) ({ (void)(cpu); VERIFY_PERCPU_PTR(ptr); })
^~~~~~~~~~~~~~~~~
block/genhd.c:56:13: note: in expansion of macro 'per_cpu_ptr'
local_inc(&per_cpu_ptr(part->dkstats, cpu)->in_flight[rw]);
^~~~~~~~~~~
include/linux/percpu-defs.h:260:10: error: invalid type argument of unary '*' (have 'struct disk_stats')
(typeof(*(__p)) __kernel __force *)(__p); \
^~~~~~
include/asm-generic/local.h:31:40: note: in definition of macro 'local_inc'
#define local_inc(l) atomic_long_inc(&(l)->a)
^
include/linux/percpu-defs.h:263:47: note: in expansion of macro 'VERIFY_PERCPU_PTR'
#define per_cpu_ptr(ptr, cpu) ({ (void)(cpu); VERIFY_PERCPU_PTR(ptr); })
^~~~~~~~~~~~~~~~~
block/genhd.c:56:13: note: in expansion of macro 'per_cpu_ptr'
local_inc(&per_cpu_ptr(part->dkstats, cpu)->in_flight[rw]);
^~~~~~~~~~~
include/linux/percpu-defs.h:219:52: error: invalid operands to binary + (have 'struct disk_stats' and 'int')
const void __percpu *__vpp_verify = (typeof((ptr) + 0))NULL; \
~~~~~ ^
include/asm-generic/local.h:31:40: note: in definition of macro 'local_inc'
#define local_inc(l) atomic_long_inc(&(l)->a)
^
include/linux/percpu-defs.h:259:2: note: in expansion of macro '__verify_pcpu_ptr'
__verify_pcpu_ptr(__p); \
^~~~~~~~~~~~~~~~~
include/linux/percpu-defs.h:263:47: note: in expansion of macro 'VERIFY_PERCPU_PTR'
#define per_cpu_ptr(ptr, cpu) ({ (void)(cpu); VERIFY_PERCPU_PTR(ptr); })
^~~~~~~~~~~~~~~~~
block/genhd.c:58:14: note: in expansion of macro 'per_cpu_ptr'
local_inc(&per_cpu_ptr(part_to_disk(part)->part0.dkstats, cpu)->in_flight[rw]);
^~~~~~~~~~~
include/linux/percpu-defs.h:260:10: error: invalid type argument of unary '*' (have 'struct disk_stats')
(typeof(*(__p)) __kernel __force *)(__p); \
^~~~~~
include/asm-generic/local.h:31:40: note: in definition of macro 'local_inc'
#define local_inc(l) atomic_long_inc(&(l)->a)
^
include/linux/percpu-defs.h:263:47: note: in expansion of macro 'VERIFY_PERCPU_PTR'
#define per_cpu_ptr(ptr, cpu) ({ (void)(cpu); VERIFY_PERCPU_PTR(ptr); })
^~~~~~~~~~~~~~~~~
block/genhd.c:58:14: note: in expansion of macro 'per_cpu_ptr'
local_inc(&per_cpu_ptr(part_to_disk(part)->part0.dkstats, cpu)->in_flight[rw]);
^~~~~~~~~~~
block/genhd.c: In function 'part_dec_in_flight':
include/linux/percpu-defs.h:219:52: error: invalid operands to binary + (have 'struct disk_stats' and 'int')
const void __percpu *__vpp_verify = (typeof((ptr) + 0))NULL; \
~~~~~ ^
include/asm-generic/local.h:32:40: note: in definition of macro 'local_dec'
#define local_dec(l) atomic_long_dec(&(l)->a)
^
include/linux/percpu-defs.h:259:2: note: in expansion of macro '__verify_pcpu_ptr'
__verify_pcpu_ptr(__p); \
^~~~~~~~~~~~~~~~~
include/linux/percpu-defs.h:263:47: note: in expansion of macro 'VERIFY_PERCPU_PTR'
#define per_cpu_ptr(ptr, cpu) ({ (void)(cpu); VERIFY_PERCPU_PTR(ptr); })
^~~~~~~~~~~~~~~~~
block/genhd.c:69:13: note: in expansion of macro 'per_cpu_ptr'
local_dec(&per_cpu_ptr(part->dkstats, cpu)->in_flight[rw]);
^~~~~~~~~~~
include/linux/percpu-defs.h:260:10: error: invalid type argument of unary '*' (have 'struct disk_stats')
(typeof(*(__p)) __kernel __force *)(__p); \
^~~~~~
include/asm-generic/local.h:32:40: note: in definition of macro 'local_dec'
#define local_dec(l) atomic_long_dec(&(l)->a)
^
include/linux/percpu-defs.h:263:47: note: in expansion of macro 'VERIFY_PERCPU_PTR'
#define per_cpu_ptr(ptr, cpu) ({ (void)(cpu); VERIFY_PERCPU_PTR(ptr); })
^~~~~~~~~~~~~~~~~
block/genhd.c:69:13: note: in expansion of macro 'per_cpu_ptr'
local_dec(&per_cpu_ptr(part->dkstats, cpu)->in_flight[rw]);
^~~~~~~~~~~
include/linux/percpu-defs.h:219:52: error: invalid operands to binary + (have 'struct disk_stats' and 'int')
const void __percpu *__vpp_verify = (typeof((ptr) + 0))NULL; \
~~~~~ ^
include/asm-generic/local.h:32:40: note: in definition of macro 'local_dec'
#define local_dec(l) atomic_long_dec(&(l)->a)
^
include/linux/percpu-defs.h:259:2: note: in expansion of macro '__verify_pcpu_ptr'
__verify_pcpu_ptr(__p); \
^~~~~~~~~~~~~~~~~
include/linux/percpu-defs.h:263:47: note: in expansion of macro 'VERIFY_PERCPU_PTR'
#define per_cpu_ptr(ptr, cpu) ({ (void)(cpu); VERIFY_PERCPU_PTR(ptr); })
^~~~~~~~~~~~~~~~~
block/genhd.c:71:14: note: in expansion of macro 'per_cpu_ptr'
local_dec(&per_cpu_ptr(part_to_disk(part)->part0.dkstats, cpu)->in_flight[rw]);
^~~~~~~~~~~
include/linux/percpu-defs.h:260:10: error: invalid type argument of unary '*' (have 'struct disk_stats')
(typeof(*(__p)) __kernel __force *)(__p); \
^~~~~~
include/asm-generic/local.h:32:40: note: in definition of macro 'local_dec'
#define local_dec(l) atomic_long_dec(&(l)->a)
^
include/linux/percpu-defs.h:263:47: note: in expansion of macro 'VERIFY_PERCPU_PTR'
#define per_cpu_ptr(ptr, cpu) ({ (void)(cpu); VERIFY_PERCPU_PTR(ptr); })
^~~~~~~~~~~~~~~~~
block/genhd.c:71:14: note: in expansion of macro 'per_cpu_ptr'
local_dec(&per_cpu_ptr(part_to_disk(part)->part0.dkstats, cpu)->in_flight[rw]);
^~~~~~~~~~~
block/genhd.c: In function 'part_in_flight':
include/linux/percpu-defs.h:219:52: error: invalid operands to binary + (have 'struct disk_stats' and 'int')
const void __percpu *__vpp_verify = (typeof((ptr) + 0))NULL; \
~~~~~ ^
include/asm-generic/local.h:29:42: note: in definition of macro 'local_read'
#define local_read(l) atomic_long_read(&(l)->a)
^
include/linux/percpu-defs.h:259:2: note: in expansion of macro '__verify_pcpu_ptr'
__verify_pcpu_ptr(__p); \
^~~~~~~~~~~~~~~~~
include/linux/percpu-defs.h:263:47: note: in expansion of macro 'VERIFY_PERCPU_PTR'
#define per_cpu_ptr(ptr, cpu) ({ (void)(cpu); VERIFY_PERCPU_PTR(ptr); })
^~~~~~~~~~~~~~~~~
block/genhd.c:85:27: note: in expansion of macro 'per_cpu_ptr'
inflight += local_read(&per_cpu_ptr(part->dkstats, cpu)->in_flight[0]) +
^~~~~~~~~~~
include/linux/percpu-defs.h:260:10: error: invalid type argument of unary '*' (have 'struct disk_stats')
(typeof(*(__p)) __kernel __force *)(__p); \
^~~~~~
include/asm-generic/local.h:29:42: note: in definition of macro 'local_read'
#define local_read(l) atomic_long_read(&(l)->a)
^
include/linux/percpu-defs.h:263:47: note: in expansion of macro 'VERIFY_PERCPU_PTR'
#define per_cpu_ptr(ptr, cpu) ({ (void)(cpu); VERIFY_PERCPU_PTR(ptr); })
^~~~~~~~~~~~~~~~~
block/genhd.c:85:27: note: in expansion of macro 'per_cpu_ptr'
inflight += local_read(&per_cpu_ptr(part->dkstats, cpu)->in_flight[0]) +
^~~~~~~~~~~
include/linux/percpu-defs.h:219:52: error: invalid operands to binary + (have 'struct disk_stats' and 'int')
const void __percpu *__vpp_verify = (typeof((ptr) + 0))NULL; \
~~~~~ ^
include/asm-generic/local.h:29:42: note: in definition of macro 'local_read'
#define local_read(l) atomic_long_read(&(l)->a)
^
include/linux/percpu-defs.h:259:2: note: in expansion of macro '__verify_pcpu_ptr'
__verify_pcpu_ptr(__p); \
^~~~~~~~~~~~~~~~~
include/linux/percpu-defs.h:263:47: note: in expansion of macro 'VERIFY_PERCPU_PTR'
#define per_cpu_ptr(ptr, cpu) ({ (void)(cpu); VERIFY_PERCPU_PTR(ptr); })
^~~~~~~~~~~~~~~~~
block/genhd.c:86:17: note: in expansion of macro 'per_cpu_ptr'
local_read(&per_cpu_ptr(part->dkstats, cpu)->in_flight[1]);
^~~~~~~~~~~
include/linux/percpu-defs.h:260:10: error: invalid type argument of unary '*' (have 'struct disk_stats')
(typeof(*(__p)) __kernel __force *)(__p); \
^~~~~~
include/asm-generic/local.h:29:42: note: in definition of macro 'local_read'
#define local_read(l) atomic_long_read(&(l)->a)
^
include/linux/percpu-defs.h:263:47: note: in expansion of macro 'VERIFY_PERCPU_PTR'
#define per_cpu_ptr(ptr, cpu) ({ (void)(cpu); VERIFY_PERCPU_PTR(ptr); })
^~~~~~~~~~~~~~~~~
block/genhd.c:86:17: note: in expansion of macro 'per_cpu_ptr'
local_read(&per_cpu_ptr(part->dkstats, cpu)->in_flight[1]);
^~~~~~~~~~~
block/genhd.c: In function 'part_in_flight_rw':
include/linux/percpu-defs.h:219:52: error: invalid operands to binary + (have 'struct disk_stats' and 'int')
const void __percpu *__vpp_verify = (typeof((ptr) + 0))NULL; \
~~~~~ ^
include/asm-generic/local.h:29:42: note: in definition of macro 'local_read'
#define local_read(l) atomic_long_read(&(l)->a)
^
include/linux/percpu-defs.h:259:2: note: in expansion of macro '__verify_pcpu_ptr'
__verify_pcpu_ptr(__p); \
^~~~~~~~~~~~~~~~~
include/linux/percpu-defs.h:263:47: note: in expansion of macro 'VERIFY_PERCPU_PTR'
#define per_cpu_ptr(ptr, cpu) ({ (void)(cpu); VERIFY_PERCPU_PTR(ptr); })
^~~~~~~~~~~~~~~~~
block/genhd.c:107:30: note: in expansion of macro 'per_cpu_ptr'
inflight[0] += local_read(&per_cpu_ptr(part->dkstats, cpu)->in_flight[0]);
^~~~~~~~~~~
include/linux/percpu-defs.h:260:10: error: invalid type argument of unary '*' (have 'struct disk_stats')
(typeof(*(__p)) __kernel __force *)(__p); \
^~~~~~
include/asm-generic/local.h:29:42: note: in definition of macro 'local_read'
#define local_read(l) atomic_long_read(&(l)->a)
^
include/linux/percpu-defs.h:263:47: note: in expansion of macro 'VERIFY_PERCPU_PTR'
#define per_cpu_ptr(ptr, cpu) ({ (void)(cpu); VERIFY_PERCPU_PTR(ptr); })
^~~~~~~~~~~~~~~~~
block/genhd.c:107:30: note: in expansion of macro 'per_cpu_ptr'
inflight[0] += local_read(&per_cpu_ptr(part->dkstats, cpu)->in_flight[0]);
^~~~~~~~~~~
include/linux/percpu-defs.h:219:52: error: invalid operands to binary + (have 'struct disk_stats' and 'int')
const void __percpu *__vpp_verify = (typeof((ptr) + 0))NULL; \
~~~~~ ^
include/asm-generic/local.h:29:42: note: in definition of macro 'local_read'
#define local_read(l) atomic_long_read(&(l)->a)
^
include/linux/percpu-defs.h:259:2: note: in expansion of macro '__verify_pcpu_ptr'
__verify_pcpu_ptr(__p); \
^~~~~~~~~~~~~~~~~
include/linux/percpu-defs.h:263:47: note: in expansion of macro 'VERIFY_PERCPU_PTR'
#define per_cpu_ptr(ptr, cpu) ({ (void)(cpu); VERIFY_PERCPU_PTR(ptr); })
^~~~~~~~~~~~~~~~~
block/genhd.c:108:30: note: in expansion of macro 'per_cpu_ptr'
inflight[1] += local_read(&per_cpu_ptr(part->dkstats, cpu)->in_flight[1]);
^~~~~~~~~~~
include/linux/percpu-defs.h:260:10: error: invalid type argument of unary '*' (have 'struct disk_stats')
(typeof(*(__p)) __kernel __force *)(__p); \
^~~~~~
include/asm-generic/local.h:29:42: note: in definition of macro 'local_read'
#define local_read(l) atomic_long_read(&(l)->a)
^
include/linux/percpu-defs.h:263:47: note: in expansion of macro 'VERIFY_PERCPU_PTR'
#define per_cpu_ptr(ptr, cpu) ({ (void)(cpu); VERIFY_PERCPU_PTR(ptr); })
^~~~~~~~~~~~~~~~~
block/genhd.c:108:30: note: in expansion of macro 'per_cpu_ptr'
inflight[1] += local_read(&per_cpu_ptr(part->dkstats, cpu)->in_flight[1]);
^~~~~~~~~~~
Caused by commit
3a657cf59109 ("block: switch to per-cpu in-flight counters")
This build does not have CONFIG_SMP set and part->dkstats is not a
pointer in this case.
I have reverted the device-mapper tree changes for today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2018-12-06 6:21 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 6:21 Stephen Rothwell [this message]
2018-12-06 13:41 ` linux-next: build failure after merge of the device-mapper tree Mike Snitzer
2018-12-06 20:23 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2025-08-15 3:05 Stephen Rothwell
2025-08-15 8:05 ` Bagas Sanjaya
2025-08-15 15:21 ` Mikulas Patocka
2025-04-10 2:20 Stephen Rothwell
2024-02-07 3:40 Stephen Rothwell
2024-02-07 3:54 ` Matthew Sakai
2024-02-07 15:47 ` Mike Snitzer
2023-09-15 0:06 Stephen Rothwell
2023-06-23 4:30 Stephen Rothwell
2023-06-23 16:47 ` Demi Marie Obenour
2021-02-11 3:36 Stephen Rothwell
2021-02-11 14:37 ` Mike Snitzer
2020-04-22 2:54 Stephen Rothwell
2018-05-31 4:23 Stephen Rothwell
2018-05-31 4:35 ` Jens Axboe
2018-05-31 4:38 ` Stephen Rothwell
2018-05-31 12:10 ` Mike Snitzer
2018-05-31 14:20 ` Jens Axboe
2018-05-31 14:22 ` Jens Axboe
2018-05-31 15:02 ` Jens Axboe
2018-05-31 21:42 ` Stephen Rothwell
2018-03-27 2:39 Stephen Rothwell
2018-03-27 15:39 ` Bart Van Assche
2017-06-19 2:27 Stephen Rothwell
2017-06-09 3:12 Stephen Rothwell
2017-06-09 4:28 ` Damien Le Moal
2017-06-09 11:59 ` Mike Snitzer
2016-03-04 2:59 Stephen Rothwell
2016-03-04 3:14 ` Mike Snitzer
2015-11-01 10:43 Stephen Rothwell
2015-11-01 13:44 ` Mike Snitzer
2015-07-05 23:27 Stephen Rothwell
2015-05-22 3:27 Stephen Rothwell
2015-05-22 12:49 ` Mike Snitzer
2015-05-22 13:26 ` Mike Snitzer
2015-05-22 14:58 ` Jens Axboe
2014-01-15 3:52 Stephen Rothwell
2014-01-15 4:30 ` Mike Snitzer
2013-11-05 2:51 Stephen Rothwell
2013-11-05 3:20 ` Mike Snitzer
2013-11-05 3:32 ` Stephen Rothwell
2013-11-05 12:54 ` Mike Snitzer
2013-11-05 16:22 ` Jens Axboe
2013-11-05 22:42 ` Stephen Rothwell
2013-11-05 22:44 ` Jens Axboe
2010-08-02 1:31 Stephen Rothwell
2010-08-02 6:44 ` Milan Broz
2010-08-02 11:34 ` Alasdair G Kergon
2010-06-30 2:57 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181206172128.71293ced@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=agk@redhat$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mpatocka@redhat$(echo .)com \
--cc=snitzer@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox