From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Miquel Raynal <miquel.raynal@bootlin•com>,
Boris Brezillon <boris.brezillon@collabora•com>
Cc: Linux Next Mailing List <linux-next@vger•kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Paul Cercueil <paul@crapouillou•net>
Subject: linux-next: build warning after merge of the nand tree
Date: Wed, 3 Apr 2019 10:22:39 +1100 [thread overview]
Message-ID: <20190403102239.174fbe35@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 1166 bytes --]
Hi all,
After merging the nand tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/mtd/nand/raw/ingenic/jz4725b_bch.c: In function 'jz4725b_bch_read_parity':
drivers/mtd/nand/raw/ingenic/jz4725b_bch.c:147:12: warning: this statement may fall through [-Wimplicit-fallthrough=]
dest8[2] = (val >> 16) & 0xff;
~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
drivers/mtd/nand/raw/ingenic/jz4725b_bch.c:148:2: note: here
case 2: /* fall-through */
^~~~
drivers/mtd/nand/raw/ingenic/jz4725b_bch.c:149:12: warning: this statement may fall through [-Wimplicit-fallthrough=]
dest8[1] = (val >> 8) & 0xff;
~~~~~~~~~^~~~~~~~~~~~~~~~~~~
drivers/mtd/nand/raw/ingenic/jz4725b_bch.c:150:2: note: here
case 1: /* fall-through */
^~~~
Introduced by commit
acb29396f956 ("mtd: rawnand: ingenic: Add support for the JZ4725B")
I get this warning because I am building with -Wimplicit-fallthrough
in attempt to catch new additions early. The gcc warning can be turned
off by adding a /* fall through */ comment at the point the fall through
happens (i.e. before the next case label).
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2019-04-02 23:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-02 23:22 Stephen Rothwell [this message]
2019-04-03 7:49 ` linux-next: build warning after merge of the nand tree Miquel Raynal
-- strict thread matches above, loose matches on Subject: below --
2023-12-01 1:56 Stephen Rothwell
2023-12-01 5:03 ` David Regan
2023-12-01 11:55 ` Miquel Raynal
2023-01-16 3:32 Stephen Rothwell
2022-02-08 6:00 Stephen Rothwell
2020-11-20 0:39 Stephen Rothwell
2020-11-20 11:23 ` Miquel Raynal
2020-11-20 12:01 ` Boris Brezillon
2020-11-20 12:58 ` Serge Semin
2020-11-20 13:01 ` Serge Semin
2020-11-03 6:37 Stephen Rothwell
2020-11-06 4:31 ` Stephen Rothwell
2020-09-14 1:40 Stephen Rothwell
2020-03-11 2:06 Stephen Rothwell
2018-10-08 0:38 Stephen Rothwell
2018-10-08 7:53 ` Miquel Raynal
2018-10-08 11:06 ` Stephen Rothwell
2018-07-19 2:28 Stephen Rothwell
2018-07-09 1:51 Stephen Rothwell
2018-07-09 6:16 ` Boris Brezillon
2018-07-09 6:51 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190403102239.174fbe35@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=boris.brezillon@collabora$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=miquel.raynal@bootlin$(echo .)com \
--cc=paul@crapouillou$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox