* linux-next: Fixes tags need some work in the hid tree
@ 2019-04-25 13:34 Stephen Rothwell
2019-04-25 14:16 ` Benjamin Tissoires
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Rothwell @ 2019-04-25 13:34 UTC (permalink / raw)
To: Jiri Kosina, Benjamin Tissoires
Cc: Linux Next Mailing List, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 707 bytes --]
Hi all,
In commit
39b3c3a5fbc5 ("HID: input: fix assignment of .value")
Fixes tag
Fixes: 2dc702c991e377 ("HID: input: use the Resolution Multiplier for
has these problem(s):
- Subject has leading but no trailing parentheses
- Subject has leading but no trailing quotes
In commit
d43c17ead879 ("HID: input: make sure the wheel high resolution multiplier is set")
Fixes tag
Fixes: 2dc702c991e377 ("HID: input: use the Resolution Multiplier for
has these problem(s):
- Subject has leading but no trailing parentheses
- Subject has leading but no trailing quotes
Please do not aplit Fixes tags over more than one line.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: linux-next: Fixes tags need some work in the hid tree
2019-04-25 13:34 linux-next: Fixes tags need some work in the hid tree Stephen Rothwell
@ 2019-04-25 14:16 ` Benjamin Tissoires
0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Tissoires @ 2019-04-25 14:16 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Jiri Kosina, Linux Next Mailing List, Linux Kernel Mailing List
Hi Stephen,
On Thu, Apr 25, 2019 at 3:34 PM Stephen Rothwell <sfr@canb•auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
> 39b3c3a5fbc5 ("HID: input: fix assignment of .value")
>
> Fixes tag
>
> Fixes: 2dc702c991e377 ("HID: input: use the Resolution Multiplier for
>
> has these problem(s):
>
> - Subject has leading but no trailing parentheses
> - Subject has leading but no trailing quotes
>
> In commit
>
> d43c17ead879 ("HID: input: make sure the wheel high resolution multiplier is set")
>
> Fixes tag
>
> Fixes: 2dc702c991e377 ("HID: input: use the Resolution Multiplier for
>
> has these problem(s):
>
> - Subject has leading but no trailing parentheses
> - Subject has leading but no trailing quotes
>
> Please do not aplit Fixes tags over more than one line.
>
Sorry for that, these are my commits.
I just re-read the doc, and indeed, we are not supposed to trim or
split the commit title. I'll be more careful next time.
Also, can't we add these requirements in checkpatch?
Cheers,
Benjamin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-25 14:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-25 13:34 linux-next: Fixes tags need some work in the hid tree Stephen Rothwell
2019-04-25 14:16 ` Benjamin Tissoires
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox