From: Guenter Roeck <linux@roeck-us•net>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: Linux Next Mailing List <linux-next@vger•kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Krzysztof Adamski <krzysztof.adamski@nokia•com>,
Alexander Sverdlin <alexander.sverdlin@nokia•com>
Subject: Re: linux-next: build failure after merge of the hwmon-fixes tree
Date: Wed, 5 Jun 2019 15:50:29 -0700 [thread overview]
Message-ID: <20190605225029.GA25183@roeck-us.net> (raw)
In-Reply-To: <20190606083034.196219f0@canb.auug.org.au>
On Thu, Jun 06, 2019 at 08:30:34AM +1000, Stephen Rothwell wrote:
> Hi Guenter,
>
> After merging the hwmon-fixes tree, today's linux-next build
> (x86_64 allmodconfig) failed like this:
>
> In file included from include/linux/notifier.h:14,
> from arch/x86/include/asm/uprobes.h:13,
> from include/linux/uprobes.h:49,
> from include/linux/mm_types.h:14,
> from include/linux/mmzone.h:21,
> from include/linux/gfp.h:6,
> from include/linux/xarray.h:14,
> from include/linux/radix-tree.h:18,
> from include/linux/fs.h:15,
> from include/linux/debugfs.h:15,
> from drivers/hwmon/pmbus/pmbus_core.c:9:
> drivers/hwmon/pmbus/pmbus_core.c: In function 'pmbus_set_samples':
> drivers/hwmon/pmbus/pmbus_core.c:1975:14: error: 'data' undeclared (first use in this function); did you mean '_data'?
> mutex_lock(&data->update_lock);
> ^~~~
> include/linux/mutex.h:166:44: note: in definition of macro 'mutex_lock'
> #define mutex_lock(lock) mutex_lock_nested(lock, 0)
> ^~~~
> drivers/hwmon/pmbus/pmbus_core.c:1975:14: note: each undeclared identifier is reported only once for each function it appears in
> mutex_lock(&data->update_lock);
> ^~~~
> include/linux/mutex.h:166:44: note: in definition of macro 'mutex_lock'
> #define mutex_lock(lock) mutex_lock_nested(lock, 0)
> ^~~~
>
> Caused by commit
>
> 8d719d6f3e97 ("hwmon: (pmbus/core) mutex_lock write in pmbus_set_samples")
>
Fixed. Thanks for the note, and sorry for the trouble.
Guenter
> I have reverted that commit for today.
>
> --
> Cheers,
> Stephen Rothwell
next prev parent reply other threads:[~2019-06-05 22:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 22:30 linux-next: build failure after merge of the hwmon-fixes tree Stephen Rothwell
2019-06-05 22:50 ` Guenter Roeck [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-02-25 21:12 Stephen Rothwell
2020-02-25 21:25 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190605225029.GA25183@roeck-us.net \
--to=linux@roeck-us$(echo .)net \
--cc=alexander.sverdlin@nokia$(echo .)com \
--cc=krzysztof.adamski@nokia$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox