From: Guenter Roeck <linux@roeck-us•net>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: Linux Next Mailing List <linux-next@vger•kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Vadim Pasternak <vadimp@mellanox•com>
Subject: Re: linux-next: build failure after merge of the hwmon-fixes tree
Date: Tue, 25 Feb 2020 13:25:56 -0800 [thread overview]
Message-ID: <20200225212556.GA31742@roeck-us.net> (raw)
In-Reply-To: <20200226081228.3adcf58e@canb.auug.org.au>
On Wed, Feb 26, 2020 at 08:12:28AM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the hwmon-fixes tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/hwmon/pmbus/xdpe12284.c: In function 'xdpe122_read_word_data':
> drivers/hwmon/pmbus/xdpe12284.c:33:9: error: too many arguments to function 'pmbus_read_word_data'
> 33 | ret = pmbus_read_word_data(client, page, phase, reg);
> | ^~~~~~~~~~~~~~~~~~~~
> In file included from drivers/hwmon/pmbus/xdpe12284.c:13:
> drivers/hwmon/pmbus/pmbus.h:458:5: note: declared here
> 458 | int pmbus_read_word_data(struct i2c_client *client, int page, u8 reg);
> | ^~~~~~~~~~~~~~~~~~~~
> drivers/hwmon/pmbus/xdpe12284.c: At top level:
> drivers/hwmon/pmbus/xdpe12284.c:127:20: error: initialization of 'int (*)(struct i2c_client *, int, int)' from incompatible pointer type 'int (*)(struct i2c_client *, int, int, int)' [-Werror=incompatible-pointer-types]
> 127 | .read_word_data = xdpe122_read_word_data,
> | ^~~~~~~~~~~~~~~~~~~~~~
> drivers/hwmon/pmbus/xdpe12284.c:127:20: note: (near initialization for 'xdpe122_info.read_word_data')
>
> Caused by commit
>
> 47555027eae2 ("hwmon: (pmbus/xdpe12284) Add callback for vout limits conversion")
>
> I have reverted that commit for today.
>
Bummer. My fault; sorry for that. Fixed up now.
Thanks,
Guenter
next prev parent reply other threads:[~2020-02-25 21:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 21:12 linux-next: build failure after merge of the hwmon-fixes tree Stephen Rothwell
2020-02-25 21:25 ` Guenter Roeck [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-06-05 22:30 Stephen Rothwell
2019-06-05 22:50 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200225212556.GA31742@roeck-us.net \
--to=linux@roeck-us$(echo .)net \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=vadimp@mellanox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox