* linux-next: run time BUG after merge of the vfs-fixes tree?
@ 2019-07-25 4:47 Stephen Rothwell
2019-07-25 23:31 ` Al Viro
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Rothwell @ 2019-07-25 4:47 UTC (permalink / raw)
To: Al Viro; +Cc: Linux Next Mailing List, Linux Kernel Mailing List,
Nikolay Borisov
[-- Attachment #1: Type: text/plain, Size: 3040 bytes --]
Hi all,
During my qemu boot tests (powerpc64 pseries_le_defconfig) today, I got
the following BUG:
# halt
# Stopping network...Saving random seed... [ 6.515368] random: dd: uninitialized urandom read (512 bytes read)
done.
Stopping logging: OK
[ 6.796972] BUG: Unable to handle kernel data access at 0x5deadbeef0000122
[ 6.797133] Faulting instruction address: 0xc00000000041cba4
[ 6.797616] Oops: Kernel access of bad area, sig: 11 [#1]
[ 6.797725] LE PAGE_SIZE=64K MMU=Hash SMP NR_CPUS=2048 NUMA pSeries
[ 6.797987] Modules linked in:
[ 6.798405] CPU: 0 PID: 111 Comm: umount Not tainted 5.3.0-rc1 #2
[ 6.798554] NIP: c00000000041cba4 LR: c00000000041cb90 CTR: 00000000000001fc
[ 6.798664] REGS: c00000007e1eba70 TRAP: 0380 Not tainted (5.3.0-rc1)
[ 6.798716] MSR: 8000000000009033 <SF,EE,ME,IR,DR,RI,LE> CR: 82242884 XER: 20000000
[ 6.798957] CFAR: c00000000041c434 IRQMASK: 0
[ 6.798957] GPR00: c00000000041cb90 c00000007e1ebd00 c00000000110e100 0000000000000001
[ 6.798957] GPR04: 0000000000000800 0000000000000800 0000000000020000 c00000000113dbf8
[ 6.798957] GPR08: 0000000000000048 c00000007a2e2100 5deadbeef0000122 c000000079417380
[ 6.798957] GPR12: 0000000022242884 c0000000012f0000 0000000000000000 0000000000000000
[ 6.798957] GPR16: 0000000000000000 0000000000000000 0000000000000000 0000000000000000
[ 6.798957] GPR20: 0000000000000000 0000000000000000 0000000000000000 00000000100bce20
[ 6.798957] GPR24: 0000000000000000 c00000007a2e2100 0000000000000000 c00000007a2e2188
[ 6.798957] GPR28: 0000000000000000 5deadbeef0000100 5deadbeef0000122 5deadbeef0000100
[ 6.800143] NIP [c00000000041cba4] namespace_unlock+0x194/0x240
[ 6.800208] LR [c00000000041cb90] namespace_unlock+0x180/0x240
[ 6.800366] Call Trace:
[ 6.800456] [c00000007e1ebd00] [c00000000041cb90] namespace_unlock+0x180/0x240 (unreliable)
[ 6.800603] [c00000007e1ebd60] [c00000000041e634] ksys_umount+0x324/0x6f0
[ 6.800760] [c00000007e1ebe00] [c00000000041ea24] sys_umount+0x24/0x40
[ 6.800824] [c00000007e1ebe20] [c00000000000ba64] system_call+0x5c/0x70
[ 6.800940] Instruction dump:
[ 6.801234] 81490124 fba900f0 fbc900f8 2f8a0000 409e00b0 7d234b78 4bfff80d 353fff10
[ 6.801374] 4182007c ebe900f0 e94900f8 2fbf0000 <fbea0000> 409effc8 3ce05dea 60e7dbee
[ 6.801992] ---[ end trace 34315779952607e2 ]---
[ 6.905920]
The system is going down NOW!
5deadbeef is the ppc64 ILLEGAL_POINTER_VALUE. I am guessing that the
problem may have been introduced by commit
2085eeffbc6d ("fix the struct mount leak in umount_tree()")
in the vfs-fixes tree today.
And actually reverting that commit makes the BUG go away.
After doing the revert (and also before today), I get the following log
messages instead of the BUG trace:
umount: devtmpfs busy - remounted read-only
umount: can't unmount /: Invalid argument
So, I have left that commit reverted for today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: linux-next: run time BUG after merge of the vfs-fixes tree?
2019-07-25 4:47 linux-next: run time BUG after merge of the vfs-fixes tree? Stephen Rothwell
@ 2019-07-25 23:31 ` Al Viro
0 siblings, 0 replies; 2+ messages in thread
From: Al Viro @ 2019-07-25 23:31 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linux Next Mailing List, Linux Kernel Mailing List,
Nikolay Borisov
On Thu, Jul 25, 2019 at 02:47:12PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> During my qemu boot tests (powerpc64 pseries_le_defconfig) today, I got
> the following BUG:
... caused by mismerge. #fixes does
@@ -1471,10 +1470,11 @@ static void umount_tree(struct mount *mnt, enum umount_tree_flags how)
list_add_tail(&p->mnt_child, &p->mnt_parent->mnt_mounts);
} else {
umount_mnt(p);
- hlist_add_head(&p->mnt_umount, &unmounted);
}
}
change_mnt_propagation(p, MS_PRIVATE);
+ if (disconnect)
+ hlist_add_head(&p->mnt_umount, &unmounted);
}
}
and your merge has dropped the removal part - it has
list_add_tail(&p->mnt_child, &p->mnt_parent->mnt_mounts);
} else {
umount_mnt(p);
hlist_add_head(&p->mnt_umount, &unmounted);
}
}
change_mnt_propagation(p, MS_PRIVATE);
if (disconnect)
hlist_add_head(&p->mnt_umount, &unmounted);
}
}
Should've #work.dcache from there once (equal) #work.dcache2 got pulled ;-/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-25 23:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-25 4:47 linux-next: run time BUG after merge of the vfs-fixes tree? Stephen Rothwell
2019-07-25 23:31 ` Al Viro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox