public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: john.hubbard@gmail•com
To: sfr@canb•auug.org.au
Cc: akpm@linux-foundation•org, jhubbard@nvidia•com,
	linux-kernel@vger•kernel.org, linux-next@vger•kernel.org
Subject: [PATCH] mm/gup: remove unused variable in siw_free_plist()
Date: Mon, 29 Jul 2019 00:43:06 -0700	[thread overview]
Message-ID: <20190729074306.10368-1-jhubbard@nvidia.com> (raw)
In-Reply-To: <20190729134816.605ff6d3@canb.auug.org.au>

From: John Hubbard <jhubbard@nvidia•com>

Commit 63630f9a8d72 ("mm/gup: add make_dirty arg to
put_user_pages_dirty_lock()") removed the only user of the
local variable p. Finish the job by removing p as well.

Fixes: 63630f9a8d72 ("mm/gup: add make_dirty arg to put_user_pages_dirty_lock()")
Signed-off-by: John Hubbard <jhubbard@nvidia•com>
---

Hi,

This fixes the warning. Ideally this should be merged with the commit
that it fixes, if that's still possible.

Andrew, would you also like a fixed version of this patch posted
as a new version of the 3-patch set that it came with?

thanks,
John Hubbard
NVIDIA

 drivers/infiniband/sw/siw/siw_mem.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/infiniband/sw/siw/siw_mem.c b/drivers/infiniband/sw/siw/siw_mem.c
index 358d440efa11..ab83a9cec562 100644
--- a/drivers/infiniband/sw/siw/siw_mem.c
+++ b/drivers/infiniband/sw/siw/siw_mem.c
@@ -63,8 +63,6 @@ struct siw_mem *siw_mem_id2obj(struct siw_device *sdev, int stag_index)
 static void siw_free_plist(struct siw_page_chunk *chunk, int num_pages,
 			   bool dirty)
 {
-	struct page **p = chunk->plist;
-
 	put_user_pages_dirty_lock(chunk->plist, num_pages, dirty);
 }
 
-- 
2.22.0


      reply	other threads:[~2019-07-29  7:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-29  3:48 linux-next: build warning after merge of the akpm-current tree Stephen Rothwell
2019-07-29  7:43 ` john.hubbard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190729074306.10368-1-jhubbard@nvidia.com \
    --to=john.hubbard@gmail$(echo .)com \
    --cc=akpm@linux-foundation$(echo .)org \
    --cc=jhubbard@nvidia$(echo .)com \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=sfr@canb$(echo .)auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox