* linux-next: build warning after merge of the akpm-current tree
@ 2019-07-29 3:48 Stephen Rothwell
2019-07-29 7:43 ` [PATCH] mm/gup: remove unused variable in siw_free_plist() john.hubbard
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Rothwell @ 2019-07-29 3:48 UTC (permalink / raw)
To: Andrew Morton
Cc: Linux Next Mailing List, Linux Kernel Mailing List, John Hubbard
[-- Attachment #1: Type: text/plain, Size: 475 bytes --]
Hi all,
After merging the akpm-current tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/infiniband/sw/siw/siw_mem.c: In function 'siw_free_plist':
drivers/infiniband/sw/siw/siw_mem.c:66:16: warning: unused variable 'p' [-Wunused-variable]
struct page **p = chunk->plist;
^
Introduced by commit
63630f9a8d72 ("mm/gup: add make_dirty arg to put_user_pages_dirty_lock()")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread* [PATCH] mm/gup: remove unused variable in siw_free_plist()
2019-07-29 3:48 linux-next: build warning after merge of the akpm-current tree Stephen Rothwell
@ 2019-07-29 7:43 ` john.hubbard
0 siblings, 0 replies; 2+ messages in thread
From: john.hubbard @ 2019-07-29 7:43 UTC (permalink / raw)
To: sfr; +Cc: akpm, jhubbard, linux-kernel, linux-next
From: John Hubbard <jhubbard@nvidia•com>
Commit 63630f9a8d72 ("mm/gup: add make_dirty arg to
put_user_pages_dirty_lock()") removed the only user of the
local variable p. Finish the job by removing p as well.
Fixes: 63630f9a8d72 ("mm/gup: add make_dirty arg to put_user_pages_dirty_lock()")
Signed-off-by: John Hubbard <jhubbard@nvidia•com>
---
Hi,
This fixes the warning. Ideally this should be merged with the commit
that it fixes, if that's still possible.
Andrew, would you also like a fixed version of this patch posted
as a new version of the 3-patch set that it came with?
thanks,
John Hubbard
NVIDIA
drivers/infiniband/sw/siw/siw_mem.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/infiniband/sw/siw/siw_mem.c b/drivers/infiniband/sw/siw/siw_mem.c
index 358d440efa11..ab83a9cec562 100644
--- a/drivers/infiniband/sw/siw/siw_mem.c
+++ b/drivers/infiniband/sw/siw/siw_mem.c
@@ -63,8 +63,6 @@ struct siw_mem *siw_mem_id2obj(struct siw_device *sdev, int stag_index)
static void siw_free_plist(struct siw_page_chunk *chunk, int num_pages,
bool dirty)
{
- struct page **p = chunk->plist;
-
put_user_pages_dirty_lock(chunk->plist, num_pages, dirty);
}
--
2.22.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-29 7:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-29 3:48 linux-next: build warning after merge of the akpm-current tree Stephen Rothwell
2019-07-29 7:43 ` [PATCH] mm/gup: remove unused variable in siw_free_plist() john.hubbard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox