From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Andy Gross <agross@kernel•org>
Cc: Linux Next Mailing List <linux-next@vger•kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Vaishali Thakkar <vaishali.thakkar@linaro•org>,
Bjorn Andersson <bjorn.andersson@linaro•org>,
Vinod Koul <vkoul@kernel•org>,
"Gustavo A. R. Silva" <gustavo@embeddedor•com>,
Kees Cook <keescook@chromium•org>
Subject: linux-next: build warning after merge of the qcom tree
Date: Wed, 7 Aug 2019 10:08:03 +1000 [thread overview]
Message-ID: <20190807100803.63007737@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 3882 bytes --]
Hi all,
After merging the qcom tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/soc/qcom/socinfo.c: In function 'socinfo_debugfs_init':
drivers/soc/qcom/socinfo.c:323:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
debugfs_create_x32("raw_device_number", 0400,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
qcom_socinfo->dbg_root,
~~~~~~~~~~~~~~~~~~~~~~~
&qcom_socinfo->info.raw_device_num);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/soc/qcom/socinfo.c:326:2: note: here
case SOCINFO_VERSION(0, 11):
^~~~
drivers/soc/qcom/socinfo.c:331:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
debugfs_create_u32("foundry_id", 0400, qcom_socinfo->dbg_root,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
&qcom_socinfo->info.foundry_id);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/soc/qcom/socinfo.c:333:2: note: here
case SOCINFO_VERSION(0, 8):
^~~~
drivers/soc/qcom/socinfo.c:231:2: warning: this statement may fall through [-Wimplicit-fallthrough=]
debugfs_create_file(__stringify(name), 0400, \
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
qcom_socinfo->dbg_root, \
~~~~~~~~~~~~~~~~~~~~~~~~~~~
info, &qcom_ ##name## _ops)
~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/soc/qcom/socinfo.c:336:3: note: in expansion of macro 'DEBUGFS_ADD'
DEBUGFS_ADD(info, pmic_die_rev);
^~~~~~~~~~~
drivers/soc/qcom/socinfo.c:337:2: note: here
case SOCINFO_VERSION(0, 6):
^~~~
drivers/soc/qcom/socinfo.c:341:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
debugfs_create_u32("hardware_platform_subtype", 0400,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
qcom_socinfo->dbg_root,
~~~~~~~~~~~~~~~~~~~~~~~
&qcom_socinfo->info.hw_plat_subtype);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/soc/qcom/socinfo.c:344:2: note: here
case SOCINFO_VERSION(0, 5):
^~~~
drivers/soc/qcom/socinfo.c:348:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
debugfs_create_u32("accessory_chip", 0400,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
qcom_socinfo->dbg_root,
~~~~~~~~~~~~~~~~~~~~~~~
&qcom_socinfo->info.accessory_chip);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/soc/qcom/socinfo.c:351:2: note: here
case SOCINFO_VERSION(0, 4):
^~~~
drivers/soc/qcom/socinfo.c:354:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
debugfs_create_u32("platform_version", 0400,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
qcom_socinfo->dbg_root,
~~~~~~~~~~~~~~~~~~~~~~~
&qcom_socinfo->info.plat_ver);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/soc/qcom/socinfo.c:357:2: note: here
case SOCINFO_VERSION(0, 3):
^~~~
drivers/soc/qcom/socinfo.c:360:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
debugfs_create_u32("hardware_platform", 0400,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
qcom_socinfo->dbg_root,
~~~~~~~~~~~~~~~~~~~~~~~
&qcom_socinfo->info.hw_plat);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/soc/qcom/socinfo.c:363:2: note: here
case SOCINFO_VERSION(0, 2):
^~~~
drivers/soc/qcom/socinfo.c:366:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
debugfs_create_u32("raw_version", 0400, qcom_socinfo->dbg_root,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
&qcom_socinfo->info.raw_ver);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/soc/qcom/socinfo.c:368:2: note: here
case SOCINFO_VERSION(0, 1):
^~~~
Introduced by commit
9c84c1e78634 ("soc: qcom: socinfo: Expose custom attributes")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2019-08-07 0:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 0:08 Stephen Rothwell [this message]
2019-08-07 1:24 ` [PATCH] soc: qcom: socinfo: Annotate switch cases with fall through Bjorn Andersson
2019-08-07 1:40 ` Gustavo A. R. Silva
2019-08-07 1:50 ` Stephen Rothwell
2019-08-07 2:18 ` Bjorn Andersson
2019-08-07 2:23 ` [PATCH v2] " Bjorn Andersson
2019-08-07 4:25 ` Vaishali Thakkar
-- strict thread matches above, loose matches on Subject: below --
2021-10-24 23:28 linux-next: build warning after merge of the qcom tree Stephen Rothwell
2021-10-24 23:40 ` David Heidelberg
2021-10-25 2:24 ` Bjorn Andersson
2020-04-15 0:25 Stephen Rothwell
2020-04-15 4:51 ` Stephen Boyd
2020-04-15 5:04 ` Bjorn Andersson
2018-11-15 23:10 Stephen Rothwell
2018-11-28 21:25 ` Stephen Rothwell
2018-11-29 16:30 ` Stephen Boyd
2018-11-30 4:13 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190807100803.63007737@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=agross@kernel$(echo .)org \
--cc=bjorn.andersson@linaro$(echo .)org \
--cc=gustavo@embeddedor$(echo .)com \
--cc=keescook@chromium$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=vaishali.thakkar@linaro$(echo .)org \
--cc=vkoul@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox