* linux-next: Fixes tag needs some work in the pinctrl-intel-fixes tree
@ 2019-10-01 14:30 Stephen Rothwell
2019-10-01 14:39 ` Mika Westerberg
2019-10-01 14:43 ` Andy Shevchenko
0 siblings, 2 replies; 3+ messages in thread
From: Stephen Rothwell @ 2019-10-01 14:30 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Linux Next Mailing List, Linux Kernel Mailing List,
Mika Westerberg
[-- Attachment #1: Type: text/plain, Size: 335 bytes --]
Hi all,
In commit
d21556b6ff04 ("pinctrl: intel: Allocate IRQ chip dynamic")
Fixes tag
Fixes: ee1a6ca43dba ("Add Intel Broxton pin controller support")
has these problem(s):
- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: linux-next: Fixes tag needs some work in the pinctrl-intel-fixes tree
2019-10-01 14:30 linux-next: Fixes tag needs some work in the pinctrl-intel-fixes tree Stephen Rothwell
@ 2019-10-01 14:39 ` Mika Westerberg
2019-10-01 14:43 ` Andy Shevchenko
1 sibling, 0 replies; 3+ messages in thread
From: Mika Westerberg @ 2019-10-01 14:39 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Andy Shevchenko, Linux Next Mailing List,
Linux Kernel Mailing List
On Wed, Oct 02, 2019 at 12:30:04AM +1000, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> d21556b6ff04 ("pinctrl: intel: Allocate IRQ chip dynamic")
>
> Fixes tag
>
> Fixes: ee1a6ca43dba ("Add Intel Broxton pin controller support")
>
> has these problem(s):
>
> - Subject does not match target commit subject
> Just use
> git log -1 --format='Fixes: %h ("%s")'
Should be fixed now, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: linux-next: Fixes tag needs some work in the pinctrl-intel-fixes tree
2019-10-01 14:30 linux-next: Fixes tag needs some work in the pinctrl-intel-fixes tree Stephen Rothwell
2019-10-01 14:39 ` Mika Westerberg
@ 2019-10-01 14:43 ` Andy Shevchenko
1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2019-10-01 14:43 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Andy Shevchenko, Linux Next Mailing List,
Linux Kernel Mailing List, Mika Westerberg
On Tue, Oct 1, 2019 at 5:32 PM Stephen Rothwell <sfr@canb•auug.org.au> wrote:
> In commit
>
> d21556b6ff04 ("pinctrl: intel: Allocate IRQ chip dynamic")
>
> Fixes tag
>
> Fixes: ee1a6ca43dba ("Add Intel Broxton pin controller support")
>
> has these problem(s):
>
> - Subject does not match target commit subject
> Just use
> git log -1 --format='Fixes: %h ("%s")'
Thank you for pointing this out.
Nevertheless I have a question. Does prefix carry crucial information
for the commits which are already in the kernel? Can't we simple use
substring (or let's say most meaningful part of the commit subject)
instead?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-01 14:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-01 14:30 linux-next: Fixes tag needs some work in the pinctrl-intel-fixes tree Stephen Rothwell
2019-10-01 14:39 ` Mika Westerberg
2019-10-01 14:43 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox