From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Christian Borntraeger <borntraeger@de•ibm.com>
Cc: Linux Next Mailing List <linux-next@vger•kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Herbert Xu <herbert@gondor•apana.org.au>,
linux-s390 <linux-s390@vger•kernel.org>,
Hadar Gat <hadar.gat@arm•com>
Subject: Re: linux-next: Tree for Apr 20
Date: Mon, 20 Apr 2020 17:25:59 +1000 [thread overview]
Message-ID: <20200420172559.7b6dc5f1@canb.auug.org.au> (raw)
In-Reply-To: <2d87a4f9-9d87-e929-9b03-31f92dad5ca6@de.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1299 bytes --]
Hi all,
On Mon, 20 Apr 2020 09:14:15 +0200 Christian Borntraeger <borntraeger@de•ibm.com> wrote:
>
> s390 defconfig still does not compile. While the media kconfig problem is gone I now have
>
> CC [M] drivers/char/hw_random/cctrng.o
> drivers/char/hw_random/cctrng.c: In function ‘cc_trng_compwork_handler’:
> drivers/char/hw_random/cctrng.c:334:49: error: ‘fips_enabled’ undeclared (first use in this function); did you mean ‘vdso_enabled’?
> 334 | if (CC_REG_FLD_GET(RNG_ISR, CRNGT_ERR, isr) && fips_enabled) {
> | ^~~~~~~~~~~~
> | vdso_enabled
> drivers/char/hw_random/cctrng.c:334:49: note: each undeclared identifier is reported only once for each function it appears in
> drivers/char/hw_random/cctrng.c:335:3: error: implicit declaration of function ‘fips_fail_notify’ [-Werror=implicit-function-declaration]
> 335 | fips_fail_notify();
> | ^~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
>
> Can we maybe make this driver depend on ARM?
Caused by commit
a583ed310bb6 ("hwrng: cctrng - introduce Arm CryptoCell driver")
which has neglected to include linux/fips.h ...
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-04-20 7:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 4:26 linux-next: Tree for Apr 20 Stephen Rothwell
2020-04-20 7:14 ` Christian Borntraeger
2020-04-20 7:23 ` Hadar Gat
2020-04-20 7:30 ` Christian Borntraeger
2020-04-20 7:25 ` Stephen Rothwell [this message]
2020-04-20 15:21 ` linux-next: Tree for Apr 20 (media Kconfig warning) Randy Dunlap
2020-04-20 15:45 ` Randy Dunlap
2020-04-20 15:29 ` linux-next: Tree for Apr 20 (objtool warning) Randy Dunlap
2020-04-20 15:53 ` Josh Poimboeuf
2020-04-20 16:14 ` Randy Dunlap
2020-04-20 16:33 ` linux-next: Tree for Apr 20 (media: usbvision) Randy Dunlap
-- strict thread matches above, loose matches on Subject: below --
2026-04-20 13:10 linux-next: Tree for Apr 20 Mark Brown
2023-04-20 15:44 broonie
2022-04-20 7:50 Stephen Rothwell
2021-04-20 9:47 Stephen Rothwell
2021-04-20 12:02 ` Andy Shevchenko
2021-04-20 12:19 ` Andy Shevchenko
2021-04-20 12:35 ` Andy Shevchenko
2018-04-20 6:11 Stephen Rothwell
2017-04-20 6:43 Stephen Rothwell
2016-04-20 5:12 Stephen Rothwell
2015-04-20 5:45 Stephen Rothwell
2012-04-20 5:51 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420172559.7b6dc5f1@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=borntraeger@de$(echo .)ibm.com \
--cc=hadar.gat@arm$(echo .)com \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox