public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
* linux-next: build failure after merge of the drivers-memory tree
@ 2020-07-27 11:36 Stephen Rothwell
  2020-07-27 11:49 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 5+ messages in thread
From: Stephen Rothwell @ 2020-07-27 11:36 UTC (permalink / raw)
  To: Krzysztof Kozlowski; +Cc: Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 458 bytes --]

Hi all,

After merging the drivers-memory tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/memory/omap-gpmc.c:36:10: fatal error: asm/mach-types.h: No such file or directory
   36 | #include <asm/mach-types.h>
      |          ^~~~~~~~~~~~~~~~~~

Caused by commit

  99b42df9d57e ("memory: Enable compile testing for most of the drivers")

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: linux-next: build failure after merge of the drivers-memory tree
  2020-07-27 11:36 linux-next: build failure after merge of the drivers-memory tree Stephen Rothwell
@ 2020-07-27 11:49 ` Krzysztof Kozlowski
  0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2020-07-27 11:49 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Linux Next Mailing List, Linux Kernel Mailing List

On Mon, 27 Jul 2020 at 13:36, Stephen Rothwell <sfr@canb•auug.org.au> wrote:
>
> Hi all,
>
> After merging the drivers-memory tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/memory/omap-gpmc.c:36:10: fatal error: asm/mach-types.h: No such file or directory
>    36 | #include <asm/mach-types.h>
>       |          ^~~~~~~~~~~~~~~~~~
>
> Caused by commit
>
>   99b42df9d57e ("memory: Enable compile testing for most of the drivers")
>
> I have reverted that commit for today.

Yes, I applied the patch too early, without all dependencies fixing
compile testing. I will drop the commit from the tree soon.

Best Regards,
Krzysztof

^ permalink raw reply	[flat|nested] 5+ messages in thread

* linux-next: build failure after merge of the drivers-memory tree
@ 2020-11-08 23:23 Stephen Rothwell
  2020-11-09  1:01 ` Dmitry Osipenko
  0 siblings, 1 reply; 5+ messages in thread
From: Stephen Rothwell @ 2020-11-08 23:23 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Dmitry Osipenko, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 1321 bytes --]

Hi all,

After merging the drivers-memory tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from drivers/devfreq/tegra20-devfreq.c:18:
include/soc/tegra/mc.h: In function 'devm_tegra_memory_controller_get':
include/soc/tegra/mc.h:211:1: error: no return statement in function returning non-void [-Werror=return-type]
  211 | }
      | ^

Caused by commit

  1f1997eb44b1 ("memory: tegra: Add and use devm_tegra_memory_controller_get()")

I have added the following fix patch for today:

From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Mon, 9 Nov 2020 10:19:44 +1100
Subject: [PATCH] fix "memory: tegra: Add and use
 devm_tegra_memory_controller_get()"

Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
---
 include/soc/tegra/mc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/soc/tegra/mc.h b/include/soc/tegra/mc.h
index 43876216de34..d731407e23bb 100644
--- a/include/soc/tegra/mc.h
+++ b/include/soc/tegra/mc.h
@@ -207,7 +207,7 @@ struct tegra_mc *devm_tegra_memory_controller_get(struct device *dev);
 static inline struct tegra_mc *
 devm_tegra_memory_controller_get(struct device *dev)
 {
-	ERR_PTR(-ENODEV);
+	return ERR_PTR(-ENODEV);
 }
 #endif
 
-- 
2.28.0

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: linux-next: build failure after merge of the drivers-memory tree
  2020-11-08 23:23 Stephen Rothwell
@ 2020-11-09  1:01 ` Dmitry Osipenko
  2020-11-09  8:04   ` Krzysztof Kozlowski
  0 siblings, 1 reply; 5+ messages in thread
From: Dmitry Osipenko @ 2020-11-09  1:01 UTC (permalink / raw)
  To: Stephen Rothwell, Krzysztof Kozlowski
  Cc: Linux Kernel Mailing List, Linux Next Mailing List

09.11.2020 02:23, Stephen Rothwell пишет:
> Hi all,
> 
> After merging the drivers-memory tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> In file included from drivers/devfreq/tegra20-devfreq.c:18:
> include/soc/tegra/mc.h: In function 'devm_tegra_memory_controller_get':
> include/soc/tegra/mc.h:211:1: error: no return statement in function returning non-void [-Werror=return-type]
>   211 | }
>       | ^
> 
> Caused by commit
> 
>   1f1997eb44b1 ("memory: tegra: Add and use devm_tegra_memory_controller_get()")
> 
> I have added the following fix patch for today:
> 
> From: Stephen Rothwell <sfr@canb•auug.org.au>
> Date: Mon, 9 Nov 2020 10:19:44 +1100
> Subject: [PATCH] fix "memory: tegra: Add and use
>  devm_tegra_memory_controller_get()"
> 
> Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
> ---
>  include/soc/tegra/mc.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/soc/tegra/mc.h b/include/soc/tegra/mc.h
> index 43876216de34..d731407e23bb 100644
> --- a/include/soc/tegra/mc.h
> +++ b/include/soc/tegra/mc.h
> @@ -207,7 +207,7 @@ struct tegra_mc *devm_tegra_memory_controller_get(struct device *dev);
>  static inline struct tegra_mc *
>  devm_tegra_memory_controller_get(struct device *dev)
>  {
> -	ERR_PTR(-ENODEV);
> +	return ERR_PTR(-ENODEV);
>  }
>  #endif

Krzysztof, will you be able correct this typo locally, or should I add a
new patch?

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: linux-next: build failure after merge of the drivers-memory tree
  2020-11-09  1:01 ` Dmitry Osipenko
@ 2020-11-09  8:04   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2020-11-09  8:04 UTC (permalink / raw)
  To: Dmitry Osipenko
  Cc: Stephen Rothwell, Linux Kernel Mailing List,
	Linux Next Mailing List

On Mon, 9 Nov 2020 at 02:01, Dmitry Osipenko <digetx@gmail•com> wrote:
>
> 09.11.2020 02:23, Stephen Rothwell пишет:
> > Hi all,
> >
> > After merging the drivers-memory tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > In file included from drivers/devfreq/tegra20-devfreq.c:18:
> > include/soc/tegra/mc.h: In function 'devm_tegra_memory_controller_get':
> > include/soc/tegra/mc.h:211:1: error: no return statement in function returning non-void [-Werror=return-type]
> >   211 | }
> >       | ^
> >
> > Caused by commit
> >
> >   1f1997eb44b1 ("memory: tegra: Add and use devm_tegra_memory_controller_get()")
> >
> > I have added the following fix patch for today:
> >
> > From: Stephen Rothwell <sfr@canb•auug.org.au>
> > Date: Mon, 9 Nov 2020 10:19:44 +1100
> > Subject: [PATCH] fix "memory: tegra: Add and use
> >  devm_tegra_memory_controller_get()"
> >
> > Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
> > ---
> >  include/soc/tegra/mc.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/soc/tegra/mc.h b/include/soc/tegra/mc.h
> > index 43876216de34..d731407e23bb 100644
> > --- a/include/soc/tegra/mc.h
> > +++ b/include/soc/tegra/mc.h
> > @@ -207,7 +207,7 @@ struct tegra_mc *devm_tegra_memory_controller_get(struct device *dev);
> >  static inline struct tegra_mc *
> >  devm_tegra_memory_controller_get(struct device *dev)
> >  {
> > -     ERR_PTR(-ENODEV);
> > +     return ERR_PTR(-ENODEV);
> >  }
> >  #endif
>
> Krzysztof, will you be able correct this typo locally, or should I add a
> new patch?

Send a new patch please with Stephen's reported-by.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-11-09  8:04 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-27 11:36 linux-next: build failure after merge of the drivers-memory tree Stephen Rothwell
2020-07-27 11:49 ` Krzysztof Kozlowski
  -- strict thread matches above, loose matches on Subject: below --
2020-11-08 23:23 Stephen Rothwell
2020-11-09  1:01 ` Dmitry Osipenko
2020-11-09  8:04   ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox