* Re: [PATCH 2/2] kunit: ubsan integration [not found] ` <20200806174326.3577537-2-urielguajardojr@gmail.com> @ 2020-09-02 12:52 ` Qian Cai 2020-09-03 12:38 ` Qian Cai 0 siblings, 1 reply; 3+ messages in thread From: Qian Cai @ 2020-09-02 12:52 UTC (permalink / raw) To: Uriel Guajardo Cc: brendanhiggins, urielguajardo, linux-kernel, linux-kselftest, kunit-dev, sfr, linux-next On Thu, Aug 06, 2020 at 05:43:26PM +0000, Uriel Guajardo wrote: > Integrates UBSAN into the KUnit testing framework. It fails KUnit tests > whenever it reports undefined behavior. > > Signed-off-by: Uriel Guajardo <urielguajardo@google•com> It looks like this patch had been merged into linux-next but the "[PATCH 1/2] kunit: support failure from dynamic analysis tools" did not. Hence, it caused a compiling failure. lib/ubsan.c: In function ‘ubsan_prologue’: lib/ubsan.c:141:2: error: implicit declaration of function ‘kunit_fail_current_test’; did you mean ‘kunit_init_test’? [-Werror=implicit-function-declaration] kunit_fail_current_test(); ^~~~~~~~~~~~~~~~~~~~~~~ kunit_init_test cc1: some warnings being treated as errors > --- > lib/ubsan.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/lib/ubsan.c b/lib/ubsan.c > index cb9af3f6b77e..1460e2c828c8 100644 > --- a/lib/ubsan.c > +++ b/lib/ubsan.c > @@ -14,6 +14,7 @@ > #include <linux/types.h> > #include <linux/sched.h> > #include <linux/uaccess.h> > +#include <kunit/test.h> > > #include "ubsan.h" > > @@ -137,6 +138,7 @@ static void ubsan_prologue(struct source_location *loc, const char *reason) > { > current->in_ubsan++; > > + kunit_fail_current_test(); > pr_err("========================================" > "========================================\n"); > pr_err("UBSAN: %s in %s:%d:%d\n", reason, loc->file_name, > -- > 2.28.0.163.g6104cc2f0b6-goog > ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] kunit: ubsan integration 2020-09-02 12:52 ` [PATCH 2/2] kunit: ubsan integration Qian Cai @ 2020-09-03 12:38 ` Qian Cai 2020-09-09 3:00 ` Stephen Rothwell 0 siblings, 1 reply; 3+ messages in thread From: Qian Cai @ 2020-09-03 12:38 UTC (permalink / raw) To: skhan, sfr Cc: brendanhiggins, urielguajardo, linux-kernel, linux-kselftest, kunit-dev, linux-next On Wed, Sep 02, 2020 at 08:52:24AM -0400, Qian Cai wrote: > On Thu, Aug 06, 2020 at 05:43:26PM +0000, Uriel Guajardo wrote: > > Integrates UBSAN into the KUnit testing framework. It fails KUnit tests > > whenever it reports undefined behavior. > > > > Signed-off-by: Uriel Guajardo <urielguajardo@google•com> > > It looks like this patch had been merged into linux-next but the "[PATCH 1/2] > kunit: support failure from dynamic analysis tools" did not. Hence, it caused a > compiling failure. > > lib/ubsan.c: In function ‘ubsan_prologue’: > lib/ubsan.c:141:2: error: implicit declaration of function ‘kunit_fail_current_test’; did you mean ‘kunit_init_test’? [-Werror=implicit-function-declaration] > kunit_fail_current_test(); > ^~~~~~~~~~~~~~~~~~~~~~~ > kunit_init_test > cc1: some warnings being treated as errors Stephen, Shuah, can you revert this commit or pick up its dependency as well? https://lore.kernel.org/linux-kselftest/20200813205722.1384108-1-urielguajardojr@gmail.com/ Still seeing this on today's linux-next build. > > > --- > > lib/ubsan.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/lib/ubsan.c b/lib/ubsan.c > > index cb9af3f6b77e..1460e2c828c8 100644 > > --- a/lib/ubsan.c > > +++ b/lib/ubsan.c > > @@ -14,6 +14,7 @@ > > #include <linux/types.h> > > #include <linux/sched.h> > > #include <linux/uaccess.h> > > +#include <kunit/test.h> > > > > #include "ubsan.h" > > > > @@ -137,6 +138,7 @@ static void ubsan_prologue(struct source_location *loc, const char *reason) > > { > > current->in_ubsan++; > > > > + kunit_fail_current_test(); > > pr_err("========================================" > > "========================================\n"); > > pr_err("UBSAN: %s in %s:%d:%d\n", reason, loc->file_name, > > -- > > 2.28.0.163.g6104cc2f0b6-goog > > ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] kunit: ubsan integration 2020-09-03 12:38 ` Qian Cai @ 2020-09-09 3:00 ` Stephen Rothwell 0 siblings, 0 replies; 3+ messages in thread From: Stephen Rothwell @ 2020-09-09 3:00 UTC (permalink / raw) To: Qian Cai Cc: skhan, brendanhiggins, urielguajardo, linux-kernel, linux-kselftest, kunit-dev, linux-next [-- Attachment #1: Type: text/plain, Size: 1158 bytes --] Hi Qian, On Thu, 3 Sep 2020 08:38:25 -0400 Qian Cai <cai@lca•pw> wrote: > > On Wed, Sep 02, 2020 at 08:52:24AM -0400, Qian Cai wrote: > > On Thu, Aug 06, 2020 at 05:43:26PM +0000, Uriel Guajardo wrote: > > > Integrates UBSAN into the KUnit testing framework. It fails KUnit tests > > > whenever it reports undefined behavior. > > > > > > Signed-off-by: Uriel Guajardo <urielguajardo@google•com> > > > > It looks like this patch had been merged into linux-next but the "[PATCH 1/2] > > kunit: support failure from dynamic analysis tools" did not. Hence, it caused a > > compiling failure. > > > > lib/ubsan.c: In function ‘ubsan_prologue’: > > lib/ubsan.c:141:2: error: implicit declaration of function ‘kunit_fail_current_test’; did you mean ‘kunit_init_test’? [-Werror=implicit-function-declaration] > > kunit_fail_current_test(); > > ^~~~~~~~~~~~~~~~~~~~~~~ > > kunit_init_test > > cc1: some warnings being treated as errors > > Stephen, Shuah, can you revert this commit or pick up its dependency as well? Sorry, for the slow response ... this should be gone today. -- Cheers, Stephen Rothwell [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-09 3:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20200806174326.3577537-1-urielguajardojr@gmail.com>
[not found] ` <20200806174326.3577537-2-urielguajardojr@gmail.com>
2020-09-02 12:52 ` [PATCH 2/2] kunit: ubsan integration Qian Cai
2020-09-03 12:38 ` Qian Cai
2020-09-09 3:00 ` Stephen Rothwell
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox