* linux-next: Fixes tag needs some work in the v9fs tree
@ 2020-11-19 20:50 Stephen Rothwell
0 siblings, 0 replies; 3+ messages in thread
From: Stephen Rothwell @ 2020-11-19 20:50 UTC (permalink / raw)
To: Dominique Martinet; +Cc: Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 470 bytes --]
Hi all,
In commit
5bfe97d7382b ("9p: Fix writeback fid incorrectly being attached to dentry")
Fixes tag
Fixes: 6636b6dcc3db ("fs/9p: track open fids")
has these problem(s):
- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'
Maybe you meant
Fixes: 6636b6dcc3db ("9p: add refcount to p9_fid struct")
or
Fixes: 987a64850996 ("fs/9p: track open fids")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* linux-next: Fixes tag needs some work in the v9fs tree
@ 2025-03-16 22:00 Stephen Rothwell
2025-03-16 22:05 ` Dominique Martinet
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Rothwell @ 2025-03-16 22:00 UTC (permalink / raw)
To: Dominique Martinet
Cc: Christian Schoenebeck, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 443 bytes --]
Hi all,
In commit
ab63870a22b5 ("fs/9p: fix NULL pointer dereference on mkdir")
Fixes tag
Fixes: dafbe689736 ('9p fid refcount: cleanup p9_fid_put calls')
has these problem(s):
- SHA1 should be at least 12 digits long
This can be fixed for the future by setting core.abbrev to 12 (or
more) or (for git v2.11 or later) just making sure it is not set
(or set to "auto").
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: linux-next: Fixes tag needs some work in the v9fs tree
2025-03-16 22:00 Stephen Rothwell
@ 2025-03-16 22:05 ` Dominique Martinet
0 siblings, 0 replies; 3+ messages in thread
From: Dominique Martinet @ 2025-03-16 22:05 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Christian Schoenebeck, Linux Kernel Mailing List,
Linux Next Mailing List
Stephen Rothwell wrote on Mon, Mar 17, 2025 at 09:00:01AM +1100:
> Fixes tag
>
> Fixes: dafbe689736 ('9p fid refcount: cleanup p9_fid_put calls')
>
> has these problem(s):
>
> - SHA1 should be at least 12 digits long
> This can be fixed for the future by setting core.abbrev to 12 (or
> more) or (for git v2.11 or later) just making sure it is not set
> (or set to "auto").
Thanks, I've amended that.
(Also changed single quotes to double quotes even if that probably
doesn't matter, that's what I have in my pretty.fixes entry:
```
[pretty]
fixes = Fixes: %h (\"%s\")
```
)
--
Dominique Martinet | Asmadeus
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-16 22:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-19 20:50 linux-next: Fixes tag needs some work in the v9fs tree Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2025-03-16 22:00 Stephen Rothwell
2025-03-16 22:05 ` Dominique Martinet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox