From: Mauro Carvalho Chehab <mchehab+huawei@kernel•org>
To: Jacopo Mondi <jacopo@jmondi•org>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard•com>,
Sakari Ailus <sakari.ailus@linux•intel.com>,
Linux Media Mailing List <linux-media@vger•kernel.org>,
Jacopo Mondi <jacopo+renesas@jmondi•org>,
Stephen Rothwell <sfr@canb•auug.org.au>,
linux-next@vger•kernel.org
Subject: Re: [PATCH] media: i2c: fix max9271 build dependencies
Date: Mon, 8 Feb 2021 14:11:02 +0100 [thread overview]
Message-ID: <20210208141102.3d5999dd@coco.lan> (raw)
In-Reply-To: <20210208114142.skwc22xps5xiqdyo@uno.localdomain>
Em Mon, 8 Feb 2021 12:41:42 +0100
Jacopo Mondi <jacopo@jmondi•org> escreveu:
> > > If you do, instead:
> > >
> > > if VIDEO_V4L2 && I2C
> > > config VIDEO_MAX9271_SERIALIZER
> > > tristate
> > >
> > > config VIDEO_RDACM20
> > > select VIDEO_MAX9271_SERIALIZER
> > > ...
> > >
> > > config VIDEO_RDACM21
> > > select VIDEO_MAX9271_SERIALIZER
> > > ...
> > > endif
> > >
> > > Then you also won't need:
> > > depends on VIDEO_MAX9271_SERIALIZER || !VIDEO_MAX9271_SERIALIZER
> > >
> > > As select should do the right thing in this case, ensuring that MAX9271
> > > will be builtin either if RDACM20 or RDACM21 is builtin.
> >
> > I also vote for usage of "select".
> >
>
> I would prefer that too, I was concerned about possible un-met
> dependencies, as Sakari pointed out, but the current situation is no
> better, as the only Kconfig symbols where those can be listed are the
> camera modules one.
Works for me. I'll make a patch for it.
Thanks,
Mauro
next prev parent reply other threads:[~2021-02-08 13:12 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 0:32 linux-next: build warning after merge of the v4l-dvb tree Stephen Rothwell
2021-02-08 6:30 ` Mauro Carvalho Chehab
2021-02-08 8:33 ` Geert Uytterhoeven
2021-02-08 8:49 ` Mauro Carvalho Chehab
2021-02-08 8:52 ` Geert Uytterhoeven
2021-02-08 9:14 ` Mauro Carvalho Chehab
2021-02-08 6:53 ` [PATCH] media: i2c: fix max9271 build dependencies Mauro Carvalho Chehab
2021-02-08 7:27 ` Sakari Ailus
2021-02-08 8:36 ` Jacopo Mondi
2021-02-08 8:41 ` Sakari Ailus
2021-02-08 8:59 ` Jacopo Mondi
2021-02-08 9:03 ` Sakari Ailus
2021-02-08 9:08 ` Mauro Carvalho Chehab
2021-02-08 9:24 ` Sakari Ailus
2021-02-08 10:07 ` Mauro Carvalho Chehab
2021-02-08 11:32 ` Laurent Pinchart
2021-02-08 11:41 ` Jacopo Mondi
2021-02-08 13:11 ` Mauro Carvalho Chehab [this message]
2021-02-08 13:31 ` Mauro Carvalho Chehab
2021-02-08 13:40 ` Laurent Pinchart
2021-02-08 14:23 ` Mauro Carvalho Chehab
2021-02-08 14:31 ` Laurent Pinchart
2021-02-08 15:01 ` Mauro Carvalho Chehab
2021-02-08 13:55 ` Jacopo Mondi
2021-02-08 14:14 ` Mauro Carvalho Chehab
2021-02-08 14:49 ` Jacopo Mondi
2021-02-08 15:42 ` Mauro Carvalho Chehab
2021-02-08 16:26 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210208141102.3d5999dd@coco.lan \
--to=mchehab+huawei@kernel$(echo .)org \
--cc=jacopo+renesas@jmondi$(echo .)org \
--cc=jacopo@jmondi$(echo .)org \
--cc=laurent.pinchart@ideasonboard$(echo .)com \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sakari.ailus@linux$(echo .)intel.com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox