* linux-next: Signed-off-by missing for commit in the crypto tree
@ 2017-08-03 21:50 Stephen Rothwell
2017-08-04 1:29 ` Herbert Xu
0 siblings, 1 reply; 17+ messages in thread
From: Stephen Rothwell @ 2017-08-03 21:50 UTC (permalink / raw)
To: Herbert Xu
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Rabin Vincent,
Lars Persson
Hi all,
Commit
9577212cc0e2 ("crypto: hash - add crypto_(un)register_ahashes()")
is missing a Signed-off-by from its author.
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: linux-next: Signed-off-by missing for commit in the crypto tree
2017-08-03 21:50 Stephen Rothwell
@ 2017-08-04 1:29 ` Herbert Xu
2017-08-04 9:48 ` Lars Persson
0 siblings, 1 reply; 17+ messages in thread
From: Herbert Xu @ 2017-08-04 1:29 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Rabin Vincent,
Lars Persson
On Fri, Aug 04, 2017 at 07:50:22AM +1000, Stephen Rothwell wrote:
> Hi all,
>
> Commit
>
> 9577212cc0e2 ("crypto: hash - add crypto_(un)register_ahashes()")
>
> is missing a Signed-off-by from its author.
OK, I've backed out the patches in question. Please resubmit
with a sign-off. Thanks!
--
Email: Herbert Xu <herbert@gondor•apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: linux-next: Signed-off-by missing for commit in the crypto tree
2017-08-04 1:29 ` Herbert Xu
@ 2017-08-04 9:48 ` Lars Persson
0 siblings, 0 replies; 17+ messages in thread
From: Lars Persson @ 2017-08-04 9:48 UTC (permalink / raw)
To: Herbert Xu, Stephen Rothwell
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Rabin Vincent,
Lars Persson
On 08/04/2017 03:29 AM, Herbert Xu wrote:
> On Fri, Aug 04, 2017 at 07:50:22AM +1000, Stephen Rothwell wrote:
>> Hi all,
>>
>> Commit
>>
>> 9577212cc0e2 ("crypto: hash - add crypto_(un)register_ahashes()")
>>
>> is missing a Signed-off-by from its author.
>
> OK, I've backed out the patches in question. Please resubmit
> with a sign-off. Thanks!
>
Sorry for missing this. We fixed it in patch set v3.
BR,
Lars Persson
^ permalink raw reply [flat|nested] 17+ messages in thread
* linux-next: Signed-off-by missing for commit in the crypto tree
@ 2018-12-23 12:13 Stephen Rothwell
2018-12-23 12:30 ` Herbert Xu
0 siblings, 1 reply; 17+ messages in thread
From: Stephen Rothwell @ 2018-12-23 12:13 UTC (permalink / raw)
To: Herbert Xu
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Harsh Jain,
Atul Gupta
[-- Attachment #1: Type: text/plain, Size: 175 bytes --]
Hi Herbert,
Commit
6501ab5ed4d9 ("crypto: chelsio - Reset counters on cxgb4 Detach")
is missing a Signed-off-by from its author.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: linux-next: Signed-off-by missing for commit in the crypto tree
2018-12-23 12:13 Stephen Rothwell
@ 2018-12-23 12:30 ` Herbert Xu
2018-12-26 9:48 ` Harsh Jain
0 siblings, 1 reply; 17+ messages in thread
From: Herbert Xu @ 2018-12-23 12:30 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Harsh Jain,
Atul Gupta
On Sun, Dec 23, 2018 at 11:13:04PM +1100, Stephen Rothwell wrote:
> Hi Herbert,
>
> Commit
>
> 6501ab5ed4d9 ("crypto: chelsio - Reset counters on cxgb4 Detach")
>
> is missing a Signed-off-by from its author.
Hi Stephen:
I believe the issue here is not a missing sign-off from the author,
but rather that the author was incorrectly set to Harsh who sent
the email rather than Atul.
Harsh, please add a From header to the patch description in future
so that the Author field is set correctly.
Cheers,
--
Email: Herbert Xu <herbert@gondor•apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: linux-next: Signed-off-by missing for commit in the crypto tree
2018-12-23 12:30 ` Herbert Xu
@ 2018-12-26 9:48 ` Harsh Jain
0 siblings, 0 replies; 17+ messages in thread
From: Harsh Jain @ 2018-12-26 9:48 UTC (permalink / raw)
To: Herbert Xu, Stephen Rothwell
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Atul Gupta
On 23-12-2018 18:00, Herbert Xu wrote:
> On Sun, Dec 23, 2018 at 11:13:04PM +1100, Stephen Rothwell wrote:
>> Hi Herbert,
>>
>> Commit
>>
>> 6501ab5ed4d9 ("crypto: chelsio - Reset counters on cxgb4 Detach")
>>
>> is missing a Signed-off-by from its author.
> Hi Stephen:
>
> I believe the issue here is not a missing sign-off from the author,
> but rather that the author was incorrectly set to Harsh who sent
> the email rather than Atul.
>
> Harsh, please add a From header to the patch description in future
> so that the Author field is set correctly.
oops, Will take care next time. Thanks.
>
> Cheers,
^ permalink raw reply [flat|nested] 17+ messages in thread
* linux-next: Signed-off-by missing for commit in the crypto tree
@ 2019-07-27 5:07 Stephen Rothwell
2019-07-27 11:10 ` Herbert Xu
0 siblings, 1 reply; 17+ messages in thread
From: Stephen Rothwell @ 2019-07-27 5:07 UTC (permalink / raw)
To: Herbert Xu; +Cc: Linux Next Mailing List, Linux Kernel Mailing List, Hook, Gary
[-- Attachment #1: Type: text/plain, Size: 187 bytes --]
Hi all,
Commit
53a5d5192803 ("crypto: ccp - Log an error message when ccp-crypto fails to load")
is missing a Signed-off-by from its author.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: linux-next: Signed-off-by missing for commit in the crypto tree
2019-07-27 5:07 Stephen Rothwell
@ 2019-07-27 11:10 ` Herbert Xu
0 siblings, 0 replies; 17+ messages in thread
From: Herbert Xu @ 2019-07-27 11:10 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Hook, Gary
On Sat, Jul 27, 2019 at 03:07:38PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> Commit
>
> 53a5d5192803 ("crypto: ccp - Log an error message when ccp-crypto fails to load")
>
> is missing a Signed-off-by from its author.
Thanks Stephen.
Gary, I've backed this patch out. Please resubmit with a sign-off.
Cheers,
--
Email: Herbert Xu <herbert@gondor•apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 17+ messages in thread
* linux-next: Signed-off-by missing for commit in the crypto tree
@ 2020-01-09 9:00 Stephen Rothwell
0 siblings, 0 replies; 17+ messages in thread
From: Stephen Rothwell @ 2020-01-09 9:00 UTC (permalink / raw)
To: Herbert Xu, Linux Crypto List
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Gary R Hook
[-- Attachment #1: Type: text/plain, Size: 170 bytes --]
Hi all,
Commit
e91e785e1821 ("crypto: ccp - Update MAINTAINERS for CCP driver")
is missing a Signed-off-by from its author.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* linux-next: Signed-off-by missing for commit in the crypto tree
@ 2020-11-13 7:22 Stephen Rothwell
0 siblings, 0 replies; 17+ messages in thread
From: Stephen Rothwell @ 2020-11-13 7:22 UTC (permalink / raw)
To: Herbert Xu, Linux Crypto List
Cc: Hui Tang, Meng Yu, Zaibo Xu, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 191 bytes --]
Hi all,
Commit
50d7e084c48d ("crypto: hisilicon/hpre - add initial settings adapt to 'Kunpeng 930'")
is missing a Signed-off-by from its author.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* linux-next: Signed-off-by missing for commit in the crypto tree
@ 2023-03-13 21:42 Stephen Rothwell
0 siblings, 0 replies; 17+ messages in thread
From: Stephen Rothwell @ 2023-03-13 21:42 UTC (permalink / raw)
To: Herbert Xu
Cc: Linux Crypto List, Uwe Kleine-König,
Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 191 bytes --]
Hi all,
Commit
b4fb7f4afa5d ("hwrng: xgene - Improve error reporting for problems during .remove()")
is missing a Signed-off-by from its author.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* linux-next: Signed-off-by missing for commit in the crypto tree
@ 2023-07-16 21:55 Stephen Rothwell
2023-07-17 13:00 ` Mahmoud Adam
0 siblings, 1 reply; 17+ messages in thread
From: Stephen Rothwell @ 2023-07-16 21:55 UTC (permalink / raw)
To: Herbert Xu, Linux Crypto List
Cc: Mahmoud Adam, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 157 bytes --]
Hi all,
Commit
a0459d277b1b ("KEYS: use kfree_sensitive with key")
is missing a Signed-off-by from its author.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: linux-next: Signed-off-by missing for commit in the crypto tree
2023-07-16 21:55 linux-next: Signed-off-by missing for commit in the crypto tree Stephen Rothwell
@ 2023-07-17 13:00 ` Mahmoud Adam
0 siblings, 0 replies; 17+ messages in thread
From: Mahmoud Adam @ 2023-07-17 13:00 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Herbert Xu, Linux Crypto List, Linux Kernel Mailing List,
Linux Next Mailing List
Stephen Rothwell <sfr@canb•auug.org.au> writes:
> Hi all,
>
> Commit
>
> a0459d277b1b ("KEYS: use kfree_sensitive with key")
>
> is missing a Signed-off-by from its author.
Sorry for that, sent Patch v4 with the correction
^ permalink raw reply [flat|nested] 17+ messages in thread
* linux-next: Signed-off-by missing for commit in the crypto tree
@ 2024-10-27 21:15 Stephen Rothwell
0 siblings, 0 replies; 17+ messages in thread
From: Stephen Rothwell @ 2024-10-27 21:15 UTC (permalink / raw)
To: Herbert Xu, Linux Crypto List
Cc: Vishal Chourasia, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 180 bytes --]
Hi all,
Commit
504eebffb656 ("crypto: nx - Fix invalid wait context during kexec reboot")
is missing a Signed-off-by from its author.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* linux-next: Signed-off-by missing for commit in the crypto tree
@ 2025-05-05 9:55 Stephen Rothwell
2025-05-05 10:22 ` Herbert Xu
0 siblings, 1 reply; 17+ messages in thread
From: Stephen Rothwell @ 2025-05-05 9:55 UTC (permalink / raw)
To: Herbert Xu, Linux Crypto List
Cc: Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 2290 bytes --]
Hi all,
Commits
e4274cd4f727 ("crypto: hisilicon/qm - replace devm_kzalloc with devm_kcalloc")
3f9ea3a5618e ("crypto: hisilicon/qm - remove sizeof(char)")
7da3b0ff2af8 ("crypto: sun8i-ce-hash - use pm_runtime_resume_and_get()")
2c870574fb94 ("crypto: sun8i-ce - undo runtime PM changes during driver removal")
24418b58792a ("hwrng: rockchip - add support for RK3576's RNG")
e511999438e1 ("dt-bindings: rng: rockchip,rk3588-rng: add rk3576-rng compatible")
13917ce458c7 ("crypto: rng - fix documentation for crypto_rng_alg()")
c6527b8ca148 ("crypto: qat - add qat_6xxx driver")
bed3233d9e4f ("crypto: qat - add firmware headers for GEN6 devices")
4903f74450d1 ("crypto: qat - update firmware api")
e9833be85348 ("crypto: qat - export adf_init_admin_pm()")
a260a62349b0 ("crypto: qat - expose configuration functions")
8e84a854176a ("crypto: qat - export adf_get_service_mask()")
ff193f6c14e9 ("crypto: qat - add GEN6 firmware loader")
c1e216382091 ("crypto: qat - refactor FW signing algorithm")
25177bb3f705 ("crypto: qat - use pr_fmt() in qat uclo.c")
5fc9923d1554 ("crypto: qat - refactor compression template logic")
424b3c3cfbae ("crypto: qat - rename and relocate timer logic")
9b6fc5b6e9c0 ("crypto: qat - include qat_common in top Makefile")
f230dcfe428b ("crypto: lib/sha256 - improve function prototypes")
e42b6c1e17cc ("crypto: sha256 - remove sha256_base.h")
91c5c4bf145d ("crypto: x86/sha256 - implement library instead of shash")
42802c7f8eff ("crypto: sparc/sha256 - implement library instead of shash")
1a92dd688525 ("crypto: sparc - move opcodes.h into asm directory")
d31058b2589f ("crypto: s390/sha256 - implement library instead of shash")
fe11c8974fdc ("crypto: riscv/sha256 - implement library instead of shash")
9d2b1924c137 ("crypto: powerpc/sha256 - implement library instead of shash")
19c9460ea05b ("crypto: mips/sha256 - implement library instead of shash")
6df537365d25 ("crypto: arm64/sha256 - implement library instead of shash")
4fcab0fbfd54 ("crypto: arm64/sha256 - remove obsolete chunking logic")
7f4bd270972c ("crypto: arm/sha256 - implement library instead of shash")
are missing a Signed-off-by from their committer.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: linux-next: Signed-off-by missing for commit in the crypto tree
2025-05-05 9:55 Stephen Rothwell
@ 2025-05-05 10:22 ` Herbert Xu
0 siblings, 0 replies; 17+ messages in thread
From: Herbert Xu @ 2025-05-05 10:22 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linux Crypto List, Linux Kernel Mailing List,
Linux Next Mailing List
On Mon, May 05, 2025 at 07:55:27PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> Commits
>
> e4274cd4f727 ("crypto: hisilicon/qm - replace devm_kzalloc with devm_kcalloc")
> 3f9ea3a5618e ("crypto: hisilicon/qm - remove sizeof(char)")
> 7da3b0ff2af8 ("crypto: sun8i-ce-hash - use pm_runtime_resume_and_get()")
> 2c870574fb94 ("crypto: sun8i-ce - undo runtime PM changes during driver removal")
> 24418b58792a ("hwrng: rockchip - add support for RK3576's RNG")
> e511999438e1 ("dt-bindings: rng: rockchip,rk3588-rng: add rk3576-rng compatible")
> 13917ce458c7 ("crypto: rng - fix documentation for crypto_rng_alg()")
> c6527b8ca148 ("crypto: qat - add qat_6xxx driver")
> bed3233d9e4f ("crypto: qat - add firmware headers for GEN6 devices")
> 4903f74450d1 ("crypto: qat - update firmware api")
> e9833be85348 ("crypto: qat - export adf_init_admin_pm()")
> a260a62349b0 ("crypto: qat - expose configuration functions")
> 8e84a854176a ("crypto: qat - export adf_get_service_mask()")
> ff193f6c14e9 ("crypto: qat - add GEN6 firmware loader")
> c1e216382091 ("crypto: qat - refactor FW signing algorithm")
> 25177bb3f705 ("crypto: qat - use pr_fmt() in qat uclo.c")
> 5fc9923d1554 ("crypto: qat - refactor compression template logic")
> 424b3c3cfbae ("crypto: qat - rename and relocate timer logic")
> 9b6fc5b6e9c0 ("crypto: qat - include qat_common in top Makefile")
> f230dcfe428b ("crypto: lib/sha256 - improve function prototypes")
> e42b6c1e17cc ("crypto: sha256 - remove sha256_base.h")
> 91c5c4bf145d ("crypto: x86/sha256 - implement library instead of shash")
> 42802c7f8eff ("crypto: sparc/sha256 - implement library instead of shash")
> 1a92dd688525 ("crypto: sparc - move opcodes.h into asm directory")
> d31058b2589f ("crypto: s390/sha256 - implement library instead of shash")
> fe11c8974fdc ("crypto: riscv/sha256 - implement library instead of shash")
> 9d2b1924c137 ("crypto: powerpc/sha256 - implement library instead of shash")
> 19c9460ea05b ("crypto: mips/sha256 - implement library instead of shash")
> 6df537365d25 ("crypto: arm64/sha256 - implement library instead of shash")
> 4fcab0fbfd54 ("crypto: arm64/sha256 - remove obsolete chunking logic")
> 7f4bd270972c ("crypto: arm/sha256 - implement library instead of shash")
>
> are missing a Signed-off-by from their committer.
Thanks for the heads up Stephen. I've just fixed this up and
pushed it out again.
Cheers,
--
Email: Herbert Xu <herbert@gondor•apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 17+ messages in thread
* linux-next: Signed-off-by missing for commit in the crypto tree
@ 2025-05-20 12:45 Stephen Rothwell
0 siblings, 0 replies; 17+ messages in thread
From: Stephen Rothwell @ 2025-05-20 12:45 UTC (permalink / raw)
To: Herbert Xu, Linux Crypto List
Cc: Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 288 bytes --]
Hi all,
Commit
d9f88adbf117 ("Revert "crypto: powerpc/poly1305 - Add SIMD fallback"")
is missing a Signed-off-by from its author and committer.
Reverts are commits as well and so deserve reasonable commit messages
and Signed-off-by tags.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2025-05-20 12:45 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-16 21:55 linux-next: Signed-off-by missing for commit in the crypto tree Stephen Rothwell
2023-07-17 13:00 ` Mahmoud Adam
-- strict thread matches above, loose matches on Subject: below --
2025-05-20 12:45 Stephen Rothwell
2025-05-05 9:55 Stephen Rothwell
2025-05-05 10:22 ` Herbert Xu
2024-10-27 21:15 Stephen Rothwell
2023-03-13 21:42 Stephen Rothwell
2020-11-13 7:22 Stephen Rothwell
2020-01-09 9:00 Stephen Rothwell
2019-07-27 5:07 Stephen Rothwell
2019-07-27 11:10 ` Herbert Xu
2018-12-23 12:13 Stephen Rothwell
2018-12-23 12:30 ` Herbert Xu
2018-12-26 9:48 ` Harsh Jain
2017-08-03 21:50 Stephen Rothwell
2017-08-04 1:29 ` Herbert Xu
2017-08-04 9:48 ` Lars Persson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox