From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Rob Herring <robherring2@gmail•com>
Cc: Frank Rowand <frowand.list@gmail•com>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Linux Next Mailing List <linux-next@vger•kernel.org>,
Randy Dunlap <rdunlap@infradead•org>,
Rob Herring <robh@kernel•org>
Subject: Re: [PATCH] of: fix htmldocs build warnings
Date: Mon, 24 Jul 2023 13:55:13 +1000 [thread overview]
Message-ID: <20230724135513.3773f184@canb.auug.org.au> (raw)
In-Reply-To: <20230713161038.382b5e14@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 2368 bytes --]
Hi all,
On Thu, 13 Jul 2023 16:10:38 +1000 Stephen Rothwell <sfr@canb•auug.org.au> wrote:
>
> On Wed, 22 Mar 2023 18:00:32 +1100 Stephen Rothwell <sfr@canb•auug.org.au> wrote:
> >
> > Fix these htmldoc build warnings:
> >
> > include/linux/of.h:115: warning: cannot understand function prototype: 'const struct kobj_type of_node_ktype; '
> > include/linux/of.h:118: warning: Excess function parameter 'phandle_name' description in 'of_node_init'
> >
> > Reported by: Stephen Rothwell <sfr@canb•auug.org.au>
> > Reported by: Randy Dunlap <rdunlap@infradead•org>
> > Fixes: 39459ce717b8 ("of: dynamic: add lifecycle docbook info to node creation functions")
> > Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
> > ---
> > include/linux/of.h | 7 +++----
> > 1 file changed, 3 insertions(+), 4 deletions(-)
> >
> > Replaces "[PATCH] of: fix htmldocs build warning" and additionally
> > fixes the new warning about phandle that Randy reported.
> >
> > diff --git a/include/linux/of.h b/include/linux/of.h
> > index 9b7a99499ef3..d55dab9ad728 100644
> > --- a/include/linux/of.h
> > +++ b/include/linux/of.h
> > @@ -100,10 +100,12 @@ struct of_reconfig_data {
> > struct property *old_prop;
> > };
> >
> > +extern const struct kobj_type of_node_ktype;
> > +extern const struct fwnode_operations of_fwnode_ops;
> > +
> > /**
> > * of_node_init - initialize a devicetree node
> > * @node: Pointer to device node that has been created by kzalloc()
> > - * @phandle_name: Name of property holding a phandle value
> > *
> > * On return the device_node refcount is set to one. Use of_node_put()
> > * on @node when done to free the memory allocated for it. If the node
> > @@ -111,9 +113,6 @@ struct of_reconfig_data {
> > * whether to free the memory will be done by node->release(), which is
> > * of_node_release().
> > */
> > -/* initialize a node */
> > -extern const struct kobj_type of_node_ktype;
> > -extern const struct fwnode_operations of_fwnode_ops;
> > static inline void of_node_init(struct device_node *node)
> > {
> > #if defined(CONFIG_OF_KOBJ)
> > --
> > 2.39.2
>
> Any chance if this patch being applied?
Is there something wrong with the patch?
P.S. Rob, should I use your kernel.org address as your linux-next
contact?
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-07-24 3:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 5:36 linux-next: build warning after merge of the devicetree tree Stephen Rothwell
2023-03-10 0:32 ` [PATCH] of: fix htmldocs build warning Stephen Rothwell
2023-03-10 4:52 ` Randy Dunlap
2023-03-22 3:21 ` Randy Dunlap
2023-03-22 7:00 ` [PATCH] of: fix htmldocs build warnings Stephen Rothwell
2023-03-22 18:50 ` Randy Dunlap
2023-07-02 22:51 ` Stephen Rothwell
2023-07-13 6:10 ` Stephen Rothwell
2023-07-24 3:55 ` Stephen Rothwell [this message]
2023-07-24 13:13 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230724135513.3773f184@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=frowand.list@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=rdunlap@infradead$(echo .)org \
--cc=robh@kernel$(echo .)org \
--cc=robherring2@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox