From: Randy Dunlap <rdunlap@infradead•org>
To: Stephen Rothwell <sfr@canb•auug.org.au>,
Rob Herring <robherring2@gmail•com>
Cc: Frank Rowand <frowand.list@gmail•com>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Linux Next Mailing List <linux-next@vger•kernel.org>
Subject: Re: [PATCH] of: fix htmldocs build warning
Date: Thu, 9 Mar 2023 20:52:57 -0800 [thread overview]
Message-ID: <b8e8e51e-1ccf-e413-0831-ae5f70da539b@infradead.org> (raw)
In-Reply-To: <20230310113258.463f836c@canb.auug.org.au>
On 3/9/23 16:32, Stephen Rothwell wrote:
>
> Fix this htmldoc build warning:
>
> include/linux/of.h:115: warning: cannot understand function prototype: 'const struct kobj_type of_node_ktype; '
>
> Reported by: Stephen Rothwell <sfr@canb•auug.org.au>
> Fixes: 39459ce717b8 ("of: dynamic: add lifecycle docbook info to node creation functions")
> Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
Acked-by: Randy Dunlap <rdunlap@infradead•org>
Tested-by: Randy Dunlap <rdunlap@infradead•org>
Thanks.
After this patch, there is another warning for this function:
../include/linux/of.h:118: warning: Excess function parameter 'phandle_name' description in 'of_node_init'
> ---
> include/linux/of.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> This is actually untested, but seems pretty straight forward.
>
> diff --git a/include/linux/of.h b/include/linux/of.h
> index 0af611307db2..814d33f3835a 100644
> --- a/include/linux/of.h
> +++ b/include/linux/of.h
> @@ -100,6 +100,9 @@ struct of_reconfig_data {
> struct property *old_prop;
> };
>
> +extern const struct kobj_type of_node_ktype;
> +extern const struct fwnode_operations of_fwnode_ops;
> +
> /**
> * of_node_init - initialize a devicetree node
> * @node: Pointer to device node that has been created by kzalloc()
> @@ -111,9 +114,6 @@ struct of_reconfig_data {
> * whether to free the memory will be done by node->release(), which is
> * of_node_release().
> */
> -/* initialize a node */
> -extern const struct kobj_type of_node_ktype;
> -extern const struct fwnode_operations of_fwnode_ops;
> static inline void of_node_init(struct device_node *node)
> {
> #if defined(CONFIG_OF_KOBJ)
--
~Randy
next prev parent reply other threads:[~2023-03-10 4:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 5:36 linux-next: build warning after merge of the devicetree tree Stephen Rothwell
2023-03-10 0:32 ` [PATCH] of: fix htmldocs build warning Stephen Rothwell
2023-03-10 4:52 ` Randy Dunlap [this message]
2023-03-22 3:21 ` Randy Dunlap
2023-03-22 7:00 ` [PATCH] of: fix htmldocs build warnings Stephen Rothwell
2023-03-22 18:50 ` Randy Dunlap
2023-07-02 22:51 ` Stephen Rothwell
2023-07-13 6:10 ` Stephen Rothwell
2023-07-24 3:55 ` Stephen Rothwell
2023-07-24 13:13 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8e8e51e-1ccf-e413-0831-ae5f70da539b@infradead.org \
--to=rdunlap@infradead$(echo .)org \
--cc=frowand.list@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=robherring2@gmail$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox