public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
* [PATCH 1/1] media: via: Use correct dependency for camera sensor drivers
@ 2023-08-22  8:10 Sakari Ailus
  2023-08-22 21:01 ` Randy Dunlap
  0 siblings, 1 reply; 2+ messages in thread
From: Sakari Ailus @ 2023-08-22  8:10 UTC (permalink / raw)
  To: linux-media, Randy Dunlap
  Cc: hverkuil, Stephen Rothwell, Linux Kernel Mailing List, linux-next,
	Wentong Wu, Zhifeng Wang, Mauro Carvalho Chehab

The via camera controller driver selected ov7670 driver, however now that
driver has dependencies and may no longer be selected unconditionally.

Reported-by: Randy Dunlap <rdunlap@infradead•org>
Fixes: 7d3c7d2a2914 ("media: i2c: Add a camera sensor top level menu")
Signed-off-by: Sakari Ailus <sakari.ailus@linux•intel.com>
---
 drivers/media/platform/via/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/via/Kconfig b/drivers/media/platform/via/Kconfig
index 8926eb0803b2..6e603c038248 100644
--- a/drivers/media/platform/via/Kconfig
+++ b/drivers/media/platform/via/Kconfig
@@ -7,7 +7,7 @@ config VIDEO_VIA_CAMERA
 	depends on V4L_PLATFORM_DRIVERS
 	depends on FB_VIA && VIDEO_DEV
 	select VIDEOBUF2_DMA_SG
-	select VIDEO_OV7670
+	select VIDEO_OV7670 if VIDEO_CAMERA_SENSOR
 	help
 	   Driver support for the integrated camera controller in VIA
 	   Chrome9 chipsets.  Currently only tested on OLPC xo-1.5 systems
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/1] media: via: Use correct dependency for camera sensor drivers
  2023-08-22  8:10 [PATCH 1/1] media: via: Use correct dependency for camera sensor drivers Sakari Ailus
@ 2023-08-22 21:01 ` Randy Dunlap
  0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2023-08-22 21:01 UTC (permalink / raw)
  To: Sakari Ailus, linux-media
  Cc: hverkuil, Stephen Rothwell, Linux Kernel Mailing List, linux-next,
	Wentong Wu, Zhifeng Wang, Mauro Carvalho Chehab



On 8/22/23 01:10, Sakari Ailus wrote:
> The via camera controller driver selected ov7670 driver, however now that
> driver has dependencies and may no longer be selected unconditionally.
> 
> Reported-by: Randy Dunlap <rdunlap@infradead•org>
> Fixes: 7d3c7d2a2914 ("media: i2c: Add a camera sensor top level menu")
> Signed-off-by: Sakari Ailus <sakari.ailus@linux•intel.com>

Acked-by: Randy Dunlap <rdunlap@infradead•org>
Tested-by: Randy Dunlap <rdunlap@infradead•org>

Thanks.

> ---
>  drivers/media/platform/via/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/via/Kconfig b/drivers/media/platform/via/Kconfig
> index 8926eb0803b2..6e603c038248 100644
> --- a/drivers/media/platform/via/Kconfig
> +++ b/drivers/media/platform/via/Kconfig
> @@ -7,7 +7,7 @@ config VIDEO_VIA_CAMERA
>  	depends on V4L_PLATFORM_DRIVERS
>  	depends on FB_VIA && VIDEO_DEV
>  	select VIDEOBUF2_DMA_SG
> -	select VIDEO_OV7670
> +	select VIDEO_OV7670 if VIDEO_CAMERA_SENSOR
>  	help
>  	   Driver support for the integrated camera controller in VIA
>  	   Chrome9 chipsets.  Currently only tested on OLPC xo-1.5 systems

-- 
~Randy

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-08-22 21:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-22  8:10 [PATCH 1/1] media: via: Use correct dependency for camera sensor drivers Sakari Ailus
2023-08-22 21:01 ` Randy Dunlap

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox