* linux-next: build warning after merge of the dmi tree
@ 2024-04-30 1:46 Stephen Rothwell
2024-04-30 6:50 ` Stephen Rothwell
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Rothwell @ 2024-04-30 1:46 UTC (permalink / raw)
To: Jean Delvare; +Cc: Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 2194 bytes --]
Hi all,
After merging the dmi tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
In file included from include/asm-generic/bug.h:22,
from arch/arm/include/asm/bug.h:60,
from include/linux/bug.h:5,
from include/linux/thread_info.h:13,
from include/asm-generic/preempt.h:5,
from ./arch/arm/include/generated/asm/preempt.h:1,
from include/linux/preempt.h:79,
from include/linux/spinlock.h:56,
from include/linux/mmzone.h:8,
from include/linux/gfp.h:7,
from include/linux/umh.h:4,
from include/linux/kmod.h:9,
from include/linux/module.h:17,
from drivers/firmware/dmi_scan.c:5:
drivers/firmware/dmi_scan.c: In function 'dmi_decode_table':
include/linux/kern_levels.h:5:25: warning: format '%ld' expects argument of type 'long int', but argument 2 has type 'int' [-Wformat=]
5 | #define KERN_SOH "\001" /* ASCII Start Of Header */
| ^~~~~~
include/linux/printk.h:429:25: note: in definition of macro 'printk_index_wrap'
429 | _p_func(_fmt, ##__VA_ARGS__); \
| ^~~~
include/linux/printk.h:510:9: note: in expansion of macro 'printk'
510 | printk(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~
include/linux/kern_levels.h:12:25: note: in expansion of macro 'KERN_SOH'
12 | #define KERN_WARNING KERN_SOH "4" /* warning conditions */
| ^~~~~~~~
include/linux/printk.h:510:16: note: in expansion of macro 'KERN_WARNING'
510 | printk(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~
drivers/firmware/dmi_scan.c:109:25: note: in expansion of macro 'pr_warn'
109 | pr_warn(FW_BUG
| ^~~~~~~
Introduced by commit
868577e6bfe1 ("firmware: dmi: Stop decoding on broken entry")
Include printk.h?
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: linux-next: build warning after merge of the dmi tree
2024-04-30 1:46 linux-next: build warning after merge of the dmi tree Stephen Rothwell
@ 2024-04-30 6:50 ` Stephen Rothwell
2024-05-03 6:57 ` Jean Delvare
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Rothwell @ 2024-04-30 6:50 UTC (permalink / raw)
To: Jean Delvare; +Cc: Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 2452 bytes --]
Hi all,
On Tue, 30 Apr 2024 11:46:13 +1000 Stephen Rothwell <sfr@canb•auug.org.au> wrote:
>
> After merging the dmi tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> In file included from include/asm-generic/bug.h:22,
> from arch/arm/include/asm/bug.h:60,
> from include/linux/bug.h:5,
> from include/linux/thread_info.h:13,
> from include/asm-generic/preempt.h:5,
> from ./arch/arm/include/generated/asm/preempt.h:1,
> from include/linux/preempt.h:79,
> from include/linux/spinlock.h:56,
> from include/linux/mmzone.h:8,
> from include/linux/gfp.h:7,
> from include/linux/umh.h:4,
> from include/linux/kmod.h:9,
> from include/linux/module.h:17,
> from drivers/firmware/dmi_scan.c:5:
> drivers/firmware/dmi_scan.c: In function 'dmi_decode_table':
> include/linux/kern_levels.h:5:25: warning: format '%ld' expects argument of type 'long int', but argument 2 has type 'int' [-Wformat=]
> 5 | #define KERN_SOH "\001" /* ASCII Start Of Header */
> | ^~~~~~
> include/linux/printk.h:429:25: note: in definition of macro 'printk_index_wrap'
> 429 | _p_func(_fmt, ##__VA_ARGS__); \
> | ^~~~
> include/linux/printk.h:510:9: note: in expansion of macro 'printk'
> 510 | printk(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__)
> | ^~~~~~
> include/linux/kern_levels.h:12:25: note: in expansion of macro 'KERN_SOH'
> 12 | #define KERN_WARNING KERN_SOH "4" /* warning conditions */
> | ^~~~~~~~
> include/linux/printk.h:510:16: note: in expansion of macro 'KERN_WARNING'
> 510 | printk(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__)
> | ^~~~~~~~~~~~
> drivers/firmware/dmi_scan.c:109:25: note: in expansion of macro 'pr_warn'
> 109 | pr_warn(FW_BUG
> | ^~~~~~~
>
> Introduced by commit
>
> 868577e6bfe1 ("firmware: dmi: Stop decoding on broken entry")
>
> Include printk.h?
This caused i386 defconfig build fail, so I have reverted this commit
for today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: linux-next: build warning after merge of the dmi tree
2024-04-30 6:50 ` Stephen Rothwell
@ 2024-05-03 6:57 ` Jean Delvare
0 siblings, 0 replies; 3+ messages in thread
From: Jean Delvare @ 2024-05-03 6:57 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Linux Kernel Mailing List, Linux Next Mailing List
Hi Stephen,
On Tue, 30 Apr 2024 16:50:17 +1000, Stephen Rothwell wrote:
> On Tue, 30 Apr 2024 11:46:13 +1000 Stephen Rothwell <sfr@canb•auug.org.au> wrote:
> >
> > After merging the dmi tree, today's linux-next build (arm
> > multi_v7_defconfig) produced this warning:
> >
> > In file included from include/asm-generic/bug.h:22,
> > from arch/arm/include/asm/bug.h:60,
> > from include/linux/bug.h:5,
> > from include/linux/thread_info.h:13,
> > from include/asm-generic/preempt.h:5,
> > from ./arch/arm/include/generated/asm/preempt.h:1,
> > from include/linux/preempt.h:79,
> > from include/linux/spinlock.h:56,
> > from include/linux/mmzone.h:8,
> > from include/linux/gfp.h:7,
> > from include/linux/umh.h:4,
> > from include/linux/kmod.h:9,
> > from include/linux/module.h:17,
> > from drivers/firmware/dmi_scan.c:5:
> > drivers/firmware/dmi_scan.c: In function 'dmi_decode_table':
> > include/linux/kern_levels.h:5:25: warning: format '%ld' expects argument of type 'long int', but argument 2 has type 'int' [-Wformat=]
> > 5 | #define KERN_SOH "\001" /* ASCII Start Of Header */
> > | ^~~~~~
> > include/linux/printk.h:429:25: note: in definition of macro 'printk_index_wrap'
> > 429 | _p_func(_fmt, ##__VA_ARGS__); \
> > | ^~~~
> > include/linux/printk.h:510:9: note: in expansion of macro 'printk'
> > 510 | printk(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__)
> > | ^~~~~~
> > include/linux/kern_levels.h:12:25: note: in expansion of macro 'KERN_SOH'
> > 12 | #define KERN_WARNING KERN_SOH "4" /* warning conditions */
> > | ^~~~~~~~
> > include/linux/printk.h:510:16: note: in expansion of macro 'KERN_WARNING'
> > 510 | printk(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__)
> > | ^~~~~~~~~~~~
> > drivers/firmware/dmi_scan.c:109:25: note: in expansion of macro 'pr_warn'
> > 109 | pr_warn(FW_BUG
> > | ^~~~~~~
> >
> > Introduced by commit
> >
> > 868577e6bfe1 ("firmware: dmi: Stop decoding on broken entry")
> >
> > Include printk.h?
>
> This caused i386 defconfig build fail, so I have reverted this commit
> for today.
Sorry about that. I have amended the commit to use format %zd instead
of %ld. This passes my local user-space testing so hopefully it will
fix the i386 and armv7 builds as well.
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-03 6:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-30 1:46 linux-next: build warning after merge of the dmi tree Stephen Rothwell
2024-04-30 6:50 ` Stephen Rothwell
2024-05-03 6:57 ` Jean Delvare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox