public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
* [PATCH] kbuild: invoke generate_builtin_ranges.awk using gawk explicitly
@ 2024-09-12 17:16 Kris Van Hees
  2024-09-20  0:24 ` Masahiro Yamada
  0 siblings, 1 reply; 2+ messages in thread
From: Kris Van Hees @ 2024-09-12 17:16 UTC (permalink / raw)
  To: Masahiro Yamada
  Cc: Kris Van Hees, Stephen Rothwell, Linux Kernel Mailing List,
	Linux Next Mailing List

The gawk utility might be installed in different locations depending
on the distributions, etc.  That means that the locations in the
shebang at the beginning of the generate_builtin_ranges.awk script
may not be correct, causing an error.

Use "gawk -f <script> <args>" instead from the Makefile.vmlinux, so
the $PATH will be used to locate gawk appropriately.

Signed-off-by: Kris Van Hees <kris.van.hees@oracle•com>
---
 scripts/Makefile.vmlinux | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/Makefile.vmlinux b/scripts/Makefile.vmlinux
index dfb408aa19c6..1284f05555b9 100644
--- a/scripts/Makefile.vmlinux
+++ b/scripts/Makefile.vmlinux
@@ -39,7 +39,7 @@ ifdef CONFIG_BUILTIN_MODULE_RANGES
 __default: modules.builtin.ranges
 
 quiet_cmd_modules_builtin_ranges = GEN     $@
-      cmd_modules_builtin_ranges = $(real-prereqs) > $@
+      cmd_modules_builtin_ranges = gawk -f $(real-prereqs) > $@
 
 targets += modules.builtin.ranges
 modules.builtin.ranges: $(srctree)/scripts/generate_builtin_ranges.awk \
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] kbuild: invoke generate_builtin_ranges.awk using gawk explicitly
  2024-09-12 17:16 [PATCH] kbuild: invoke generate_builtin_ranges.awk using gawk explicitly Kris Van Hees
@ 2024-09-20  0:24 ` Masahiro Yamada
  0 siblings, 0 replies; 2+ messages in thread
From: Masahiro Yamada @ 2024-09-20  0:24 UTC (permalink / raw)
  To: Kris Van Hees
  Cc: Stephen Rothwell, Linux Kernel Mailing List,
	Linux Next Mailing List

On Fri, Sep 13, 2024 at 2:17 AM Kris Van Hees <kris.van.hees@oracle•com> wrote:
>
> The gawk utility might be installed in different locations depending
> on the distributions, etc.  That means that the locations in the
> shebang at the beginning of the generate_builtin_ranges.awk script
> may not be correct, causing an error.
>
> Use "gawk -f <script> <args>" instead from the Makefile.vmlinux, so
> the $PATH will be used to locate gawk appropriately.
>
> Signed-off-by: Kris Van Hees <kris.van.hees@oracle•com>
> ---
>  scripts/Makefile.vmlinux | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/Makefile.vmlinux b/scripts/Makefile.vmlinux
> index dfb408aa19c6..1284f05555b9 100644
> --- a/scripts/Makefile.vmlinux
> +++ b/scripts/Makefile.vmlinux
> @@ -39,7 +39,7 @@ ifdef CONFIG_BUILTIN_MODULE_RANGES
>  __default: modules.builtin.ranges
>
>  quiet_cmd_modules_builtin_ranges = GEN     $@
> -      cmd_modules_builtin_ranges = $(real-prereqs) > $@
> +      cmd_modules_builtin_ranges = gawk -f $(real-prereqs) > $@
>
>  targets += modules.builtin.ranges
>  modules.builtin.ranges: $(srctree)/scripts/generate_builtin_ranges.awk \
> --
> 2.45.2
>

I squashed this to v10 2/4.
Thanks!


-- 
Best Regards
Masahiro Yamada

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-09-20  0:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-12 17:16 [PATCH] kbuild: invoke generate_builtin_ranges.awk using gawk explicitly Kris Van Hees
2024-09-20  0:24 ` Masahiro Yamada

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox