From: Brahmajit Das <brahmajit.xyz@gmail•com>
To: akpm@linux-foundation•org, david@redhat•com, gorcunov@openvz•org
Cc: linux-next@vger•kernel.org
Subject: [PATCH 1/1] fs: proc: Fix build with GCC 15 due to -Werror=unterminated-string-initialization
Date: Wed, 2 Oct 2024 13:35:34 +0530 [thread overview]
Message-ID: <20241002080534.835250-1-brahmajit.xyz@gmail.com> (raw)
GCC 15 enables -Werror=unterminated-string-initialization by default.
This results in the following build error/s
fs/proc/task_mmu.c:917:49: error: initializer-string for array of ‘char’ is too long [-Werror=unterminate d-string-initialization]
917 | [0 ... (BITS_PER_LONG-1) + 1] = "??",
| ^~~~
fs/proc/task_mmu.c:917:49: error: initializer-string for array of ‘char’ is too long [-Werror=unterminate d-string-initialization]
fs/proc/task_mmu.c:917:49: error: initializer-string for array of ‘char’ is too long [-Werror=unterminate d-string-initialization]
fs/proc/task_mmu.c:917:49: error: initializer-string for array of ‘char’ is too long [-Werror=unterminate d-string-initialization]
fs/proc/task_mmu.c:917:49: error: initializer-string for array of ‘char’ is too long [-Werror=unterminate d-string-initialization]
fs/proc/task_mmu.c:917:49: error: initializer-string for array of ‘char’ is too long [-Werror=unterminate d-string-initialization]
...
To fix this, the length of the second argument of arary mnemonics needs
to be 3 instead of previously set 2 (i.e. from [BITS_PER_LONG][2] to
[BITS_PER_LONG][3])
Signed-off-by: Brahmajit Das <brahmajit.xyz@gmail•com>
---
fs/proc/task_mmu.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
index 72f14fd59c2d..aa5780696fc1 100644
--- a/fs/proc/task_mmu.c
+++ b/fs/proc/task_mmu.c
@@ -909,8 +909,15 @@ static void show_smap_vma_flags(struct seq_file *m, struct vm_area_struct *vma)
{
/*
* Don't forget to update Documentation/ on changes.
+ *
+ * The length of the second argument of arary mnemonics
+ * needs to be 3 instead of previously set 2
+ * (i.e. from [BITS_PER_LONG][2] to [BITS_PER_LONG][3])
+ * to avoid spurious
+ * -Werror=unterminated-string-initialization warning
+ * with GCC 15
*/
- static const char mnemonics[BITS_PER_LONG][2] = {
+ static const char mnemonics[BITS_PER_LONG][3] = {
/*
* In case if we meet a flag we don't know about.
*/
--
2.46.2
next reply other threads:[~2024-10-02 8:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 8:05 Brahmajit Das [this message]
2024-10-02 8:09 ` [PATCH v2 1/1] fs: proc: Fix build with GCC 15 due to -Werror=unterminated-string-initialization Brahmajit Das
2024-10-02 21:48 ` Andrew Morton
2024-10-02 23:30 ` Stephen Rothwell
2024-10-02 23:39 ` Stephen Rothwell
2024-10-04 20:16 ` Brahmajit
2024-10-04 21:12 ` Brahmajit
2024-10-04 21:58 ` Andrew Morton
2024-10-05 6:37 ` [PATCH v3 1/1] fs/proc: " Brahmajit Das
2024-10-08 2:08 ` Andrew Morton
2024-10-28 8:02 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241002080534.835250-1-brahmajit.xyz@gmail.com \
--to=brahmajit.xyz@gmail$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=david@redhat$(echo .)com \
--cc=gorcunov@openvz$(echo .)org \
--cc=linux-next@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox