From: Herve Codina <herve.codina@bootlin•com>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: Philipp Zabel <p.zabel@pengutronix•de>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Linux Next Mailing List <linux-next@vger•kernel.org>,
Rob Herring <robh@kernel•org>
Subject: Re: linux-next: build warning after merge of the reset tree
Date: Fri, 25 Oct 2024 08:28:17 +0200 [thread overview]
Message-ID: <20241025082817.28056f52@bootlin.com> (raw)
In-Reply-To: <20241025110919.64b1cffb@canb.auug.org.au>
Hi all,
On Fri, 25 Oct 2024 11:09:19 +1100
Stephen Rothwell <sfr@canb•auug.org.au> wrote:
> Hi all,
>
> After merging the reset tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/misc/lan966x_pci.dtso:34.23-40.7: Warning (interrupts_property): /fragment@0/__overlay__/pci-ep-bus@0/oic@e00c0120: Missing interrupt-parent
>
> Introduced by commit
>
> 185686beb464 ("misc: Add support for LAN966x PCI device")
>
This warning is normal.
interrupt-parent is not present in the oic node. This was discussed in
https://lore.kernel.org/all/CAL_Jsq+je7+9ATR=B6jXHjEJHjn24vQFs4Tvi9=vhDeK9n42Aw@mail.gmail.com/
interrupt-parent is not mandatory for a node and if interrupt-parent is not
present, the interrupt parent resolution code will look at the parent node
recursively until an interrupt-parent or an interrupt controller is found.
https://elixir.bootlin.com/linux/v6.12-rc1/source/drivers/of/irq.c#L56
In the LAN966x PCI case, this goes up to the PCI device which is itself an
interrupt controller. This interrupt controller is not described in the dtso
because it is the node where the dtso is applied.
The LAN966x PCI device DT node has the #interrupt-cells and the
interrupt-controller properties. This build at runtime:
https://elixir.bootlin.com/linux/v6.12-rc1/source/drivers/pci/of_property.c#L186
Best regards,
Hervé
--
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2024-10-25 6:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 0:09 linux-next: build warning after merge of the reset tree Stephen Rothwell
2024-10-25 6:28 ` Herve Codina [this message]
2024-10-25 13:44 ` Rob Herring
2024-10-25 14:46 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241025082817.28056f52@bootlin.com \
--to=herve.codina@bootlin$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=p.zabel@pengutronix$(echo .)de \
--cc=robh@kernel$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox