* linux-next: build warning after merge of the reset tree
@ 2024-10-25 0:09 Stephen Rothwell
2024-10-25 6:28 ` Herve Codina
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2024-10-25 0:09 UTC (permalink / raw)
To: Philipp Zabel
Cc: Herve Codina, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 386 bytes --]
Hi all,
After merging the reset tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/misc/lan966x_pci.dtso:34.23-40.7: Warning (interrupts_property): /fragment@0/__overlay__/pci-ep-bus@0/oic@e00c0120: Missing interrupt-parent
Introduced by commit
185686beb464 ("misc: Add support for LAN966x PCI device")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: linux-next: build warning after merge of the reset tree
2024-10-25 0:09 linux-next: build warning after merge of the reset tree Stephen Rothwell
@ 2024-10-25 6:28 ` Herve Codina
2024-10-25 13:44 ` Rob Herring
0 siblings, 1 reply; 4+ messages in thread
From: Herve Codina @ 2024-10-25 6:28 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Philipp Zabel, Linux Kernel Mailing List, Linux Next Mailing List,
Rob Herring
Hi all,
On Fri, 25 Oct 2024 11:09:19 +1100
Stephen Rothwell <sfr@canb•auug.org.au> wrote:
> Hi all,
>
> After merging the reset tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/misc/lan966x_pci.dtso:34.23-40.7: Warning (interrupts_property): /fragment@0/__overlay__/pci-ep-bus@0/oic@e00c0120: Missing interrupt-parent
>
> Introduced by commit
>
> 185686beb464 ("misc: Add support for LAN966x PCI device")
>
This warning is normal.
interrupt-parent is not present in the oic node. This was discussed in
https://lore.kernel.org/all/CAL_Jsq+je7+9ATR=B6jXHjEJHjn24vQFs4Tvi9=vhDeK9n42Aw@mail.gmail.com/
interrupt-parent is not mandatory for a node and if interrupt-parent is not
present, the interrupt parent resolution code will look at the parent node
recursively until an interrupt-parent or an interrupt controller is found.
https://elixir.bootlin.com/linux/v6.12-rc1/source/drivers/of/irq.c#L56
In the LAN966x PCI case, this goes up to the PCI device which is itself an
interrupt controller. This interrupt controller is not described in the dtso
because it is the node where the dtso is applied.
The LAN966x PCI device DT node has the #interrupt-cells and the
interrupt-controller properties. This build at runtime:
https://elixir.bootlin.com/linux/v6.12-rc1/source/drivers/pci/of_property.c#L186
Best regards,
Hervé
--
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: linux-next: build warning after merge of the reset tree
2024-10-25 6:28 ` Herve Codina
@ 2024-10-25 13:44 ` Rob Herring
2024-10-25 14:46 ` Philipp Zabel
0 siblings, 1 reply; 4+ messages in thread
From: Rob Herring @ 2024-10-25 13:44 UTC (permalink / raw)
To: Herve Codina
Cc: Stephen Rothwell, Philipp Zabel, Linux Kernel Mailing List,
Linux Next Mailing List
On Fri, Oct 25, 2024 at 1:28 AM Herve Codina <herve.codina@bootlin•com> wrote:
>
> Hi all,
>
> On Fri, 25 Oct 2024 11:09:19 +1100
> Stephen Rothwell <sfr@canb•auug.org.au> wrote:
>
> > Hi all,
> >
> > After merging the reset tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> >
> > drivers/misc/lan966x_pci.dtso:34.23-40.7: Warning (interrupts_property): /fragment@0/__overlay__/pci-ep-bus@0/oic@e00c0120: Missing interrupt-parent
> >
> > Introduced by commit
> >
> > 185686beb464 ("misc: Add support for LAN966x PCI device")
> >
>
> This warning is normal.
> interrupt-parent is not present in the oic node. This was discussed in
> https://lore.kernel.org/all/CAL_Jsq+je7+9ATR=B6jXHjEJHjn24vQFs4Tvi9=vhDeK9n42Aw@mail.gmail.com/
We can't have warnings especially in things outside of arch/. Doesn't
matter why.
The choices to fix are:
- Override DTC_FLAGS in drivers/misc/. You can set DTC_FLAGS_lan966x_pci
- Disable the check in dtc for overlays. We've done this for other cases.
- Add enough info into the overlay to avoid the warnings. This might
mean the overlay has to be applied up one node level. It is
duplicating a few things which are in the base tree. This is my
preference because it makes the overlay stand on its own. We'll have
the same issue with dtschema checks too if we don't do this.
Rob
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: linux-next: build warning after merge of the reset tree
2024-10-25 13:44 ` Rob Herring
@ 2024-10-25 14:46 ` Philipp Zabel
0 siblings, 0 replies; 4+ messages in thread
From: Philipp Zabel @ 2024-10-25 14:46 UTC (permalink / raw)
To: Rob Herring, Herve Codina
Cc: Stephen Rothwell, Linux Kernel Mailing List,
Linux Next Mailing List
On Fr, 2024-10-25 at 08:44 -0500, Rob Herring wrote:
> On Fri, Oct 25, 2024 at 1:28 AM Herve Codina <herve.codina@bootlin•com> wrote:
> >
> > Hi all,
> >
> > On Fri, 25 Oct 2024 11:09:19 +1100
> > Stephen Rothwell <sfr@canb•auug.org.au> wrote:
> >
> > > Hi all,
> > >
> > > After merging the reset tree, today's linux-next build (x86_64
> > > allmodconfig) produced this warning:
> > >
> > > drivers/misc/lan966x_pci.dtso:34.23-40.7: Warning (interrupts_property): /fragment@0/__overlay__/pci-ep-bus@0/oic@e00c0120: Missing interrupt-parent
> > >
> > > Introduced by commit
> > >
> > > 185686beb464 ("misc: Add support for LAN966x PCI device")
> > >
> >
> > This warning is normal.
> > interrupt-parent is not present in the oic node. This was discussed in
> > https://lore.kernel.org/all/CAL_Jsq+je7+9ATR=B6jXHjEJHjn24vQFs4Tvi9=vhDeK9n42Aw@mail.gmail.com/
>
> We can't have warnings especially in things outside of arch/. Doesn't
> matter why.
>
> The choices to fix are:
>
> - Override DTC_FLAGS in drivers/misc/. You can set DTC_FLAGS_lan966x_pci
>
> - Disable the check in dtc for overlays. We've done this for other cases.
>
> - Add enough info into the overlay to avoid the warnings. This might
> mean the overlay has to be applied up one node level. It is
> duplicating a few things which are in the base tree. This is my
> preference because it makes the overlay stand on its own. We'll have
> the same issue with dtschema checks too if we don't do this.
I see four more warnings that look like false positives to me:
drivers/misc/lan966x_pci.dtso:42.22-46.7: Warning (simple_bus_reg): /fragment@0/__overlay__/pci-ep-bus@0/cpu_clk: missing or empty reg/ranges property
drivers/misc/lan966x_pci.dtso:48.22-52.7: Warning (simple_bus_reg): /fragment@0/__overlay__/pci-ep-bus@0/ddr_clk: missing or empty reg/ranges property
drivers/misc/lan966x_pci.dtso:54.22-58.7: Warning (simple_bus_reg): /fragment@0/__overlay__/pci-ep-bus@0/sys_clk: missing or empty reg/ranges property
drivers/misc/lan966x_pci.dtso:18.15-165.5: Warning (avoid_unnecessary_addr_size): /fragment@0/__overlay__: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
Setting
DTC_FLAGS_lan966x_pci := -Wno-interrupts_property -Wno-simple_bus_reg -Wno-avoid_unnecessary_addr_size
silences them all.
regards
Philipp
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-10-25 14:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-25 0:09 linux-next: build warning after merge of the reset tree Stephen Rothwell
2024-10-25 6:28 ` Herve Codina
2024-10-25 13:44 ` Rob Herring
2024-10-25 14:46 ` Philipp Zabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox