* linux-next: build warning after merge of the sound-asoc-fixes tree
@ 2025-01-09 4:25 Stephen Rothwell
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Rothwell @ 2025-01-09 4:25 UTC (permalink / raw)
To: Mark Brown, Liam Girdwood
Cc: Richard Fitzgerald, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 351 bytes --]
Hi all,
After merging the sound-asoc-fixes tree, today's linux-next build
(htmldocs) produced this warning:
Documentation/sound/codecs/index.rst: WARNING: document isn't included in any toctree
Introduced by commit
088fb4ee17fc ("ALSA: doc: cs35l56: Add information about Cirrus Logic CS35L54/56/57")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* linux-next: build warning after merge of the sound-asoc-fixes tree
@ 2022-10-30 21:39 Stephen Rothwell
2022-10-31 1:17 ` Chen Zhongjin
2022-11-06 21:43 ` Stephen Rothwell
0 siblings, 2 replies; 6+ messages in thread
From: Stephen Rothwell @ 2022-10-30 21:39 UTC (permalink / raw)
To: Mark Brown, Liam Girdwood
Cc: Chen Zhongjin, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 411 bytes --]
Hi all,
After merging the sound-asoc-fixes tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
WARNING: modpost: sound/soc/snd-soc-core.o: section mismatch in reference: init_module (section: .init.text) -> snd_soc_util_exit (section: .exit.text)
Introduced by commit
6ec27c53886c ("ASoC: core: Fix use-after-free in snd_soc_exit()")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: linux-next: build warning after merge of the sound-asoc-fixes tree
2022-10-30 21:39 Stephen Rothwell
@ 2022-10-31 1:17 ` Chen Zhongjin
2022-11-06 21:43 ` Stephen Rothwell
1 sibling, 0 replies; 6+ messages in thread
From: Chen Zhongjin @ 2022-10-31 1:17 UTC (permalink / raw)
To: Stephen Rothwell, Mark Brown, Liam Girdwood
Cc: Linux Kernel Mailing List, Linux Next Mailing List
Hi,
On 2022/10/31 5:39, Stephen Rothwell wrote:
> Hi all,
>
> After merging the sound-asoc-fixes tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> WARNING: modpost: sound/soc/snd-soc-core.o: section mismatch in reference: init_module (section: .init.text) -> snd_soc_util_exit (section: .exit.text)
>
> Introduced by commit
>
> 6ec27c53886c ("ASoC: core: Fix use-after-free in snd_soc_exit()")
It's because I called "_exit snd_soc_util_exit()" inside "_init
snd_soc_init()".
Since snd_soc_util_exit is only used in snd_soc_init() and
snd_soc_exit(), I think it's fine to remove _exit for snd_soc_util_exit().
Could you please add this change for the patch?
diff --git a/sound/soc/soc-utils.c b/sound/soc/soc-utils.c
index a3b6df2378b4..a4dba0b751e7 100644
--- a/sound/soc/soc-utils.c
+++ b/sound/soc/soc-utils.c
@@ -264,7 +264,7 @@ int __init snd_soc_util_init(void)
return ret;
}
-void __exit snd_soc_util_exit(void)
+void snd_soc_util_exit(void)
{
platform_driver_unregister(&soc_dummy_driver);
platform_device_unregister(soc_dummy_dev);
Thanks!
Best,
Chen
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: linux-next: build warning after merge of the sound-asoc-fixes tree
2022-10-30 21:39 Stephen Rothwell
2022-10-31 1:17 ` Chen Zhongjin
@ 2022-11-06 21:43 ` Stephen Rothwell
2022-11-07 3:03 ` Chen Zhongjin
1 sibling, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2022-11-06 21:43 UTC (permalink / raw)
To: Mark Brown, Liam Girdwood
Cc: Chen Zhongjin, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 568 bytes --]
Hi Stephen,
On Mon, 31 Oct 2022 08:39:17 +1100 Stephen Rothwell <sfr@canb•auug.org.au> wrote:
>
> Hi all,
>
> After merging the sound-asoc-fixes tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> WARNING: modpost: sound/soc/snd-soc-core.o: section mismatch in reference: init_module (section: .init.text) -> snd_soc_util_exit (section: .exit.text)
>
> Introduced by commit
>
> 6ec27c53886c ("ASoC: core: Fix use-after-free in snd_soc_exit()")
I am still getting this warning.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: linux-next: build warning after merge of the sound-asoc-fixes tree
2022-11-06 21:43 ` Stephen Rothwell
@ 2022-11-07 3:03 ` Chen Zhongjin
2022-11-07 3:52 ` Stephen Rothwell
0 siblings, 1 reply; 6+ messages in thread
From: Chen Zhongjin @ 2022-11-07 3:03 UTC (permalink / raw)
To: Stephen Rothwell, Mark Brown, Liam Girdwood
Cc: Linux Kernel Mailing List, Linux Next Mailing List
Hi,
On 2022/11/7 5:43, Stephen Rothwell wrote:
> Hi Stephen,
>
> On Mon, 31 Oct 2022 08:39:17 +1100 Stephen Rothwell <sfr@canb•auug.org.au> wrote:
>> Hi all,
>>
>> After merging the sound-asoc-fixes tree, today's linux-next build (arm
>> multi_v7_defconfig) produced this warning:
>>
>> WARNING: modpost: sound/soc/snd-soc-core.o: section mismatch in reference: init_module (section: .init.text) -> snd_soc_util_exit (section: .exit.text)
>>
>> Introduced by commit
>>
>> 6ec27c53886c ("ASoC: core: Fix use-after-free in snd_soc_exit()")
> I am still getting this warning.
I compiled linux-next/master and didn't find the warning.
Also I noticed that the fix patch 06ba770a799f ("ASoC: soc-utils: Remove
__exit for snd_soc_util_exit()") is on the tree.
Have no idea what's going wrong. Could you please check whether this
fixup takes effect?
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: linux-next: build warning after merge of the sound-asoc-fixes tree
2022-11-07 3:03 ` Chen Zhongjin
@ 2022-11-07 3:52 ` Stephen Rothwell
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Rothwell @ 2022-11-07 3:52 UTC (permalink / raw)
To: Chen Zhongjin
Cc: Mark Brown, Liam Girdwood, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 1233 bytes --]
Hi Chen,
On Mon, 7 Nov 2022 11:03:39 +0800 Chen Zhongjin <chenzhongjin@huawei•com> wrote:
>
> On 2022/11/7 5:43, Stephen Rothwell wrote:
> >
> > On Mon, 31 Oct 2022 08:39:17 +1100 Stephen Rothwell <sfr@canb•auug.org.au> wrote:
> >>
> >> After merging the sound-asoc-fixes tree, today's linux-next build (arm
> >> multi_v7_defconfig) produced this warning:
> >>
> >> WARNING: modpost: sound/soc/snd-soc-core.o: section mismatch in reference: init_module (section: .init.text) -> snd_soc_util_exit (section: .exit.text)
> >>
> >> Introduced by commit
> >>
> >> 6ec27c53886c ("ASoC: core: Fix use-after-free in snd_soc_exit()")
> > I am still getting this warning.
>
> I compiled linux-next/master and didn't find the warning.
>
> Also I noticed that the fix patch 06ba770a799f ("ASoC: soc-utils: Remove __exit for snd_soc_util_exit()") is on the tree.
>
> Have no idea what's going wrong. Could you please check whether this fixup takes effect?
That fix patch is in the sound-asoc tree (and makes the warning go
away), but the patch causing the warning is in the sound-asoc-fixes
tree ... so the latter patch needs to be moved into the
sound-asoc-fixes tree.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-01-09 4:25 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-09 4:25 linux-next: build warning after merge of the sound-asoc-fixes tree Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2022-10-30 21:39 Stephen Rothwell
2022-10-31 1:17 ` Chen Zhongjin
2022-11-06 21:43 ` Stephen Rothwell
2022-11-07 3:03 ` Chen Zhongjin
2022-11-07 3:52 ` Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox