From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Paolo Bonzini <pbonzini@redhat•com>
Cc: Miguel Ojeda <ojeda@kernel•org>,
Maxim Levitsky <mlevitsk@redhat•com>, KVM <kvm@vger•kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Linux Next Mailing List <linux-next@vger•kernel.org>
Subject: Re: linux-next: build failure after merge of the kvm tree
Date: Wed, 28 May 2025 16:44:07 +1000 [thread overview]
Message-ID: <20250528164407.1d8d3948@canb.auug.org.au> (raw)
In-Reply-To: <CABgObfbCg1wiZJmnXFihmRLvPiJq2bCQH3MNVMfiUJphz4JW3g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2069 bytes --]
Hi Paolo,
On Wed, 28 May 2025 07:37:57 +0200 Paolo Bonzini <pbonzini@redhat•com> wrote:
>
> On Wed, May 28, 2025 at 7:28 AM Stephen Rothwell <sfr@canb•auug.org.au> wrote:
> >
> > After merging the kvm tree, today's linux-next build (x86_64 allmodconfig)
> > failed like this:
> >
> > error[E0425]: cannot find function `mutex_trylock` in crate `bindings`
> > --> rust/kernel/sync/lock/mutex.rs:129:41
> > |
> > 129 | let result = unsafe { bindings::mutex_trylock(ptr) };
> > | ^^^^^^^^^^^^^ help: a function with a similar name exists: `mutex_lock`
> > |
> > ::: /home/sfr/next/x86_64_allmodconfig/rust/bindings/bindings_helpers_generated.rs:265:5
> > |
> > 265 | pub fn mutex_lock(lock: *mut mutex);
> > | ------------------------------------ similarly named function `mutex_lock` defined here
> >
> > error: aborting due to 1 previous error
>
> I thought that since Rust failures wouldn't have to be fixed by
> non-Rust maintainers, they wouldn't block merging of non-Rust trees in
> linux-next?
I am sorry, but I am not sure how that is supposed to work. (Do I
disable RUST in my builds - thereby possibly missing other build
problems?) In this case you can probably not even do an allmodconfig
build of the kvm tree alone if you have rustc etc installed, right?
BTW, the only bit of the kvm tree not merged into linux-next today is
the kvm-lockdep-common topic branch that was merged overnight (my time).
> In this case it's not a problem to fix it up at all (I'll send a patch
> to Miguel as soon as I've taken the little guy to school); it's just
> to understand what's to expect.
That patch needs to go into your tree (with Miguel's Ack if necessary)
otherwise as soon as Linus merges your tree, his allmodconfig build
will be broken and he will (probably) unmerge your tree and let you
know (and wonder why I didn't pick it up).
I don't know what to tell you about expectations, sorry.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2025-05-28 6:44 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-28 5:28 linux-next: build failure after merge of the kvm tree Stephen Rothwell
2025-05-28 5:37 ` Paolo Bonzini
2025-05-28 6:44 ` Stephen Rothwell [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-05-02 6:47 Stephen Rothwell
2024-04-12 3:34 Stephen Rothwell
2024-04-12 3:35 ` Stephen Rothwell
2024-04-12 12:14 ` Paolo Bonzini
2023-11-22 2:14 Stephen Rothwell
2023-11-20 4:22 Stephen Rothwell
2023-12-11 2:50 ` Stephen Rothwell
2022-04-19 5:34 Stephen Rothwell
2022-04-19 16:01 ` Sean Christopherson
2022-04-19 16:09 ` Paolo Bonzini
2022-04-21 18:06 ` Paolo Bonzini
2022-04-27 3:23 ` Stephen Rothwell
2022-04-27 6:06 ` Paolo Bonzini
2021-02-08 5:33 Stephen Rothwell
2021-02-08 11:18 ` Yu Zhang
2021-02-05 5:02 Stephen Rothwell
2021-02-05 10:08 ` Paolo Bonzini
2021-02-07 19:48 ` Stephen Rothwell
2021-02-09 4:56 ` Stephen Rothwell
2020-07-17 5:57 Stephen Rothwell
2020-07-29 7:06 ` Stephen Rothwell
2020-05-21 6:28 Stephen Rothwell
2020-06-04 2:54 ` Stephen Rothwell
2019-02-18 3:42 Stephen Rothwell
2019-02-19 15:36 ` Sean Christopherson
2019-02-19 18:17 ` Paolo Bonzini
2018-12-19 4:33 Stephen Rothwell
2017-02-08 3:23 Stephen Rothwell
2016-12-19 1:11 Stephen Rothwell
2015-09-08 1:35 Stephen Rothwell
2015-09-08 2:10 ` Wanpeng Li
2015-09-08 9:24 ` Paolo Bonzini
2015-05-29 7:36 Stephen Rothwell
2015-05-29 7:54 ` Ingo Molnar
2015-05-29 12:08 ` Paolo Bonzini
2014-11-24 6:19 Stephen Rothwell
2014-11-24 9:38 ` Paolo Bonzini
2014-08-06 4:39 Stephen Rothwell
2014-03-11 23:55 Mark Brown
2014-01-10 3:00 Stephen Rothwell
2014-01-17 4:03 ` Stephen Rothwell
2012-08-23 3:21 Stephen Rothwell
2012-03-06 4:53 Stephen Rothwell
2012-03-06 10:34 ` Avi Kivity
2010-08-30 1:35 Stephen Rothwell
2010-08-30 10:03 ` Alexander Graf
2010-08-30 10:56 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250528164407.1d8d3948@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=kvm@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mlevitsk@redhat$(echo .)com \
--cc=ojeda@kernel$(echo .)org \
--cc=pbonzini@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox