public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed

From: SeongJae Park <sj@kernel•org>
To: Sang-Heon Jeon <ekffu200098@gmail•com>
Cc: SeongJae Park <sj@kernel•org>,
	Andrew Morton <akpm@linux-foundation•org>,
	Stephen Rothwell <sfr@canb•auug.org.au>,
	Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
	Linux Next Mailing List <linux-next@vger•kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the mm-unstable tree
Date: Mon, 18 Aug 2025 22:39:26 -0700	[thread overview]
Message-ID: <20250819053926.38696-1-sj@kernel.org> (raw)
In-Reply-To: <CABFDxMFpzS9ynd7OsJWdKwZD-kW0-nu9=HhoFUmiOm5Jkz_QzQ@mail.gmail.com>

On Tue, 19 Aug 2025 10:55:13 +0900 Sang-Heon Jeon <ekffu200098@gmail•com> wrote:

> On Tue, Aug 19, 2025 at 10:14 AM Andrew Morton
> <akpm@linux-foundation•org> wrote:
> >
> > On Tue, 19 Aug 2025 09:59:20 +0900 Sang-Heon Jeon <ekffu200098@gmail•com> wrote:
> >
> > > > has these problem(s):
> > > >
> > > >   - Target SHA1 does not exist
> > > >
> > > > Maybe you meant
> > > >
> > > > Fixes: a0b60d083fb6 ("selftests/damon: test no-op commit broke DAMON status")
> > >
> > > You're right. I think it might be changed at the point rc1 -> rc2 on
> > > the mm tree.
> > > Is there anything I can do? Or maybe Andrew can help?
> > >
> > > I didn't mean to bother you guys.  Also, original patch is from here [1]
> > >
> > > [1] https://lore.kernel.org/all/20250816014033.190451-1-ekffu200098@gmail.com/
> >
> > I deleted the Fixes: tag.  The quilt filename
> > selftests-damon-test-no-op-commit-broke-damon-status-fix.patch means
> > "this will be folded into
> > selftests-damon-test-no-op-commit-broke-damon-status.patch"
> 
> Thank you, andrew

Thank you for Cc-ing me, Sang-Heon.  Thank you for fixing this, Andrew.

I actually suggested Sang-Heon to add the Fixes: tag, to help Andrew easily
understand the context.  It didn't make noises before, but everything changes.
Anyway I'm also responsible for this noise, sorry about that.

Another common way to send followup fixes for commits in mm tree is, sending
the fixup patches as a reply to the broken patch mail thread, with a brief
explanation of the context for Andrew, like my recent one[1].  I think using
this way without Fixes: tag in the patch can still help Andrew easily
understand the context while not making noises.  Sang-Heon, please consider
using that way if you get similar cases in future.

[1] https://lore.kernel.org/20250709182843.35812-1-sj@kernel.org/


Thanks,
SJ

[...]

next prev parent reply	other threads:[~2025-08-19  5:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-18 21:23 linux-next: Fixes tag needs some work in the mm-unstable tree Stephen Rothwell
2025-08-19  0:59 ` Sang-Heon Jeon
2025-08-19  1:14   ` Andrew Morton
2025-08-19  1:55     ` Sang-Heon Jeon
2025-08-19  5:39       ` SeongJae Park [this message]
2025-08-19  6:33         ` Sang-Heon Jeon
  -- strict thread matches above, loose matches on Subject: below --
2025-09-01 22:40 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250819053926.38696-1-sj@kernel.org \
    --to=sj@kernel$(echo .)org \
    --cc=akpm@linux-foundation$(echo .)org \
    --cc=ekffu200098@gmail$(echo .)com \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=sfr@canb$(echo .)auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox