* linux-next: Fixes tag needs some work in the mm-unstable tree
@ 2025-08-18 21:23 Stephen Rothwell
2025-08-19 0:59 ` Sang-Heon Jeon
0 siblings, 1 reply; 7+ messages in thread
From: Stephen Rothwell @ 2025-08-18 21:23 UTC (permalink / raw)
To: Andrew Morton
Cc: Sang-Heon Jeon, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 393 bytes --]
Hi all,
In commit
1ce24beaff3f ("selftests/damon: change wrong json.dump usage to json.dumps")
Fixes tag
Fixes: 441f487d6ebf ("selftests/damon: test no-op commit broke DAMON status")
has these problem(s):
- Target SHA1 does not exist
Maybe you meant
Fixes: a0b60d083fb6 ("selftests/damon: test no-op commit broke DAMON status")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: linux-next: Fixes tag needs some work in the mm-unstable tree
2025-08-18 21:23 linux-next: Fixes tag needs some work in the mm-unstable tree Stephen Rothwell
@ 2025-08-19 0:59 ` Sang-Heon Jeon
2025-08-19 1:14 ` Andrew Morton
0 siblings, 1 reply; 7+ messages in thread
From: Sang-Heon Jeon @ 2025-08-19 0:59 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Andrew Morton, Linux Kernel Mailing List, Linux Next Mailing List,
SeongJae Park
Hello, Stephen
On Tue, Aug 19, 2025 at 6:24 AM Stephen Rothwell <sfr@canb•auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
> 1ce24beaff3f ("selftests/damon: change wrong json.dump usage to json.dumps")
>
> Fixes tag
>
> Fixes: 441f487d6ebf ("selftests/damon: test no-op commit broke DAMON status")
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: a0b60d083fb6 ("selftests/damon: test no-op commit broke DAMON status")
You're right. I think it might be changed at the point rc1 -> rc2 on
the mm tree.
Is there anything I can do? Or maybe Andrew can help?
I didn't mean to bother you guys. Also, original patch is from here [1]
[1] https://lore.kernel.org/all/20250816014033.190451-1-ekffu200098@gmail.com/
> --
> Cheers,
> Stephen Rothwell
Best Regards
Sang-Heon Jeon
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: linux-next: Fixes tag needs some work in the mm-unstable tree
2025-08-19 0:59 ` Sang-Heon Jeon
@ 2025-08-19 1:14 ` Andrew Morton
2025-08-19 1:55 ` Sang-Heon Jeon
0 siblings, 1 reply; 7+ messages in thread
From: Andrew Morton @ 2025-08-19 1:14 UTC (permalink / raw)
To: Sang-Heon Jeon
Cc: Stephen Rothwell, Linux Kernel Mailing List,
Linux Next Mailing List, SeongJae Park
On Tue, 19 Aug 2025 09:59:20 +0900 Sang-Heon Jeon <ekffu200098@gmail•com> wrote:
> > has these problem(s):
> >
> > - Target SHA1 does not exist
> >
> > Maybe you meant
> >
> > Fixes: a0b60d083fb6 ("selftests/damon: test no-op commit broke DAMON status")
>
> You're right. I think it might be changed at the point rc1 -> rc2 on
> the mm tree.
> Is there anything I can do? Or maybe Andrew can help?
>
> I didn't mean to bother you guys. Also, original patch is from here [1]
>
> [1] https://lore.kernel.org/all/20250816014033.190451-1-ekffu200098@gmail.com/
I deleted the Fixes: tag. The quilt filename
selftests-damon-test-no-op-commit-broke-damon-status-fix.patch means
"this will be folded into
selftests-damon-test-no-op-commit-broke-damon-status.patch"
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: linux-next: Fixes tag needs some work in the mm-unstable tree
2025-08-19 1:14 ` Andrew Morton
@ 2025-08-19 1:55 ` Sang-Heon Jeon
2025-08-19 5:39 ` SeongJae Park
0 siblings, 1 reply; 7+ messages in thread
From: Sang-Heon Jeon @ 2025-08-19 1:55 UTC (permalink / raw)
To: Andrew Morton
Cc: Stephen Rothwell, Linux Kernel Mailing List,
Linux Next Mailing List, SeongJae Park
On Tue, Aug 19, 2025 at 10:14 AM Andrew Morton
<akpm@linux-foundation•org> wrote:
>
> On Tue, 19 Aug 2025 09:59:20 +0900 Sang-Heon Jeon <ekffu200098@gmail•com> wrote:
>
> > > has these problem(s):
> > >
> > > - Target SHA1 does not exist
> > >
> > > Maybe you meant
> > >
> > > Fixes: a0b60d083fb6 ("selftests/damon: test no-op commit broke DAMON status")
> >
> > You're right. I think it might be changed at the point rc1 -> rc2 on
> > the mm tree.
> > Is there anything I can do? Or maybe Andrew can help?
> >
> > I didn't mean to bother you guys. Also, original patch is from here [1]
> >
> > [1] https://lore.kernel.org/all/20250816014033.190451-1-ekffu200098@gmail.com/
>
> I deleted the Fixes: tag. The quilt filename
> selftests-damon-test-no-op-commit-broke-damon-status-fix.patch means
> "this will be folded into
> selftests-damon-test-no-op-commit-broke-damon-status.patch"
Thank you, andrew
Best Regards
Sang-Heon Jeon
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: linux-next: Fixes tag needs some work in the mm-unstable tree
2025-08-19 1:55 ` Sang-Heon Jeon
@ 2025-08-19 5:39 ` SeongJae Park
2025-08-19 6:33 ` Sang-Heon Jeon
0 siblings, 1 reply; 7+ messages in thread
From: SeongJae Park @ 2025-08-19 5:39 UTC (permalink / raw)
To: Sang-Heon Jeon
Cc: SeongJae Park, Andrew Morton, Stephen Rothwell,
Linux Kernel Mailing List, Linux Next Mailing List
On Tue, 19 Aug 2025 10:55:13 +0900 Sang-Heon Jeon <ekffu200098@gmail•com> wrote:
> On Tue, Aug 19, 2025 at 10:14 AM Andrew Morton
> <akpm@linux-foundation•org> wrote:
> >
> > On Tue, 19 Aug 2025 09:59:20 +0900 Sang-Heon Jeon <ekffu200098@gmail•com> wrote:
> >
> > > > has these problem(s):
> > > >
> > > > - Target SHA1 does not exist
> > > >
> > > > Maybe you meant
> > > >
> > > > Fixes: a0b60d083fb6 ("selftests/damon: test no-op commit broke DAMON status")
> > >
> > > You're right. I think it might be changed at the point rc1 -> rc2 on
> > > the mm tree.
> > > Is there anything I can do? Or maybe Andrew can help?
> > >
> > > I didn't mean to bother you guys. Also, original patch is from here [1]
> > >
> > > [1] https://lore.kernel.org/all/20250816014033.190451-1-ekffu200098@gmail.com/
> >
> > I deleted the Fixes: tag. The quilt filename
> > selftests-damon-test-no-op-commit-broke-damon-status-fix.patch means
> > "this will be folded into
> > selftests-damon-test-no-op-commit-broke-damon-status.patch"
>
> Thank you, andrew
Thank you for Cc-ing me, Sang-Heon. Thank you for fixing this, Andrew.
I actually suggested Sang-Heon to add the Fixes: tag, to help Andrew easily
understand the context. It didn't make noises before, but everything changes.
Anyway I'm also responsible for this noise, sorry about that.
Another common way to send followup fixes for commits in mm tree is, sending
the fixup patches as a reply to the broken patch mail thread, with a brief
explanation of the context for Andrew, like my recent one[1]. I think using
this way without Fixes: tag in the patch can still help Andrew easily
understand the context while not making noises. Sang-Heon, please consider
using that way if you get similar cases in future.
[1] https://lore.kernel.org/20250709182843.35812-1-sj@kernel.org/
Thanks,
SJ
[...]
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: linux-next: Fixes tag needs some work in the mm-unstable tree
2025-08-19 5:39 ` SeongJae Park
@ 2025-08-19 6:33 ` Sang-Heon Jeon
0 siblings, 0 replies; 7+ messages in thread
From: Sang-Heon Jeon @ 2025-08-19 6:33 UTC (permalink / raw)
To: SeongJae Park
Cc: Andrew Morton, Stephen Rothwell, Linux Kernel Mailing List,
Linux Next Mailing List
On Tue, Aug 19, 2025 at 2:39 PM SeongJae Park <sj@kernel•org> wrote:
>
> On Tue, 19 Aug 2025 10:55:13 +0900 Sang-Heon Jeon <ekffu200098@gmail•com> wrote:
>
> > On Tue, Aug 19, 2025 at 10:14 AM Andrew Morton
> > <akpm@linux-foundation•org> wrote:
> > >
> > > On Tue, 19 Aug 2025 09:59:20 +0900 Sang-Heon Jeon <ekffu200098@gmail•com> wrote:
> > >
> > > > > has these problem(s):
> > > > >
> > > > > - Target SHA1 does not exist
> > > > >
> > > > > Maybe you meant
> > > > >
> > > > > Fixes: a0b60d083fb6 ("selftests/damon: test no-op commit broke DAMON status")
> > > >
> > > > You're right. I think it might be changed at the point rc1 -> rc2 on
> > > > the mm tree.
> > > > Is there anything I can do? Or maybe Andrew can help?
> > > >
> > > > I didn't mean to bother you guys. Also, original patch is from here [1]
> > > >
> > > > [1] https://lore.kernel.org/all/20250816014033.190451-1-ekffu200098@gmail.com/
> > >
> > > I deleted the Fixes: tag. The quilt filename
> > > selftests-damon-test-no-op-commit-broke-damon-status-fix.patch means
> > > "this will be folded into
> > > selftests-damon-test-no-op-commit-broke-damon-status.patch"
> >
> > Thank you, andrew
>
> Thank you for Cc-ing me, Sang-Heon. Thank you for fixing this, Andrew.
>
> I actually suggested Sang-Heon to add the Fixes: tag, to help Andrew easily
> understand the context. It didn't make noises before, but everything changes.
> Anyway I'm also responsible for this noise, sorry about that.
>
> Another common way to send followup fixes for commits in mm tree is, sending
> the fixup patches as a reply to the broken patch mail thread, with a brief
> explanation of the context for Andrew, like my recent one[1]. I think using
> this way without Fixes: tag in the patch can still help Andrew easily
> understand the context while not making noises. Sang-Heon, please consider
> using that way if you get similar cases in future.
Thanks for your advice. I'll use Fixes only if that commit is in the
past version. If commit is in rc, I will consider sending a patch as a
reply.
> [1] https://lore.kernel.org/20250709182843.35812-1-sj@kernel.org/
>
>
> Thanks,
> SJ
>
> [...]
Thank you to everyone. Have a nice day :)
Best Regards
Sang-Heon Jeon
^ permalink raw reply [flat|nested] 7+ messages in thread
* linux-next: Fixes tag needs some work in the mm-unstable tree
@ 2025-09-01 22:40 Stephen Rothwell
0 siblings, 0 replies; 7+ messages in thread
From: Stephen Rothwell @ 2025-09-01 22:40 UTC (permalink / raw)
To: Andrew Morton
Cc: Li Zhijian, Ruan Shiyang, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 546 bytes --]
Hi all,
In commit
447ad437698a ("mm: memory-tiering: fix PGPROMOTE_CANDIDATE counting")
Fixes tag
Fixes: c6833e10008f ("memory tiering: adjust hot threshold automatically")
has these problem(s):
- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'
Maybe you meant
Fixes: c6833e10008f ("memory tiering: rate limit NUMA migration throughput")
or
Fixes: c959924b0dc5 ("memory tiering: adjust hot threshold automatically")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2025-09-01 22:40 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-18 21:23 linux-next: Fixes tag needs some work in the mm-unstable tree Stephen Rothwell
2025-08-19 0:59 ` Sang-Heon Jeon
2025-08-19 1:14 ` Andrew Morton
2025-08-19 1:55 ` Sang-Heon Jeon
2025-08-19 5:39 ` SeongJae Park
2025-08-19 6:33 ` Sang-Heon Jeon
-- strict thread matches above, loose matches on Subject: below --
2025-09-01 22:40 Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox