From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Andrew Morton <akpm@linux-foundation•org>
Cc: Pasha Tatashin <pasha.tatashin@soleen•com>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Linux Next Mailing List <linux-next@vger•kernel.org>,
"Mike Rapoport (Microsoft)" <rppt@kernel•org>,
Pratyush Yadav <pratyush@kernel•org>
Subject: linux-next: build failure after merge of the mm-nonmm-unstable tree
Date: Mon, 17 Nov 2025 09:36:14 +1100 [thread overview]
Message-ID: <20251117093614.1490d048@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 3360 bytes --]
Hi all,
After merging the mm-nonmm-unstable tree, today's linux-next build
(powerpc ppc64_defconfig) failed like this:
In file included from drivers/of/fdt.c:28:
include/linux/kexec_handover.h:99:7: warning: no previous prototype for 'kho_alloc_preserve' [-Wmissing-prototypes]
99 | void *kho_alloc_preserve(size_t size)
| ^~~~~~~~~~~~~~~~~~
include/linux/kexec_handover.h:104:6: warning: no previous prototype for 'kho_unpreserve_free' [-Wmissing-prototypes]
104 | void kho_unpreserve_free(void *mem) { }
| ^~~~~~~~~~~~~~~~~~~
include/linux/kexec_handover.h:105:6: warning: no previous prototype for 'kho_restore_free' [-Wmissing-prototypes]
105 | void kho_restore_free(void *mem) { }
| ^~~~~~~~~~~~~~~~
In file included from mm/mm_init.c:34:
include/linux/kexec_handover.h:99:7: warning: no previous prototype for 'kho_alloc_preserve' [-Wmissing-prototypes]
99 | void *kho_alloc_preserve(size_t size)
| ^~~~~~~~~~~~~~~~~~
include/linux/kexec_handover.h:104:6: warning: no previous prototype for 'kho_unpreserve_free' [-Wmissing-prototypes]
104 | void kho_unpreserve_free(void *mem) { }
| ^~~~~~~~~~~~~~~~~~~
include/linux/kexec_handover.h:105:6: warning: no previous prototype for 'kho_restore_free' [-Wmissing-prototypes]
105 | void kho_restore_free(void *mem) { }
| ^~~~~~~~~~~~~~~~
ld: drivers/of/fdt.o: in function `kho_alloc_preserve':
fdt.c:(.text+0x9c0): multiple definition of `kho_alloc_preserve'; mm/mm_init.o:mm_init.c:(.text+0x230): first defined here
ld: drivers/of/fdt.o: in function `kho_unpreserve_free':
fdt.c:(.text+0x9d0): multiple definition of `kho_unpreserve_free'; mm/mm_init.o:mm_init.c:(.text+0x240): first defined here
ld: drivers/of/fdt.o: in function `kho_restore_free':
fdt.c:(.text+0x9e0): multiple definition of `kho_restore_free'; mm/mm_init.o:mm_init.c:(.text+0x250): first defined here
Caused by commit
722b2ce4a04f ("kho: introduce high-level memory allocation API")
I have applied the following fix patch for today:
From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Mon, 17 Nov 2025 09:29:44 +1100
Subject: [PATCH] fix up for "kho: introduce high-level memory allocation API"
Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
---
include/linux/kexec_handover.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/linux/kexec_handover.h b/include/linux/kexec_handover.h
index 6dd0dcdf0ec1..5f7b9de97e8d 100644
--- a/include/linux/kexec_handover.h
+++ b/include/linux/kexec_handover.h
@@ -96,13 +96,13 @@ static inline int kho_preserve_vmalloc(void *ptr,
static inline void kho_unpreserve_vmalloc(struct kho_vmalloc *preservation) { }
-void *kho_alloc_preserve(size_t size)
+static inline void *kho_alloc_preserve(size_t size)
{
return ERR_PTR(-EOPNOTSUPP);
}
-void kho_unpreserve_free(void *mem) { }
-void kho_restore_free(void *mem) { }
+static inline void kho_unpreserve_free(void *mem) { }
+static inline void kho_restore_free(void *mem) { }
static inline struct folio *kho_restore_folio(phys_addr_t phys)
{
--
2.51.1
As a review nitpicks on that commit: please do not do unrelated
formatting changes. Also, there was not real reason for moving the
types.h include.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2025-11-16 22:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-16 22:36 Stephen Rothwell [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-04-29 9:10 linux-next: build failure after merge of the mm-nonmm-unstable tree Thierry Reding
2026-03-17 14:32 Mark Brown
2026-03-17 15:06 ` Mathieu Desnoyers
2026-03-17 15:07 ` David CARLIER
2026-02-16 13:58 Mark Brown
2025-12-18 4:30 Stephen Rothwell
2025-12-21 2:58 ` Finn Thain
2025-12-26 16:45 ` Sasha Levin
2025-12-29 8:56 ` Finn Thain
2026-01-01 9:21 ` Finn Thain
2026-01-01 17:01 ` Randy Dunlap
2026-01-01 23:15 ` Finn Thain
2026-01-02 7:29 ` Ard Biesheuvel
2026-01-02 22:09 ` Finn Thain
2025-11-16 23:23 Stephen Rothwell
2025-11-19 23:14 ` Stephen Rothwell
2025-11-19 23:48 ` Andrew Morton
2025-11-20 8:55 ` Miguel Ojeda
2025-11-20 10:01 ` Alice Ryhl
2025-10-17 13:25 Mark Brown
2025-10-17 21:34 ` Andrew Morton
2025-09-01 1:17 Stephen Rothwell
2025-07-11 0:58 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251117093614.1490d048@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=akpm@linux-foundation$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=pasha.tatashin@soleen$(echo .)com \
--cc=pratyush@kernel$(echo .)org \
--cc=rppt@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox