From: Finn Thain <fthain@linux-m68k•org>
To: Ard Biesheuvel <ardb@kernel•org>, Peter Zijlstra <peterz@infradead•org>
Cc: Sasha Levin <sashal@kernel•org>,
Andrew Morton <akpm@linux-foundation•org>,
Will Deacon <will@kernel•org>, Arnd Bergmann <arnd@arndb•de>,
Stephen Rothwell <sfr@canb•auug.org.au>,
x86@kernel•org,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Linux Next Mailing List <linux-next@vger•kernel.org>
Subject: Re: linux-next: build failure after merge of the mm-nonmm-unstable tree
Date: Sat, 3 Jan 2026 09:09:21 +1100 (AEDT) [thread overview]
Message-ID: <cb27cd02-d439-9eb7-d393-79b399affcf7@linux-m68k.org> (raw)
In-Reply-To: <CAMj1kXFjttKG3JF=aw9KgRup-ge-WeUnncfEfTZmUVSfi4F6fg@mail.gmail.com>
On Fri, 2 Jan 2026, Ard Biesheuvel wrote:
>
> In this case, I'd prefer it if we added a helper, rather than
> duplicating the same check 3 times.
Yes, and the next patch in that series did add that helper. I didn't want
to rewrite Peter's patch and drop his authorship credit, so I added the
helper in my own patch... but being that Peter still hasn't sent a
signed-off-by tag, I should probably fold those patches together and take
the authorship credit/blame myself.
> But in this check, testing for __DISABLE_EXPORTS is perfectly
> reasonable: it is already used in this manner across architectures.
>
I think Sasha's objection was valid, in that bug table entries are said to
be emitted, whereas symbols and interfaces are exported (and imported).
But I agree that he may have overlooked the precendent for such use/abuse
of that macro e.g. in arch/x86/include/asm/ibt.h.
Ard, what do you think about __DISABLE_BUG_TABLE? Shall I change it back
to __DISABLE_EXPORTS if/when I resubmit this series? I'm ambivalent about
it.
next prev parent reply other threads:[~2026-01-02 22:09 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-18 4:30 linux-next: build failure after merge of the mm-nonmm-unstable tree Stephen Rothwell
2025-12-21 2:58 ` Finn Thain
2025-12-26 16:45 ` Sasha Levin
2025-12-29 8:56 ` Finn Thain
2026-01-01 9:21 ` Finn Thain
2026-01-01 17:01 ` Randy Dunlap
2026-01-01 23:15 ` Finn Thain
2026-01-02 7:29 ` Ard Biesheuvel
2026-01-02 22:09 ` Finn Thain [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-04-29 9:10 Thierry Reding
2026-03-17 14:32 Mark Brown
2026-03-17 15:06 ` Mathieu Desnoyers
2026-03-17 15:07 ` David CARLIER
2026-02-16 13:58 Mark Brown
2025-11-16 23:23 Stephen Rothwell
2025-11-19 23:14 ` Stephen Rothwell
2025-11-19 23:48 ` Andrew Morton
2025-11-20 8:55 ` Miguel Ojeda
2025-11-20 10:01 ` Alice Ryhl
2025-11-16 22:36 Stephen Rothwell
2025-10-17 13:25 Mark Brown
2025-10-17 21:34 ` Andrew Morton
2025-09-01 1:17 Stephen Rothwell
2025-07-11 0:58 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb27cd02-d439-9eb7-d393-79b399affcf7@linux-m68k.org \
--to=fthain@linux-m68k$(echo .)org \
--cc=akpm@linux-foundation$(echo .)org \
--cc=ardb@kernel$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=peterz@infradead$(echo .)org \
--cc=sashal@kernel$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=will@kernel$(echo .)org \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox