From: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
To: "Dominik Karol Piątkowski" <dominik.karol.piatkowski@protonmail•com>
Cc: Mark Brown <broonie@kernel•org>,
Hongling Zeng <zhongling0719@126•com>,
Hongling Zeng <zenghongling@kylinos•cn>,
"linux-next@vger•kernel.org" <linux-next@vger•kernel.org>,
"stable@vger•kernel.org" <stable@vger•kernel.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>
Subject: Re: [REGRESSION] Introduced double release_region in gpib/cb7210
Date: Sat, 30 May 2026 12:29:34 +0200 [thread overview]
Message-ID: <2026053027-follow-hurried-162b@gregkh> (raw)
In-Reply-To: <PpNUbGhrvT8I_KayoDvQYI2PYjmMw1QEkuVBDZz2PwBsVVgPkBXJarc2mBM0IhiH3AQG0GtgqEsDRXNj3yUKEDBaZa25u73pAjvcE6vfRsg=@protonmail.com>
On Fri, May 29, 2026 at 07:23:14PM +0000, Dominik Karol Piątkowski wrote:
> Hi,
>
> There are currently two patches [1][2] called:
>
> gpib: cb7210: Fix region leak when request_irq fails
>
> in linux-next that came from char-misc-next. Patch [1] introduces double
> release_region (if cb_isa_attach fails, cb_isa_detach is called and it already
> takes care of cleanup) and patch [2] introduces release_region on region we
> never obtained.
>
> cb_isa_attach is set as attach and cb_isa_detach is set as detach in
> cb_isa_(un)accel_interface and cb_isa_interface. The only place where I see
> attach is called, is in common/iblib.c, in ibonline function. If attach fails
> there, detach is called, where a proper cleanup is performed (and it includes
> things like nec7210_board_reset for cb7120). AFAIK, the same approach is used
> for the rest of gpib.
>
> Please revert these patches.
>
> Additionally, patch [2] was cc'd to stable@vger•kernel.org - hence adding it
> to cc for this email as well.
>
> Thanks,
> Dominik Karol
>
>
> [1] https://patch.msgid.link/20260503093036.283546-1-zenghongling@kylinos.cn
> [2] https://patch.msgid.link/20260518022939.16881-1-zenghongling@kylinos.cn
>
Now reverted
prev parent reply other threads:[~2026-05-30 10:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-29 19:23 [REGRESSION] Introduced double release_region in gpib/cb7210 Dominik Karol Piątkowski
2026-05-30 10:29 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026053027-follow-hurried-162b@gregkh \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=broonie@kernel$(echo .)org \
--cc=dominik.karol.piatkowski@protonmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=stable@vger$(echo .)kernel.org \
--cc=zenghongling@kylinos$(echo .)cn \
--cc=zhongling0719@126$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox