* [REGRESSION] Introduced double release_region in gpib/cb7210
@ 2026-05-29 19:23 Dominik Karol Piątkowski
2026-05-30 10:29 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Karol Piątkowski @ 2026-05-29 19:23 UTC (permalink / raw)
To: Mark Brown, Greg Kroah-Hartman, Hongling Zeng, Hongling Zeng
Cc: linux-next@vger•kernel.org, stable@vger•kernel.org,
linux-kernel@vger•kernel.org
Hi,
There are currently two patches [1][2] called:
gpib: cb7210: Fix region leak when request_irq fails
in linux-next that came from char-misc-next. Patch [1] introduces double
release_region (if cb_isa_attach fails, cb_isa_detach is called and it already
takes care of cleanup) and patch [2] introduces release_region on region we
never obtained.
cb_isa_attach is set as attach and cb_isa_detach is set as detach in
cb_isa_(un)accel_interface and cb_isa_interface. The only place where I see
attach is called, is in common/iblib.c, in ibonline function. If attach fails
there, detach is called, where a proper cleanup is performed (and it includes
things like nec7210_board_reset for cb7120). AFAIK, the same approach is used
for the rest of gpib.
Please revert these patches.
Additionally, patch [2] was cc'd to stable@vger•kernel.org - hence adding it
to cc for this email as well.
Thanks,
Dominik Karol
[1] https://patch.msgid.link/20260503093036.283546-1-zenghongling@kylinos.cn
[2] https://patch.msgid.link/20260518022939.16881-1-zenghongling@kylinos.cn
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [REGRESSION] Introduced double release_region in gpib/cb7210
2026-05-29 19:23 [REGRESSION] Introduced double release_region in gpib/cb7210 Dominik Karol Piątkowski
@ 2026-05-30 10:29 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2026-05-30 10:29 UTC (permalink / raw)
To: Dominik Karol Piątkowski
Cc: Mark Brown, Hongling Zeng, Hongling Zeng,
linux-next@vger•kernel.org, stable@vger•kernel.org,
linux-kernel@vger•kernel.org
On Fri, May 29, 2026 at 07:23:14PM +0000, Dominik Karol Piątkowski wrote:
> Hi,
>
> There are currently two patches [1][2] called:
>
> gpib: cb7210: Fix region leak when request_irq fails
>
> in linux-next that came from char-misc-next. Patch [1] introduces double
> release_region (if cb_isa_attach fails, cb_isa_detach is called and it already
> takes care of cleanup) and patch [2] introduces release_region on region we
> never obtained.
>
> cb_isa_attach is set as attach and cb_isa_detach is set as detach in
> cb_isa_(un)accel_interface and cb_isa_interface. The only place where I see
> attach is called, is in common/iblib.c, in ibonline function. If attach fails
> there, detach is called, where a proper cleanup is performed (and it includes
> things like nec7210_board_reset for cb7120). AFAIK, the same approach is used
> for the rest of gpib.
>
> Please revert these patches.
>
> Additionally, patch [2] was cc'd to stable@vger•kernel.org - hence adding it
> to cc for this email as well.
>
> Thanks,
> Dominik Karol
>
>
> [1] https://patch.msgid.link/20260503093036.283546-1-zenghongling@kylinos.cn
> [2] https://patch.msgid.link/20260518022939.16881-1-zenghongling@kylinos.cn
>
Now reverted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-30 10:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-29 19:23 [REGRESSION] Introduced double release_region in gpib/cb7210 Dominik Karol Piątkowski
2026-05-30 10:29 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox