* linux-next: xfs tree build failure
@ 2009-07-03 0:05 Stephen Rothwell
2009-07-03 2:35 ` [PATCH] un-static xfs_read_agf Eric Sandeen
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Rothwell @ 2009-07-03 0:05 UTC (permalink / raw)
To: David Chinner, xfs-masters
Cc: linux-next, linux-kernel, Eric Sandeen, Christoph Hellwig,
Felix Blyakher
[-- Attachment #1: Type: text/plain, Size: 520 bytes --]
Hi David,
Today's linux-next build (x86_64 allmodconfig) failed like this:
fs/xfs/xfs_log_recover.c: In function 'xlog_recover_check_summary':
fs/xfs/xfs_log_recover.c:4046: error: implicit declaration of function 'xfs_read_agf'
Caused by commit 370f048214b4e9aa2102fa3c454ae1374da287c5 ("xfs: add more
statics & drop some unused functions").
I have used the xfs tree from next-20090702 for today.
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] un-static xfs_read_agf
2009-07-03 0:05 linux-next: xfs tree build failure Stephen Rothwell
@ 2009-07-03 2:35 ` Eric Sandeen
2009-07-03 4:45 ` Felix Blyakher
0 siblings, 1 reply; 3+ messages in thread
From: Eric Sandeen @ 2009-07-03 2:35 UTC (permalink / raw)
To: Stephen Rothwell
Cc: David Chinner, xfs-masters, linux-next, linux-kernel,
Christoph Hellwig, Felix Blyakher
CONFIG_XFS_DEBUG builds still need xfs_read_agf to be
non-static, oops.
Signed-off-by: Eric Sandeen <sandeen@sandeen•net>
---
Index: linux-2.6/fs/xfs/xfs_ag.h
===================================================================
--- linux-2.6.orig/fs/xfs/xfs_ag.h
+++ linux-2.6/fs/xfs/xfs_ag.h
@@ -91,6 +91,9 @@ typedef struct xfs_agf {
#define XFS_AGF_BLOCK(mp) XFS_HDR_BLOCK(mp, XFS_AGF_DADDR(mp))
#define XFS_BUF_TO_AGF(bp) ((xfs_agf_t *)XFS_BUF_PTR(bp))
+extern int xfs_read_agf(struct xfs_mount *mp, struct xfs_trans *tp,
+ xfs_agnumber_t agno, int flags, struct xfs_buf **bpp);
+
/*
* Size of the unlinked inode hash table in the agi.
*/
Index: linux-2.6/fs/xfs/xfs_alloc.c
===================================================================
--- linux-2.6.orig/fs/xfs/xfs_alloc.c
+++ linux-2.6/fs/xfs/xfs_alloc.c
@@ -2248,7 +2248,7 @@ xfs_alloc_put_freelist(
/*
* Read in the allocation group header (free/alloc section).
*/
-STATIC int /* error */
+int /* error */
xfs_read_agf(
struct xfs_mount *mp, /* mount point structure */
struct xfs_trans *tp, /* transaction pointer */
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] un-static xfs_read_agf
2009-07-03 2:35 ` [PATCH] un-static xfs_read_agf Eric Sandeen
@ 2009-07-03 4:45 ` Felix Blyakher
0 siblings, 0 replies; 3+ messages in thread
From: Felix Blyakher @ 2009-07-03 4:45 UTC (permalink / raw)
To: Eric Sandeen
Cc: Stephen Rothwell, David Chinner, xfs-masters, linux-next,
linux-kernel, Christoph Hellwig
On Jul 2, 2009, at 9:35 PM, Eric Sandeen wrote:
> CONFIG_XFS_DEBUG builds still need xfs_read_agf to be
> non-static, oops.
>
> Signed-off-by: Eric Sandeen <sandeen@sandeen•net>
Reviewed-by: Felix Blyakher <felixb@sgi•com>
>
> ---
>
> Index: linux-2.6/fs/xfs/xfs_ag.h
> ===================================================================
> --- linux-2.6.orig/fs/xfs/xfs_ag.h
> +++ linux-2.6/fs/xfs/xfs_ag.h
> @@ -91,6 +91,9 @@ typedef struct xfs_agf {
> #define XFS_AGF_BLOCK(mp) XFS_HDR_BLOCK(mp, XFS_AGF_DADDR(mp))
> #define XFS_BUF_TO_AGF(bp) ((xfs_agf_t *)XFS_BUF_PTR(bp))
>
> +extern int xfs_read_agf(struct xfs_mount *mp, struct xfs_trans *tp,
> + xfs_agnumber_t agno, int flags, struct xfs_buf **bpp);
> +
> /*
> * Size of the unlinked inode hash table in the agi.
> */
> Index: linux-2.6/fs/xfs/xfs_alloc.c
> ===================================================================
> --- linux-2.6.orig/fs/xfs/xfs_alloc.c
> +++ linux-2.6/fs/xfs/xfs_alloc.c
> @@ -2248,7 +2248,7 @@ xfs_alloc_put_freelist(
> /*
> * Read in the allocation group header (free/alloc section).
> */
> -STATIC int /* error */
> +int /* error */
> xfs_read_agf(
> struct xfs_mount *mp, /* mount point structure */
> struct xfs_trans *tp, /* transaction pointer */
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-07-03 4:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-03 0:05 linux-next: xfs tree build failure Stephen Rothwell
2009-07-03 2:35 ` [PATCH] un-static xfs_read_agf Eric Sandeen
2009-07-03 4:45 ` Felix Blyakher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox