From: Tejun Heo <tj@kernel•org>
To: Christoph Lameter <cl@linux-foundation•org>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
Rusty Russell <rusty@rustcorp•com.au>,
Ingo Molnar <mingo@elte•hu>,
linux-next@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH] this_cpu: Use this_cpu_xx in trace_functions_graph.c
Date: Tue, 13 Oct 2009 23:47:51 +0900 [thread overview]
Message-ID: <4AD49317.6080503@kernel.org> (raw)
In-Reply-To: <alpine.DEB.1.10.0910131035450.11413@gentwo.org>
Christoph Lameter wrote:
> On Tue, 13 Oct 2009, Tejun Heo wrote:
>
>> ftrace_cpu_disabled usage in trace_functions_graph.c were left out
>> during this_cpu_xx conversion in commit 9288f99a causing compile
>> failure. Convert them.
>
> Thanks.
>
> Reviewed-by: Christoph Lameter <cl@linux-foundation•org>
Oh... one question tho. I used __this_cpu_*() as other conversions
but I think we should be using the version without the underscores.
The relationship between get_cpu_var() and __get_cpu_var() is
different from the one between this_cpu_*() and __this_cpu_*().
Thanks.
--
tejun
next prev parent reply other threads:[~2009-10-13 14:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-13 3:48 linux-next: percpu tree build failure Stephen Rothwell
2009-10-13 14:29 ` [PATCH] this_cpu: Use this_cpu_xx in trace_functions_graph.c Tejun Heo
2009-10-13 14:36 ` Christoph Lameter
2009-10-13 14:47 ` Tejun Heo [this message]
2009-10-13 14:45 ` Christoph Lameter
2009-10-13 14:57 ` Tejun Heo
2009-10-13 15:14 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AD49317.6080503@kernel.org \
--to=tj@kernel$(echo .)org \
--cc=cl@linux-foundation$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mingo@elte$(echo .)hu \
--cc=rusty@rustcorp$(echo .)com.au \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox