public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed

From: Phillip Lougher <phillip@lougher•demon.co.uk>
To: Randy Dunlap <randy.dunlap@oracle•com>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
	linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
	Michal Marek <mmarek@suse•cz>, akpm <akpm@linux-foundation•org>
Subject: Re: [PATCH -next] libs: force lzma_wrapper to be retained
Date: Sun, 03 Jan 2010 00:55:55 +0000	[thread overview]
Message-ID: <4B3FEB1B.7040106@lougher.demon.co.uk> (raw)
In-Reply-To: <20100101183344.398f2538.randy.dunlap@oracle.com>

Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle•com>
> 
> When CONFIG_SQUASHFS=m and CONFIG_DECOMPRESS_LZMA=m, decompress_lzma
> is built but then discarded from the library because no built-in code
> uses it, so change it from a lib- to an obj- to force it to be kept
> in the library.
> 
> ERROR: "unlzma" [fs/squashfs/squashfs.ko] undefined!
> 

Thanks for fixing this, I should have spotted it in my various
config tests but didn't.  I could add this to my squashfs-next patches
to stop the linux-next tree breakage, however, should it go into
Michal's kbuild -next tree instead?

This patch raises a small additional issue, why is DECOMPRESS_LZMA
(and DECOMPRESS_GZIP/DECOMPRESS_BZIP2) and defined as tristate?
None of the above compressors can be built as modules.

Regards

Phillip

next prev parent reply	other threads:[~2010-01-03  0:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-01  1:07 linux-next: Tree for January 1 Stephen Rothwell
2010-01-02  2:33 ` [PATCH -next] libs: force lzma_wrapper to be retained Randy Dunlap
2010-01-03  0:55   ` Phillip Lougher [this message]
2010-01-04  4:42     ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B3FEB1B.7040106@lougher.demon.co.uk \
    --to=phillip@lougher$(echo .)demon.co.uk \
    --cc=akpm@linux-foundation$(echo .)org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=mmarek@suse$(echo .)cz \
    --cc=randy.dunlap@oracle$(echo .)com \
    --cc=sfr@canb$(echo .)auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox