From: Randy Dunlap <randy.dunlap@oracle•com>
To: ebiederm@xmission•com
Cc: Greg KH <gregkh@suse•de>,
linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
Stephen Rothwell <sfr@canb•auug.org.au>
Subject: Re: [PATCH] sysfs: Don't use enums in inline function declaration.
Date: Wed, 05 May 2010 15:05:59 -0700 [thread overview]
Message-ID: <4BE1EBC7.4040204@oracle.com> (raw)
In-Reply-To: <m18w7y10cn.fsf_-_@fess.ebiederm.org>
On 05/05/10 14:54, ebiederm@xmission•com wrote:
>
> It appears gcc can't cope with using an enum that is only declared in
> an inline function declaration, that doesn't even use the variable
> that is so declared.
>
> Avoid the silliness and replace the enum with an int, and make gcc
> happy.
>
> Signed-off-by: Eric W. Biederman <ebiederm@aristanetworks•com>
Acked-by: Randy Dunlap <randy.dunlap@oracle•com>
Thanks, Eric.
> ---
> include/linux/sysfs.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h
> index e58ca1c..17cbeb7 100644
> --- a/include/linux/sysfs.h
> +++ b/include/linux/sysfs.h
> @@ -318,7 +318,7 @@ static inline void sysfs_put(struct sysfs_dirent *sd)
> {
> }
>
> -static inline void sysfs_exit_ns(enum kobj_ns_type type, const void *tag)
> +static inline void sysfs_exit_ns(int type, const void *tag)
> {
> }
>
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2010-05-05 22:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-30 6:35 linux-next: Tree for April 30 Stephen Rothwell
2010-04-30 17:50 ` linux-next: Tree for April 30 (CONFIG_SYSFS=n) Randy Dunlap
2010-05-05 16:17 ` Randy Dunlap
2010-05-05 16:24 ` Greg KH
2010-05-05 21:35 ` Eric W. Biederman
2010-05-05 21:54 ` [PATCH] sysfs: Don't use enums in inline function declaration Eric W. Biederman
2010-05-05 22:05 ` Randy Dunlap [this message]
2010-04-30 19:27 ` linux-next: Tree for April 30 Frederic Weisbecker
2010-05-03 7:29 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BE1EBC7.4040204@oracle.com \
--to=randy.dunlap@oracle$(echo .)com \
--cc=ebiederm@xmission$(echo .)com \
--cc=gregkh@suse$(echo .)de \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox