From: Mauro Carvalho Chehab <mchehab@redhat•com>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: Randy Dunlap <rdunlap@xenotime•net>,
Paul Gortmaker <paul.gortmaker@windriver•com>,
linux-next@vger•kernel.org, linux-media@vger•kernel.org
Subject: Re: [PATCH] drivers/media: fix dependencies in video mt9t001/mt9p031
Date: Sat, 08 Oct 2011 07:52:57 -0300 [thread overview]
Message-ID: <4E902B89.7030004@redhat.com> (raw)
In-Reply-To: <20111006140214.b64b22b77f2f831442d59794@canb.auug.org.au>
Em 06-10-2011 00:02, Stephen Rothwell escreveu:
> Hi Mauro,
>
> On Fri, 30 Sep 2011 15:38:13 -0700 Randy Dunlap<rdunlap@xenotime•net> wrote:
>>
>> On 09/30/11 14:34, Paul Gortmaker wrote:
>>> Both mt9t001.c and mt9p031.c have two identical issues, those
>>> being that they will need module.h inclusion for the upcoming
>>> cleanup going on there, and that their dependencies don't limit
>>> selection of configs that will fail to compile as follows:
>>>
>>> drivers/media/video/mt9p031.c:457: error: implicit declaration of function ‘v4l2_subdev_get_try_crop’
>>> drivers/media/video/mt9t001.c:787: error: ‘struct v4l2_subdev’ has no member named ‘entity’
>>>
>>> The related config options are CONFIG_MEDIA_CONTROLLER and
>>> CONFIG_VIDEO_V4L2_SUBDEV_API. Looking at the code, it appears
>>> that the driver was never intended to work without these enabled,
>>> so add a dependency on CONFIG_VIDEO_V4L2_SUBDEV_API, which in
>>> turn already has a dependency on CONFIG_MEDIA_CONTROLLER.
>>>
>>> Reported-by: Randy Dunlap<rdunlap@xenotime•net>
>>> Signed-off-by: Paul Gortmaker<paul.gortmaker@windriver•com>
>>
>> Acked-by: Randy Dunlap<rdunlap@xenotime•net>
>
> Ping?
>
Sorry, I was assuming that this patch would be going together with the
other module.h trees. I'll apply it on my tree.
Thanks,
Mauro
next prev parent reply other threads:[~2011-10-08 10:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-28 10:04 linux-next: Tree for Sept 28 Stephen Rothwell
2011-09-28 22:11 ` linux-next: Tree for Sept 28 (mrst) Randy Dunlap
2011-12-05 18:39 ` Randy Dunlap
2011-12-05 18:41 ` Ingo Molnar
2011-12-05 19:10 ` Alan Cox
2011-09-28 22:29 ` linux-next: Tree for Sept 28 (media/video/mt9p031.c) Randy Dunlap
2011-09-28 22:31 ` Randy Dunlap
2011-09-30 21:34 ` [PATCH] drivers/media: fix dependencies in video mt9t001/mt9p031 Paul Gortmaker
2011-09-30 22:38 ` Randy Dunlap
2011-10-06 3:02 ` Stephen Rothwell
2011-10-08 10:52 ` Mauro Carvalho Chehab [this message]
2011-10-09 3:39 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E902B89.7030004@redhat.com \
--to=mchehab@redhat$(echo .)com \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=paul.gortmaker@windriver$(echo .)com \
--cc=rdunlap@xenotime$(echo .)net \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox