From: Jiri Slaby <jslaby@suse•cz>
To: Heiko Carstens <heiko.carstens@de•ibm.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
linux-next@vger•kernel.org,
Martin Schwidefsky <schwidefsky@de•ibm.com>
Subject: Re: [PATCH -next] tty: add missing tty_port_tty_get() call to raw3215_wakeup
Date: Tue, 17 Apr 2012 14:35:32 +0200 [thread overview]
Message-ID: <4F8D6394.7070905@suse.cz> (raw)
In-Reply-To: <20120417111634.GA4382@osiris.boeblingen.de.ibm.com>
On 04/17/2012 01:16 PM, Heiko Carstens wrote:
> Fix compile error caused by "TTY: con3215, use tty from tty_port":
>
> CC drivers/s390/char/con3215.o
> drivers/s390/char/con3215.c: In function 'raw3215_wakeup':
> drivers/s390/char/con3215.c:339:16: error: 'struct raw3215_info' has no member named 'tty'
> make[1]: *** [drivers/s390/char/con3215.o] Error 1
> make: *** [drivers/s390/char/] Error 2
Aha, that's because I rebased the tasklet removal patch on the top of
the other two patches so I don't see the error in my local tree.
> Cc: Jiri Slaby <jslaby@suse•cz>
Acked-by: Jiri Slaby <jslaby@suse•cz>
and thanks.
> Cc: Martin Schwidefsky <schwidefsky@de•ibm.com>
> Signed-off-by: Heiko Carstens <heiko.carstens@de•ibm.com>
> ---
> drivers/s390/char/con3215.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/s390/char/con3215.c b/drivers/s390/char/con3215.c
> index e928e04..6c0116d 100644
> --- a/drivers/s390/char/con3215.c
> +++ b/drivers/s390/char/con3215.c
> @@ -336,7 +336,11 @@ static inline void raw3215_try_io(struct raw3215_info *raw)
> static void raw3215_wakeup(unsigned long data)
> {
> struct raw3215_info *raw = (struct raw3215_info *) data;
> - tty_wakeup(raw->tty);
> + struct tty_struct *tty;
> +
> + tty = tty_port_tty_get(&raw->port);
> + tty_wakeup(tty);
> + tty_kref_put(tty);
> }
>
> /*
>
--
js
suse labs
prev parent reply other threads:[~2012-04-17 12:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-17 11:16 [PATCH -next] tty: add missing tty_port_tty_get() call to raw3215_wakeup Heiko Carstens
2012-04-17 12:35 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8D6394.7070905@suse.cz \
--to=jslaby@suse$(echo .)cz \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=heiko.carstens@de$(echo .)ibm.com \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=schwidefsky@de$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox