From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public•gmane.org>
To: Grant Likely <grant.likely-QSEj5FYQhm4dnm+yROfE0A@public•gmane.org>
Cc: Linus Walleij
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public•gmane.org>,
Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public•gmane.org>,
"devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public•gmane.org"
<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public•gmane.org>,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public•gmane.org>,
"linux-next-u79uwXL29TY76Z2rM5mHXA@public•gmane.org"
<linux-next-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
"linux-i2c-u79uwXL29TY76Z2rM5mHXA@public•gmane.org"
<linux-i2c-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>
Subject: Re: [PATCH v2] i2c: core: make it possible to match a pure device tree driver
Date: Mon, 17 Jun 2013 17:25:53 -0600 [thread overview]
Message-ID: <51BF9B01.1090205@wwwdotorg.org> (raw)
In-Reply-To: <CACxGe6sTq=h9jjqesjvUA4Bweh7zgE4VOLoOTgGPC_D_v+8NtA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 06/17/2013 04:15 PM, Grant Likely wrote:
> On Mon, Jun 17, 2013 at 5:33 PM, Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public•gmane.org> wrote:
>> On Mon, Jun 17, 2013 at 5:48 PM, Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public•gmane.org> wrote:
>>
>>> This has just shown up in next-20130617, and breaks at least the
>>> TPS65910 and TPS62360 drivers, since they assume that the id parameter
>>> passed to probe is non-NULL. However, now the parameter is NULL since
>>> these drivers have both an ID table and an OF match table.
>>
>> So you mean they come in through the DT boot path and assume
>> that parameter is non-null even though they should not make use of
>> it?
>>
>>> I'd like to suggest this patch be reverted an re-introduced immediately
>>> after the merge window. That should give enough time for everyone to get
>>> a heads-up on fixing any drivers with a similar problem, rather than
>>> trying to cram all that in immediately before the merge window.
>>
>> OK that works for me, I'm not in any hurry.
>
> Deferring by a merge window isn't going to make it any less painful.
It'll give a lot more time for people to be exposed to the change and
hence find/fix it linux-next rather than seeing it for the first time in
Linus's tree.
next prev parent reply other threads:[~2013-06-17 23:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1368476301-10495-1-git-send-email-linus.walleij@linaro.org>
[not found] ` <CACRpkdae1chj9ZKuQV5MuiaicLUTKr4hZqr8rtjbB3Yjt+U_fg@mail.gmail.com>
2013-06-17 15:48 ` [PATCH v2] i2c: core: make it possible to match a pure device tree driver Stephen Warren
[not found] ` <51BF2FC5.40207-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-06-17 16:33 ` Linus Walleij
[not found] ` <CACRpkdbjy+PcpNkSg4PuuP2Z9RyrnqSW0uchHFHVZ8VYPeoDyA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-06-17 16:49 ` Stephen Warren
2013-06-17 22:15 ` Grant Likely
[not found] ` <CACxGe6sTq=h9jjqesjvUA4Bweh7zgE4VOLoOTgGPC_D_v+8NtA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-06-17 23:25 ` Stephen Warren [this message]
2013-06-18 7:33 ` Wolfram Sang
2013-06-18 7:44 ` Linus Walleij
[not found] ` <CACRpkdakdUVzHM4L5qOJ5Ls8NwOimy197NCUDSP=X28d2fzHPg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-06-18 15:55 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51BF9B01.1090205@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public$(echo .)gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public$(echo .)gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public$(echo .)gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public$(echo .)gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-next-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public$(echo .)gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox