From: "Luck, Tony" <tony.luck@intel•com>
To: David Airlie <airlied@linux•ie>
Cc: dri-devel@lists•freedesktop.org, linux-next@vger•kernel.org
Subject: [PATCH] Fix #include in drm_mm.h to unbreak ia64 build
Date: Mon, 29 Jul 2013 11:51:33 -0700 [thread overview]
Message-ID: <51f6b9b51365634ccf@agluck-desk.sc.intel.com> (raw)
Linux-next build on ia64 is falling over with errors like this:
In file included from include/drm/drm_vma_manager.h:26,
from include/drm/ttm/ttm_bo_api.h:35,
from include/drm/ttm/ttm_bo_driver.h:33,
from drivers/gpu/drm/ttm/ttm_agp_backend.c:35:
include/drm/drm_mm.h:67: error: expected specifier-qualifier-list before 'spinlock_t'
I guess other architectures are pulling in spinlock.h
through some twisty #include path so are not seeing this
error. But drm_mm.h makes use of spinlock_t - so it
should do the right thing and #include <linux/spinlock.h>
Signed-off-by: Tony Luck <tony.luck@intel•com>
---
First saw this break in tag "next-20130726"
diff --git a/include/drm/drm_mm.h b/include/drm/drm_mm.h
index b87d05e..7d5fbae 100644
--- a/include/drm/drm_mm.h
+++ b/include/drm/drm_mm.h
@@ -37,6 +37,7 @@
* Generic range manager structs
*/
#include <linux/list.h>
+#include <linux/spinlock.h>
#ifdef CONFIG_DEBUG_FS
#include <linux/seq_file.h>
#endif
next reply other threads:[~2013-07-29 18:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 18:51 Luck, Tony [this message]
2013-07-31 15:45 ` [PATCH] Fix #include in drm_mm.h to unbreak ia64 build David Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51f6b9b51365634ccf@agluck-desk.sc.intel.com \
--to=tony.luck@intel$(echo .)com \
--cc=airlied@linux$(echo .)ie \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=linux-next@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox