* [PATCH] Fix #include in drm_mm.h to unbreak ia64 build
@ 2013-07-29 18:51 Luck, Tony
2013-07-31 15:45 ` David Herrmann
0 siblings, 1 reply; 2+ messages in thread
From: Luck, Tony @ 2013-07-29 18:51 UTC (permalink / raw)
To: David Airlie; +Cc: dri-devel, linux-next
Linux-next build on ia64 is falling over with errors like this:
In file included from include/drm/drm_vma_manager.h:26,
from include/drm/ttm/ttm_bo_api.h:35,
from include/drm/ttm/ttm_bo_driver.h:33,
from drivers/gpu/drm/ttm/ttm_agp_backend.c:35:
include/drm/drm_mm.h:67: error: expected specifier-qualifier-list before 'spinlock_t'
I guess other architectures are pulling in spinlock.h
through some twisty #include path so are not seeing this
error. But drm_mm.h makes use of spinlock_t - so it
should do the right thing and #include <linux/spinlock.h>
Signed-off-by: Tony Luck <tony.luck@intel•com>
---
First saw this break in tag "next-20130726"
diff --git a/include/drm/drm_mm.h b/include/drm/drm_mm.h
index b87d05e..7d5fbae 100644
--- a/include/drm/drm_mm.h
+++ b/include/drm/drm_mm.h
@@ -37,6 +37,7 @@
* Generic range manager structs
*/
#include <linux/list.h>
+#include <linux/spinlock.h>
#ifdef CONFIG_DEBUG_FS
#include <linux/seq_file.h>
#endif
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Fix #include in drm_mm.h to unbreak ia64 build
2013-07-29 18:51 [PATCH] Fix #include in drm_mm.h to unbreak ia64 build Luck, Tony
@ 2013-07-31 15:45 ` David Herrmann
0 siblings, 0 replies; 2+ messages in thread
From: David Herrmann @ 2013-07-31 15:45 UTC (permalink / raw)
To: Luck, Tony; +Cc: David Airlie, linux-next, dri-devel@lists•freedesktop.org
Hi
On Mon, Jul 29, 2013 at 8:51 PM, Luck, Tony <tony.luck@intel•com> wrote:
> Linux-next build on ia64 is falling over with errors like this:
>
> In file included from include/drm/drm_vma_manager.h:26,
> from include/drm/ttm/ttm_bo_api.h:35,
> from include/drm/ttm/ttm_bo_driver.h:33,
> from drivers/gpu/drm/ttm/ttm_agp_backend.c:35:
> include/drm/drm_mm.h:67: error: expected specifier-qualifier-list before 'spinlock_t'
>
> I guess other architectures are pulling in spinlock.h
> through some twisty #include path so are not seeing this
> error. But drm_mm.h makes use of spinlock_t - so it
> should do the right thing and #include <linux/spinlock.h>
>
> Signed-off-by: Tony Luck <tony.luck@intel•com>
Yepp, that broke due to the drm_vma_manager.h include in TTM. There is
already a fix pending on the ML:
http://www.spinics.net/lists/dri-devel/msg42101.html
Thanks
David
> ---
>
> First saw this break in tag "next-20130726"
>
> diff --git a/include/drm/drm_mm.h b/include/drm/drm_mm.h
> index b87d05e..7d5fbae 100644
> --- a/include/drm/drm_mm.h
> +++ b/include/drm/drm_mm.h
> @@ -37,6 +37,7 @@
> * Generic range manager structs
> */
> #include <linux/list.h>
> +#include <linux/spinlock.h>
> #ifdef CONFIG_DEBUG_FS
> #include <linux/seq_file.h>
> #endif
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists•freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-07-31 15:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-29 18:51 [PATCH] Fix #include in drm_mm.h to unbreak ia64 build Luck, Tony
2013-07-31 15:45 ` David Herrmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox